You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/11 08:37:12 UTC
[GitHub] [incubator-doris] morrySnow opened a new pull request, #8954: [enhancement] take all previous broadcast join consumption into account when choose join algorithm
morrySnow opened a new pull request, #8954:
URL: https://github.com/apache/incubator-doris/pull/8954
# Proposed changes
According to discussion in the issue #8695
https://github.com/apache/incubator-doris/pull/8695#discussion_r838442611
We need to take all broadcast cost in one fragment when compute current node broadcast join consumption.
This patch is a simple implement to do this.
The algorithm is very simple:
```
long spaceUsedInFragment = spaceUsedByPreviousJoinNodes + spaceUsedByCurrentNode;
if (spaceUsedInFragment <= threshold) {
doBroadcast = true;
} else {
doBroadcast = false;
}
```
we could update this algorithm to choose best split position in future.
## Checklist(Required)
1. Does it affect the original behavior: (Yes)
2. Has unit tests been added: (Yes)
3. Has document been added or modified: (No)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow closed pull request #8954: [enhancement] take all previous broadcast join consumption into account when choose join algorithm
Posted by GitBox <gi...@apache.org>.
morrySnow closed pull request #8954: [enhancement] take all previous broadcast join consumption into account when choose join algorithm
URL: https://github.com/apache/doris/pull/8954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org