You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/05/03 11:20:46 UTC

[GitHub] [geode] mkevo opened a new pull request, #7643: GEODE-10267: fix creating gw sender with non-existent disk store

mkevo opened a new pull request, #7643:
URL: https://github.com/apache/geode/pull/7643

   <!-- Thank you for submitting a contribution to Apache Geode. -->
   
   <!-- In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken: 
   -->
   Problem:
   -**parallel gw sender**:
        When creating a parallel gw sender with a non-existent disk store it will pass as it will not check if disk store exist.
   -**serial gw sender**:
        When running the command for creating a serial gw sender with a non-existent disk store it will fail, **but** a serial gw sender will be created. If we then create a disk store and run the same command again it will fail as the gw sender is already created.
   
   Solution:
   Check if the disk store parameter is set and check if that disk store exists in the system.
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   <!-- Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] mkevo merged pull request #7643: GEODE-10267: fix creating gw sender with non-existent disk store

Posted by GitBox <gi...@apache.org>.
mkevo merged PR #7643:
URL: https://github.com/apache/geode/pull/7643


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] mkevo commented on pull request #7643: GEODE-10267: fix creating gw sender with non-existent disk store

Posted by GitBox <gi...@apache.org>.
mkevo commented on PR #7643:
URL: https://github.com/apache/geode/pull/7643#issuecomment-1149637793

   Hi @gesterzhou, @boglesby, @nabarunnag, @pivotal-jbarrett, can you please add your review on this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org