You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Eelco Hillenius (JIRA)" <ji...@apache.org> on 2007/04/01 20:35:32 UTC
[jira] Created: (WICKET-442) adding (and querying) feedback
messages at construction time fails.
adding (and querying) feedback messages at construction time fails.
-------------------------------------------------------------------
Key: WICKET-442
URL: https://issues.apache.org/jira/browse/WICKET-442
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.2.5, 1.3
Reporter: Eelco Hillenius
Assigned To: Eelco Hillenius
Fix For: 1.3
Attachments: WICKET-442.patch
See http://www.nabble.com/error%28...%29-No-page-found-for-component-tf3497125.html
Currently, adding (and querying) feedback messages fails whenever it is done on components that are not yet added to a page (or were removed from them due to component replacement).
There are two ways to fix this. The first fix is attached as a patch, and basically uses a thread local to temporarily store the messages and distribute them to the relevant page instances just in time or when rendering starts. The advantage of this method is that it is completely back wards compatible.
The other way to fix this is to store all messages, whether component specific or not, in the session, and pull them from there. We need to be careful about how/ when to clean these error messages up though. We can use this issue to think about it a little bit more.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-442) adding (and querying) feedback
messages at construction time fails.
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eelco Hillenius resolved WICKET-442.
------------------------------------
Resolution: Fixed
Implemented session based approach with aggressive cleanup, but with the option for people to override.
> adding (and querying) feedback messages at construction time fails.
> -------------------------------------------------------------------
>
> Key: WICKET-442
> URL: https://issues.apache.org/jira/browse/WICKET-442
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.5, 1.3
> Reporter: Eelco Hillenius
> Assigned To: Eelco Hillenius
> Fix For: 1.3
>
> Attachments: WICKET-442-2.patch, WICKET-442-3.patch, WICKET-442.patch
>
>
> See http://www.nabble.com/error%28...%29-No-page-found-for-component-tf3497125.html
> Currently, adding (and querying) feedback messages fails whenever it is done on components that are not yet added to a page (or were removed from them due to component replacement).
> There are two ways to fix this. The first fix is attached as a patch, and basically uses a thread local to temporarily store the messages and distribute them to the relevant page instances just in time or when rendering starts. The advantage of this method is that it is completely back wards compatible.
> The other way to fix this is to store all messages, whether component specific or not, in the session, and pull them from there. We need to be careful about how/ when to clean these error messages up though. We can use this issue to think about it a little bit more.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-442) adding (and querying) feedback
messages at construction time fails.
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eelco Hillenius updated WICKET-442:
-----------------------------------
Attachment: WICKET-442.patch
Page centric solution
> adding (and querying) feedback messages at construction time fails.
> -------------------------------------------------------------------
>
> Key: WICKET-442
> URL: https://issues.apache.org/jira/browse/WICKET-442
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.5, 1.3
> Reporter: Eelco Hillenius
> Assigned To: Eelco Hillenius
> Fix For: 1.3
>
> Attachments: WICKET-442.patch
>
>
> See http://www.nabble.com/error%28...%29-No-page-found-for-component-tf3497125.html
> Currently, adding (and querying) feedback messages fails whenever it is done on components that are not yet added to a page (or were removed from them due to component replacement).
> There are two ways to fix this. The first fix is attached as a patch, and basically uses a thread local to temporarily store the messages and distribute them to the relevant page instances just in time or when rendering starts. The advantage of this method is that it is completely back wards compatible.
> The other way to fix this is to store all messages, whether component specific or not, in the session, and pull them from there. We need to be careful about how/ when to clean these error messages up though. We can use this issue to think about it a little bit more.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-442) adding (and querying) feedback
messages at construction time fails.
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eelco Hillenius updated WICKET-442:
-----------------------------------
Attachment: WICKET-442-2.patch
patch based on messages in the session
> adding (and querying) feedback messages at construction time fails.
> -------------------------------------------------------------------
>
> Key: WICKET-442
> URL: https://issues.apache.org/jira/browse/WICKET-442
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.5, 1.3
> Reporter: Eelco Hillenius
> Assigned To: Eelco Hillenius
> Fix For: 1.3
>
> Attachments: WICKET-442-2.patch, WICKET-442.patch
>
>
> See http://www.nabble.com/error%28...%29-No-page-found-for-component-tf3497125.html
> Currently, adding (and querying) feedback messages fails whenever it is done on components that are not yet added to a page (or were removed from them due to component replacement).
> There are two ways to fix this. The first fix is attached as a patch, and basically uses a thread local to temporarily store the messages and distribute them to the relevant page instances just in time or when rendering starts. The advantage of this method is that it is completely back wards compatible.
> The other way to fix this is to store all messages, whether component specific or not, in the session, and pull them from there. We need to be careful about how/ when to clean these error messages up though. We can use this issue to think about it a little bit more.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-442) adding (and querying) feedback
messages at construction time fails.
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eelco Hillenius updated WICKET-442:
-----------------------------------
Attachment: WICKET-442-3.patch
alternative session based patch. This one clears all page specific components at the start of the events part of a request, rather than just for this specific page.
> adding (and querying) feedback messages at construction time fails.
> -------------------------------------------------------------------
>
> Key: WICKET-442
> URL: https://issues.apache.org/jira/browse/WICKET-442
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.5, 1.3
> Reporter: Eelco Hillenius
> Assigned To: Eelco Hillenius
> Fix For: 1.3
>
> Attachments: WICKET-442-2.patch, WICKET-442-3.patch, WICKET-442.patch
>
>
> See http://www.nabble.com/error%28...%29-No-page-found-for-component-tf3497125.html
> Currently, adding (and querying) feedback messages fails whenever it is done on components that are not yet added to a page (or were removed from them due to component replacement).
> There are two ways to fix this. The first fix is attached as a patch, and basically uses a thread local to temporarily store the messages and distribute them to the relevant page instances just in time or when rendering starts. The advantage of this method is that it is completely back wards compatible.
> The other way to fix this is to store all messages, whether component specific or not, in the session, and pull them from there. We need to be careful about how/ when to clean these error messages up though. We can use this issue to think about it a little bit more.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-442) adding (and querying) feedback messages
at construction time fails.
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eelco Hillenius closed WICKET-442.
----------------------------------
> adding (and querying) feedback messages at construction time fails.
> -------------------------------------------------------------------
>
> Key: WICKET-442
> URL: https://issues.apache.org/jira/browse/WICKET-442
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.5, 1.3
> Reporter: Eelco Hillenius
> Assigned To: Eelco Hillenius
> Fix For: 1.3
>
> Attachments: WICKET-442-2.patch, WICKET-442-3.patch, WICKET-442.patch
>
>
> See http://www.nabble.com/error%28...%29-No-page-found-for-component-tf3497125.html
> Currently, adding (and querying) feedback messages fails whenever it is done on components that are not yet added to a page (or were removed from them due to component replacement).
> There are two ways to fix this. The first fix is attached as a patch, and basically uses a thread local to temporarily store the messages and distribute them to the relevant page instances just in time or when rendering starts. The advantage of this method is that it is completely back wards compatible.
> The other way to fix this is to store all messages, whether component specific or not, in the session, and pull them from there. We need to be careful about how/ when to clean these error messages up though. We can use this issue to think about it a little bit more.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.