You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/04 05:41:59 UTC

[GitHub] [spark] mridulm commented on pull request #35637: [SPARK-38309][Core] Fix incorrect SHS stage percentile metrics for shuffle read bytes and shuffle total blocks

mridulm commented on pull request #35637:
URL: https://github.com/apache/spark/pull/35637#issuecomment-1058847727


   Since the existing test was not catching this issue, I want to make sure that we are testing for this behavior.
   Given that we have exhaustively tested the current metrics - including the one which had an issue, this looks fine to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org