You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/03/02 07:10:31 UTC

[GitHub] [camel] tadayosi opened a new pull request #5150: CAMEL-16280: NettyEndpointUriFactory#buildUri() not compatible with Netty endpoint URL

tadayosi opened a new pull request #5150:
URL: https://github.com/apache/camel/pull/5150


   https://issues.apache.org/jira/browse/CAMEL-16280


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #5150: CAMEL-16280: NettyEndpointUriFactory#buildUri() not compatible with Netty endpoint URL

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #5150:
URL: https://github.com/apache/camel/pull/5150#issuecomment-788687581


   On another thought then I can't remember why we require the double slash, most components dont do this.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] tadayosi commented on pull request #5150: CAMEL-16280: NettyEndpointUriFactory#buildUri() not compatible with Netty endpoint URL

Posted by GitBox <gi...@apache.org>.
tadayosi commented on pull request #5150:
URL: https://github.com/apache/camel/pull/5150#issuecomment-788687704


   @davsclaus camel-netty-http is already covered in this pull req ;-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus merged pull request #5150: CAMEL-16280: NettyEndpointUriFactory#buildUri() not compatible with Netty endpoint URL

Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #5150:
URL: https://github.com/apache/camel/pull/5150


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #5150: CAMEL-16280: NettyEndpointUriFactory#buildUri() not compatible with Netty endpoint URL

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #5150:
URL: https://github.com/apache/camel/pull/5150#issuecomment-788686915


   Ah yeah netty and netty-http has this special thing by requiring the double slash.
   
   @tadayosi you are welcome to look at camel-netty-http and build a similar unit test and fix if we have the same problem there.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] tadayosi commented on pull request #5150: CAMEL-16280: NettyEndpointUriFactory#buildUri() not compatible with Netty endpoint URL

Posted by GitBox <gi...@apache.org>.
tadayosi commented on pull request #5150:
URL: https://github.com/apache/camel/pull/5150#issuecomment-788681874


   @oscerd By the way, this type of endpoint declaration never got deployed prior to this fix, so probably changing the syntax to `netty:protocol://host:port` doesn't have any impact on users' applications.
   ```java
   from("netty:tcp:localhost:9999")
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] oscerd commented on pull request #5150: CAMEL-16280: NettyEndpointUriFactory#buildUri() not compatible with Netty endpoint URL

Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #5150:
URL: https://github.com/apache/camel/pull/5150#issuecomment-788682751


   Yes, just to track the change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org