You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/09/05 00:10:28 UTC
[GitHub] [hudi] akanungoz opened a new pull request #3602: [HUDI-2398] Update event time for inserts
akanungoz opened a new pull request #3602:
URL: https://github.com/apache/hudi/pull/3602
## What is the purpose of the pull request
* overwrite getInsertValue method in DefaultHoodieRecordPayload class to populate event time for inserts.
## Verify this pull request
- *Added unit tests for newly overwritten method, existing tests updated to use new method (and integration tests seems running okay)*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3602: [HUDI-2398] Update event time for inserts
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3602:
URL: https://github.com/apache/hudi/pull/3602#issuecomment-913059353
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2030",
"triggerID" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"triggerType" : "PUSH"
}, {
"hash" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2054",
"triggerID" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 999fa20fb6fd6fb1cdee20a1d74eea38c729261a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2030)
* 5ae96d69048625bc7556ae354bc980ec8b2db7ff Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2054)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3602: [HUDI-2398] Update event time for inserts
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3602:
URL: https://github.com/apache/hudi/pull/3602#issuecomment-913059353
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2030",
"triggerID" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"triggerType" : "PUSH"
}, {
"hash" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2054",
"triggerID" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"triggerType" : "PUSH"
}, {
"hash" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2055",
"triggerID" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"triggerType" : "PUSH"
}, {
"hash" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2060",
"triggerID" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"triggerType" : "PUSH"
}, {
"hash" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2077",
"triggerID" : "914449432",
"triggerType" : "MANUAL"
}, {
"hash" : "75470352f8a6df5065447e822e280c64e0010782",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2152",
"triggerID" : "75470352f8a6df5065447e822e280c64e0010782",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77f3ed00f24acca10dd28c759dc12ba5e3549b13 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2060) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2077)
* 75470352f8a6df5065447e822e280c64e0010782 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2152)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3602: [HUDI-2398] Update event time for inserts
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3602:
URL: https://github.com/apache/hudi/pull/3602#issuecomment-913059353
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2030",
"triggerID" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"triggerType" : "PUSH"
}, {
"hash" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2054",
"triggerID" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"triggerType" : "PUSH"
}, {
"hash" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2055",
"triggerID" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5ae96d69048625bc7556ae354bc980ec8b2db7ff Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2054)
* 406ee83ba5a1dad175e480725bc1d4812ddd07dd Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2055)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3602: [HUDI-2398] Update event time for inserts
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3602:
URL: https://github.com/apache/hudi/pull/3602#issuecomment-913059353
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2030",
"triggerID" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"triggerType" : "PUSH"
}, {
"hash" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2054",
"triggerID" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"triggerType" : "PUSH"
}, {
"hash" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 999fa20fb6fd6fb1cdee20a1d74eea38c729261a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2030)
* 5ae96d69048625bc7556ae354bc980ec8b2db7ff Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2054)
* 406ee83ba5a1dad175e480725bc1d4812ddd07dd UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3602: [HUDI-2398] Update event time for inserts
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3602:
URL: https://github.com/apache/hudi/pull/3602#issuecomment-913059353
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2030",
"triggerID" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"triggerType" : "PUSH"
}, {
"hash" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2054",
"triggerID" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"triggerType" : "PUSH"
}, {
"hash" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2055",
"triggerID" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"triggerType" : "PUSH"
}, {
"hash" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2060",
"triggerID" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"triggerType" : "PUSH"
}, {
"hash" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2077",
"triggerID" : "914449432",
"triggerType" : "MANUAL"
}, {
"hash" : "75470352f8a6df5065447e822e280c64e0010782",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2152",
"triggerID" : "75470352f8a6df5065447e822e280c64e0010782",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75470352f8a6df5065447e822e280c64e0010782 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2152)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3602: [HUDI-2398] Update event time for inserts
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3602:
URL: https://github.com/apache/hudi/pull/3602#issuecomment-913059353
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2030",
"triggerID" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"triggerType" : "PUSH"
}, {
"hash" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2054",
"triggerID" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"triggerType" : "PUSH"
}, {
"hash" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2055",
"triggerID" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"triggerType" : "PUSH"
}, {
"hash" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2060",
"triggerID" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"triggerType" : "PUSH"
}, {
"hash" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2077",
"triggerID" : "914449432",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 77f3ed00f24acca10dd28c759dc12ba5e3549b13 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2060) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2077)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3602: [HUDI-2398] Update event time for inserts
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3602:
URL: https://github.com/apache/hudi/pull/3602#issuecomment-913059353
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2030",
"triggerID" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"triggerType" : "PUSH"
}, {
"hash" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2054",
"triggerID" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"triggerType" : "PUSH"
}, {
"hash" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2055",
"triggerID" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"triggerType" : "PUSH"
}, {
"hash" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 406ee83ba5a1dad175e480725bc1d4812ddd07dd Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2055)
* 77f3ed00f24acca10dd28c759dc12ba5e3549b13 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3602: [HUDI-2398] Update event time for inserts
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3602:
URL: https://github.com/apache/hudi/pull/3602#issuecomment-913059353
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 999fa20fb6fd6fb1cdee20a1d74eea38c729261a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #3602: [HUDI-2398] Update event time for inserts
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #3602:
URL: https://github.com/apache/hudi/pull/3602#discussion_r703072819
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieSortedMergeHandle.java
##########
@@ -112,9 +112,9 @@ public void write(GenericRecord oldRecord) {
HoodieRecord<T> hoodieRecord = keyToNewRecords.get(key);
if (!writtenRecordKeys.contains(hoodieRecord.getRecordKey())) {
if (useWriterSchema) {
- writeRecord(hoodieRecord, hoodieRecord.getData().getInsertValue(tableSchemaWithMetaFields));
+ writeRecord(hoodieRecord, hoodieRecord.getData().getInsertValue(tableSchemaWithMetaFields, config.getProps()));
} else {
- writeRecord(hoodieRecord, hoodieRecord.getData().getInsertValue(tableSchema));
+ writeRecord(hoodieRecord, hoodieRecord.getData().getInsertValue(tableSchema, config.getProps()));
Review comment:
pls double confirm this and similar changes above are compatible to all other payload class implementations.
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/model/DefaultHoodieRecordPayload.java
##########
@@ -68,17 +67,31 @@ public DefaultHoodieRecordPayload(Option<GenericRecord> record) {
/*
* We reached a point where the value is disk is older than the incoming record.
*/
- eventTime = Option.ofNullable(getNestedFieldVal(incomingRecord, hoodieConfig
- .getString(HoodiePayloadProps.PAYLOAD_EVENT_TIME_FIELD_PROP_KEY), true));
+ updateEventTime(incomingRecord, properties);
/*
* Now check if the incoming record is a delete record.
*/
- if (isDeleteRecord(incomingRecord)) {
+ return isDeleteRecord(incomingRecord) ? Option.empty() : Option.of(incomingRecord);
+ }
+
+ @Override
+ public Option<IndexedRecord> getInsertValue(Schema schema, Properties properties) throws IOException {
+ if (recordBytes.length == 0) {
return Option.empty();
- } else {
- return Option.of(incomingRecord);
}
+ GenericRecord incomingRecord = incomingRecord(schema);
+ updateEventTime(incomingRecord, properties);
+
+ return isDeleteRecord(incomingRecord) ? Option.empty() : Option.of(incomingRecord);
+ }
+
+ private GenericRecord incomingRecord(Schema schema) throws IOException {
+ return bytesToAvro(recordBytes, schema);
+ }
Review comment:
feel like this method is redundant. it only invokes `bytesToAvro`, which is more obvious to reader what happened. the variable name `incomingRecord` already tells what is returned.
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/model/DefaultHoodieRecordPayload.java
##########
@@ -68,17 +67,31 @@ public DefaultHoodieRecordPayload(Option<GenericRecord> record) {
/*
* We reached a point where the value is disk is older than the incoming record.
*/
- eventTime = Option.ofNullable(getNestedFieldVal(incomingRecord, hoodieConfig
- .getString(HoodiePayloadProps.PAYLOAD_EVENT_TIME_FIELD_PROP_KEY), true));
+ updateEventTime(incomingRecord, properties);
/*
* Now check if the incoming record is a delete record.
*/
- if (isDeleteRecord(incomingRecord)) {
+ return isDeleteRecord(incomingRecord) ? Option.empty() : Option.of(incomingRecord);
+ }
+
+ @Override
+ public Option<IndexedRecord> getInsertValue(Schema schema, Properties properties) throws IOException {
+ if (recordBytes.length == 0) {
return Option.empty();
- } else {
- return Option.of(incomingRecord);
}
+ GenericRecord incomingRecord = incomingRecord(schema);
+ updateEventTime(incomingRecord, properties);
+
+ return isDeleteRecord(incomingRecord) ? Option.empty() : Option.of(incomingRecord);
+ }
+
+ private GenericRecord incomingRecord(Schema schema) throws IOException {
+ return bytesToAvro(recordBytes, schema);
+ }
+
+ private void updateEventTime(GenericRecord record, Properties properties) {
+ eventTime = Option.ofNullable(getNestedFieldVal(record, properties.getProperty(HoodiePayloadProps.PAYLOAD_EVENT_TIME_FIELD_PROP_KEY), true));
Review comment:
this method better be static, easier to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3602: [HUDI-2398] Update event time for inserts
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3602:
URL: https://github.com/apache/hudi/pull/3602#issuecomment-913059353
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2030",
"triggerID" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"triggerType" : "PUSH"
}, {
"hash" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2054",
"triggerID" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"triggerType" : "PUSH"
}, {
"hash" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2055",
"triggerID" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"triggerType" : "PUSH"
}, {
"hash" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2060",
"triggerID" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77f3ed00f24acca10dd28c759dc12ba5e3549b13 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2060)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3602: [HUDI-2398] Update event time for inserts
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3602:
URL: https://github.com/apache/hudi/pull/3602#issuecomment-913059353
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2030",
"triggerID" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"triggerType" : "PUSH"
}, {
"hash" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2054",
"triggerID" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"triggerType" : "PUSH"
}, {
"hash" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2055",
"triggerID" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 406ee83ba5a1dad175e480725bc1d4812ddd07dd Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2055)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3602: [HUDI-2398] Update event time for inserts
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3602:
URL: https://github.com/apache/hudi/pull/3602#issuecomment-913059353
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2030",
"triggerID" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"triggerType" : "PUSH"
}, {
"hash" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2054",
"triggerID" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"triggerType" : "PUSH"
}, {
"hash" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2055",
"triggerID" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"triggerType" : "PUSH"
}, {
"hash" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2060",
"triggerID" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 406ee83ba5a1dad175e480725bc1d4812ddd07dd Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2055)
* 77f3ed00f24acca10dd28c759dc12ba5e3549b13 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2060)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3602: [HUDI-2398] Update event time for inserts
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3602:
URL: https://github.com/apache/hudi/pull/3602#issuecomment-913059353
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2030",
"triggerID" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"triggerType" : "PUSH"
}, {
"hash" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 999fa20fb6fd6fb1cdee20a1d74eea38c729261a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2030)
* 5ae96d69048625bc7556ae354bc980ec8b2db7ff UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3602: [HUDI-2398] Update event time for inserts
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3602:
URL: https://github.com/apache/hudi/pull/3602#issuecomment-913059353
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2030",
"triggerID" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"triggerType" : "PUSH"
}, {
"hash" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2054",
"triggerID" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"triggerType" : "PUSH"
}, {
"hash" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2055",
"triggerID" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"triggerType" : "PUSH"
}, {
"hash" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2060",
"triggerID" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"triggerType" : "PUSH"
}, {
"hash" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2077",
"triggerID" : "914449432",
"triggerType" : "MANUAL"
}, {
"hash" : "75470352f8a6df5065447e822e280c64e0010782",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "75470352f8a6df5065447e822e280c64e0010782",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77f3ed00f24acca10dd28c759dc12ba5e3549b13 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2060) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2077)
* 75470352f8a6df5065447e822e280c64e0010782 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3602: [HUDI-2398] Update event time for inserts
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3602:
URL: https://github.com/apache/hudi/pull/3602#issuecomment-913059353
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2030",
"triggerID" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 999fa20fb6fd6fb1cdee20a1d74eea38c729261a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2030)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3602: [HUDI-2398] Update event time for inserts
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3602:
URL: https://github.com/apache/hudi/pull/3602#issuecomment-913059353
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2030",
"triggerID" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"triggerType" : "PUSH"
}, {
"hash" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2054",
"triggerID" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"triggerType" : "PUSH"
}, {
"hash" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2055",
"triggerID" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"triggerType" : "PUSH"
}, {
"hash" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2060",
"triggerID" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"triggerType" : "PUSH"
}, {
"hash" : "77f3ed00f24acca10dd28c759dc12ba5e3549b13",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2077",
"triggerID" : "914449432",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 77f3ed00f24acca10dd28c759dc12ba5e3549b13 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2060) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2077)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan merged pull request #3602: [HUDI-2398] Update event time for inserts
Posted by GitBox <gi...@apache.org>.
xushiyan merged pull request #3602:
URL: https://github.com/apache/hudi/pull/3602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3602: [HUDI-2398] Update event time for inserts
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3602:
URL: https://github.com/apache/hudi/pull/3602#issuecomment-913059353
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2030",
"triggerID" : "999fa20fb6fd6fb1cdee20a1d74eea38c729261a",
"triggerType" : "PUSH"
}, {
"hash" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2054",
"triggerID" : "5ae96d69048625bc7556ae354bc980ec8b2db7ff",
"triggerType" : "PUSH"
}, {
"hash" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "406ee83ba5a1dad175e480725bc1d4812ddd07dd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5ae96d69048625bc7556ae354bc980ec8b2db7ff Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2054)
* 406ee83ba5a1dad175e480725bc1d4812ddd07dd UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #3602: [HUDI-2398] Update event time for inserts
Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #3602:
URL: https://github.com/apache/hudi/pull/3602#issuecomment-914449432
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #3602: [HUDI-2398] Update event time for inserts
Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #3602:
URL: https://github.com/apache/hudi/pull/3602#issuecomment-913823927
@akanungoz can you rebase master pls?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org