You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by "Timothy St. Clair" <ts...@redhat.com> on 2014/09/04 23:00:22 UTC

Review Request 25355: Minor update to include package config file

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25355/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.


Bugs: MESOS-1764
    https://issues.apache.org/jira/browse/MESOS-1764


Repository: mesos-git


Description
-------

Minor update to include package config file 


Diffs
-----

  Makefile.am e4ffa35 

Diff: https://reviews.apache.org/r/25355/diff/


Testing
-------

make check


Thanks,

Timothy St. Clair

Re: Review Request 25355: Minor update to include package config file

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25355/#review52398
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Sept. 4, 2014, 9 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25355/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 9 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1764
>     https://issues.apache.org/jira/browse/MESOS-1764
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Minor update to include package config file 
> 
> 
> Diffs
> -----
> 
>   Makefile.am e4ffa35 
> 
> Diff: https://reviews.apache.org/r/25355/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 25355: Minor update to include package config file

Posted by "Timothy St. Clair" <ts...@redhat.com>.


> On Sept. 4, 2014, 9:19 p.m., Vinod Kone wrote:
> > Makefile.am, lines 27-28
> > <https://reviews.apache.org/r/25355/diff/1/?file=679007#file679007line27>
> >
> >     i'm likely missing context. what is this for?

A while back we added a package config file, or .pc file.  This mod installs it in the default location.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25355/#review52358
-----------------------------------------------------------


On Sept. 4, 2014, 9 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25355/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 9 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1764
>     https://issues.apache.org/jira/browse/MESOS-1764
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Minor update to include package config file 
> 
> 
> Diffs
> -----
> 
>   Makefile.am e4ffa35 
> 
> Diff: https://reviews.apache.org/r/25355/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 25355: Minor update to include package config file

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25355/#review52358
-----------------------------------------------------------



Makefile.am
<https://reviews.apache.org/r/25355/#comment91125>

    i'm likely missing context. what is this for?


- Vinod Kone


On Sept. 4, 2014, 9 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25355/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 9 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1764
>     https://issues.apache.org/jira/browse/MESOS-1764
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Minor update to include package config file 
> 
> 
> Diffs
> -----
> 
>   Makefile.am e4ffa35 
> 
> Diff: https://reviews.apache.org/r/25355/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 25355: Minor update to include package config file

Posted by Mesos ReviewBot <de...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25355/#review52448
-----------------------------------------------------------


Patch looks great!

Reviews applied: [25355]

All tests passed.

- Mesos ReviewBot


On Sept. 4, 2014, 9 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25355/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 9 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1764
>     https://issues.apache.org/jira/browse/MESOS-1764
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Minor update to include package config file 
> 
> 
> Diffs
> -----
> 
>   Makefile.am e4ffa35 
> 
> Diff: https://reviews.apache.org/r/25355/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>