You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Timothy Chen <tn...@apache.org> on 2014/08/10 07:52:46 UTC
Re: Review Request 24464: Redirect docker logs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/
-----------------------------------------------------------
(Updated Aug. 10, 2014, 5:52 a.m.)
Review request for drill, Benjamin Hindman and Jie Yu.
Changes
-------
The unit test I added actually found a problem that docker somehow doesn't clean up the docker logs process when the container dies even though it did when tested externally.
Therefore I need to kill the log process when the container is reaped.
Repository: mesos-git
Description
-------
Review: https://reviews.apache.org/r/24464
Diffs (updated)
-----
src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48
src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c
src/tests/docker_containerizer_tests.cpp a559836dd11a9a97e5939364c4b35a8dbb6a503d
Diff: https://reviews.apache.org/r/24464/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 24464: Redirect docker logs
Posted by Timothy Chen <tn...@apache.org>.
> On Aug. 11, 2014, 3:53 a.m., Jie Yu wrote:
> > src/docker/docker.hpp, lines 96-99
> > <https://reviews.apache.org/r/24464/diff/9/?file=657101#file657101line96>
> >
> > Hum, this interface is weird to me. What if in the future we switch to use the REST api, what does the return value mean?
> >
> > Ideally, docker.logs should return a 'stream' object, something like this:
> >
> > class Docker {
> > class LogStream {
> > int out(); // return the out pipe.
> > int err(); // return the err pipe.
> > void close(); // terminate the subprocess.
> > ...
> > };
> >
> > Future<LogStream> logs(const string& containerName);
> > };
> >
> > docker.logs(containerName).then(lambda::bind(&_logs, lambda::_1);
> >
> > void _logs(const Docker::LogStream& stream)
> > {
> > io::redirect(stream.out(), "stdout");
> > io::redirect(stream.err(), "stderr");
> > }
I was debating about this too,
And was thinking to hide it all completely by holding state to docker abstraction but it was a bit too complicated than I like to so end up doing this.
I think wrapping the log stream object sounds like a good middle road. I'll do this tonight
> On Aug. 11, 2014, 3:53 a.m., Jie Yu wrote:
> > src/docker/docker.cpp, lines 84-87
> > <https://reviews.apache.org/r/24464/diff/9/?file=657102#file657102line84>
> >
> > Looks like these changes are not necessary given your recent changes?
Sounds good
> On Aug. 11, 2014, 3:53 a.m., Jie Yu wrote:
> > src/tests/docker_containerizer_tests.cpp, lines 888-889
> > <https://reviews.apache.org/r/24464/diff/9/?file=657104#file657104line888>
> >
> > Can you expand here: what extra log will be there if you run the above command:
> >
> > /bin/sh -c 'echo out!; echo err! 1>&2'
I'm redirecting the command executor log output to stdout and stderr, so it also has glog init messages.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/#review50134
-----------------------------------------------------------
On Aug. 10, 2014, 6:51 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24464/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2014, 6:51 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/24464
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48
> src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
> src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c
> src/tests/docker_containerizer_tests.cpp a559836dd11a9a97e5939364c4b35a8dbb6a503d
>
> Diff: https://reviews.apache.org/r/24464/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 24464: Redirect docker logs
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/#review50134
-----------------------------------------------------------
src/docker/docker.hpp
<https://reviews.apache.org/r/24464/#comment87716>
Hum, this interface is weird to me. What if in the future we switch to use the REST api, what does the return value mean?
Ideally, docker.logs should return a 'stream' object, something like this:
class Docker {
class LogStream {
int out(); // return the out pipe.
int err(); // return the err pipe.
void close(); // terminate the subprocess.
...
};
Future<LogStream> logs(const string& containerName);
};
docker.logs(containerName).then(lambda::bind(&_logs, lambda::_1);
void _logs(const Docker::LogStream& stream)
{
io::redirect(stream.out(), "stdout");
io::redirect(stream.err(), "stderr");
}
src/docker/docker.cpp
<https://reviews.apache.org/r/24464/#comment87717>
Looks like these changes are not necessary given your recent changes?
src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/24464/#comment87718>
Can you expand here: what extra log will be there if you run the above command:
/bin/sh -c 'echo out!; echo err! 1>&2'
- Jie Yu
On Aug. 10, 2014, 6:51 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24464/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2014, 6:51 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/24464
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48
> src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
> src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c
> src/tests/docker_containerizer_tests.cpp a559836dd11a9a97e5939364c4b35a8dbb6a503d
>
> Diff: https://reviews.apache.org/r/24464/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 24464: Redirect docker logs
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/#review50333
-----------------------------------------------------------
Ship it!
Looks good! Thanks for the cleanup!
src/docker/docker.hpp
<https://reviews.apache.org/r/24464/#comment88008>
s/the/The/
src/docker/docker.hpp
<https://reviews.apache.org/r/24464/#comment88007>
This fits in one line?
src/docker/docker.cpp
<https://reviews.apache.org/r/24464/#comment88009>
Hum, why revert this change. No need to save the temp var 'msg'.
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/24464/#comment88010>
s/containerName/container/
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/24464/#comment88021>
I would probably do the following (reads better):
if (!containerLogs.contains(containerId)) {
LOG(WARNING) << "...";
___destroy(containerId, killed, status);
return;
}
Docker::Logs logs = containerLogs[containerId];
logs.close();
logs.wait().onAny(defer(
self(),
&____destroy,
containerId,
killed,
status,
lambda::_1));
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/24464/#comment88031>
One small issue here is that: if the 'docker logs' fails, we won't be able to notice that (through mesos logging) until the container is about to be destroyed. Worth adding a comment here.
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/24464/#comment88029>
s/logStatus/waited/
- Jie Yu
On Aug. 12, 2014, 7:44 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24464/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2014, 7:44 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/24464
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48
> src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
> src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c
> src/tests/docker_containerizer_tests.cpp a559836dd11a9a97e5939364c4b35a8dbb6a503d
>
> Diff: https://reviews.apache.org/r/24464/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 24464: Redirect docker logs
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/#review50426
-----------------------------------------------------------
Just realized. What's the recover story?
1) what if the slave exits, does the log process terminate?
2) if the log process does not terminate, how do we recover it (so that we can destroy it later)?
- Jie Yu
On Aug. 12, 2014, 10:28 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24464/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2014, 10:28 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/24464
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48
> src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
> src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c
> src/tests/docker_containerizer_tests.cpp a559836dd11a9a97e5939364c4b35a8dbb6a503d
>
> Diff: https://reviews.apache.org/r/24464/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 24464: Redirect docker logs
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/#review50491
-----------------------------------------------------------
Patch looks great!
Reviews applied: [24656, 24464]
All tests passed.
- Mesos ReviewBot
On Aug. 13, 2014, 5:33 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24464/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 5:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/24464
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 904cdd3
> src/tests/docker_containerizer_tests.cpp a559836
>
> Diff: https://reviews.apache.org/r/24464/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 24464: Redirect docker logs
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/
-----------------------------------------------------------
(Updated Aug. 13, 2014, 5:33 p.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Repository: mesos-git
Description
-------
Review: https://reviews.apache.org/r/24464
Diffs (updated)
-----
src/slave/containerizer/docker.cpp 904cdd3
src/tests/docker_containerizer_tests.cpp a559836
Diff: https://reviews.apache.org/r/24464/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 24464: Redirect docker logs
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/#review50423
-----------------------------------------------------------
Patch looks great!
Reviews applied: [24464]
All tests passed.
- Mesos ReviewBot
On Aug. 12, 2014, 10:28 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24464/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2014, 10:28 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/24464
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48
> src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
> src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c
> src/tests/docker_containerizer_tests.cpp a559836dd11a9a97e5939364c4b35a8dbb6a503d
>
> Diff: https://reviews.apache.org/r/24464/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 24464: Redirect docker logs
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/
-----------------------------------------------------------
(Updated Aug. 12, 2014, 10:28 p.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Repository: mesos-git
Description
-------
Review: https://reviews.apache.org/r/24464
Diffs (updated)
-----
src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48
src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c
src/tests/docker_containerizer_tests.cpp a559836dd11a9a97e5939364c4b35a8dbb6a503d
Diff: https://reviews.apache.org/r/24464/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 24464: Redirect docker logs
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/
-----------------------------------------------------------
(Updated Aug. 12, 2014, 7:44 a.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Repository: mesos-git
Description
-------
Review: https://reviews.apache.org/r/24464
Diffs (updated)
-----
src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48
src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c
src/tests/docker_containerizer_tests.cpp a559836dd11a9a97e5939364c4b35a8dbb6a503d
Diff: https://reviews.apache.org/r/24464/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 24464: Redirect docker logs
Posted by Timothy Chen <tn...@apache.org>.
> On Aug. 11, 2014, 10:46 p.m., Jie Yu wrote:
> > src/slave/containerizer/docker.cpp, line 446
> > <https://reviews.apache.org/r/24464/diff/10/?file=657551#file657551line446>
> >
> > You probably want to do a 'logs.wait()' here:
> >
> > logs.wait()
> > .onAny(defer(self(), &Self::__logging, ...);
> >
> > Inside __logging, you can add some logging.
I don't want to block on wait here since I want to launch the command executor right away afterwards.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/#review50206
-----------------------------------------------------------
On Aug. 11, 2014, 8:19 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24464/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 8:19 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/24464
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48
> src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
> src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c
> src/tests/docker_containerizer_tests.cpp a559836dd11a9a97e5939364c4b35a8dbb6a503d
>
> Diff: https://reviews.apache.org/r/24464/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 24464: Redirect docker logs
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/#review50206
-----------------------------------------------------------
Synced with BenH on this patch. Here is our comments. Let us know if you have any question! Thanks Tim!
src/docker/docker.hpp
<https://reviews.apache.org/r/24464/#comment87883>
s/LogStream/Logs/
so you'll have logs.out() and logs.err() which reads pretty good.
src/docker/docker.hpp
<https://reviews.apache.org/r/24464/#comment87878>
Instead of saving pid, out, err, status, could we just store the subprocess itself? That's much more clear to me.
Also, I'm not convinced that we should save containerName in Logs class because you'll just need that for logging, right? These loggings are supposed to be done by the containerizer.
src/docker/docker.hpp
<https://reviews.apache.org/r/24464/#comment87905>
Instead of overloading close() with some 'wait' semantics, what about having another function 'wait()':
// Stop the log stream. (Please remove the const as a
// close does not sound like a const function).
void close()
{
if (s.status().isPending()) {
:kill(...);
}
}
// Block until the underlying log process is terminated.
// Returns a failure if any error occurs.
Future<Nothing> wait()
{
return s.status()
.then(lambda::bind(&_wait, lambda::_1));
}
src/docker/docker.hpp
<https://reviews.apache.org/r/24464/#comment87885>
s/containerName/container/
Here and everywhere else so that it's consistent with other functions (e.g. '_kill' below).
src/docker/docker.cpp
<https://reviews.apache.org/r/24464/#comment87914>
These can be killed. See my comments above.
src/docker/docker.cpp
<https://reviews.apache.org/r/24464/#comment87911>
See my comments above. You can kill those VLOGs.
src/docker/docker.cpp
<https://reviews.apache.org/r/24464/#comment87912>
Ditto.
src/docker/docker.cpp
<https://reviews.apache.org/r/24464/#comment87918>
return Logs(s);
You probably want to make the constructor of Docker::Logs private and add Docker class to the friend list of Docker::Logs.
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/24464/#comment87924>
s/logStreams/logs/
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/24464/#comment87925>
We may want to rename this function to avoid name collision with member field 'logs'.
s/logs/logging/
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/24464/#comment87926>
s/containerName/name
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/24464/#comment87929>
Please take a look at src/slave/containerizer/mesos/containerizer.cpp where redirection is handled.
You need to close 'out' and 'err' at least. You may also wanna do cloexec on out and err.
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/24464/#comment87820>
Kill extra line here.
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/24464/#comment87927>
logs.put(containerId, _logs);
You may want to move this up before opening 'stdout/stderr'. This is because the opening may fail, if that's the case, you still want to cleanup the log process, right?
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/24464/#comment87931>
You probably want to do a 'logs.wait()' here:
logs.wait()
.onAny(defer(self(), &Self::__logging, ...);
Inside __logging, you can add some logging.
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/24464/#comment87887>
CHECK(!status.isPending());
src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/24464/#comment87889>
EXPECT_FALSE(strings::contains(..., "out!")); as well to make sure stdout output is not in stderr.
- Jie Yu
On Aug. 11, 2014, 8:19 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24464/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 8:19 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/24464
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48
> src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
> src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c
> src/tests/docker_containerizer_tests.cpp a559836dd11a9a97e5939364c4b35a8dbb6a503d
>
> Diff: https://reviews.apache.org/r/24464/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 24464: Redirect docker logs
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/
-----------------------------------------------------------
(Updated Aug. 11, 2014, 8:19 a.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Repository: mesos-git
Description
-------
Review: https://reviews.apache.org/r/24464
Diffs (updated)
-----
src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48
src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c
src/tests/docker_containerizer_tests.cpp a559836dd11a9a97e5939364c4b35a8dbb6a503d
Diff: https://reviews.apache.org/r/24464/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 24464: Redirect docker logs
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/
-----------------------------------------------------------
(Updated Aug. 10, 2014, 6:51 a.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Repository: mesos-git
Description
-------
Review: https://reviews.apache.org/r/24464
Diffs (updated)
-----
src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48
src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c
src/tests/docker_containerizer_tests.cpp a559836dd11a9a97e5939364c4b35a8dbb6a503d
Diff: https://reviews.apache.org/r/24464/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 24464: Redirect docker logs
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/
-----------------------------------------------------------
(Updated Aug. 10, 2014, 6:08 a.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Repository: mesos-git
Description
-------
Review: https://reviews.apache.org/r/24464
Diffs (updated)
-----
src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48
src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c
src/tests/docker_containerizer_tests.cpp a559836dd11a9a97e5939364c4b35a8dbb6a503d
Diff: https://reviews.apache.org/r/24464/diff/
Testing
-------
make check
Thanks,
Timothy Chen