You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/05/03 13:17:21 UTC
[GitHub] [yunikorn-k8shim] pbacsko commented on a diff in pull request #415: [POC][YUNIKORN-1194] Task objects are not created when applications are restored in recoverApps()
pbacsko commented on code in PR #415:
URL: https://github.com/apache/yunikorn-k8shim/pull/415#discussion_r863761838
##########
pkg/appmgmt/appmgmt.go:
##########
@@ -37,24 +37,28 @@ type AppManagementService struct {
apiProvider client.APIProvider
amProtocol interfaces.ApplicationManagementProtocol
managers []interfaces.AppManager
+ generalMgr *general.Manager
}
func NewAMService(amProtocol interfaces.ApplicationManagementProtocol,
apiProvider client.APIProvider) *AppManagementService {
+ generalMgr := general.NewManager(amProtocol, apiProvider)
appManager := &AppManagementService{
amProtocol: amProtocol,
apiProvider: apiProvider,
managers: make([]interfaces.AppManager, 0),
+ generalMgr: generalMgr,
Review Comment:
Needed for `GetTaskMetaData()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org