You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by br...@apache.org on 2018/11/12 17:06:52 UTC

[cordova-android] branch master updated: Remove obsolete check for JellyBean (GH-534) (#544)

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-android.git


The following commit(s) were added to refs/heads/master by this push:
     new e31596f  Remove obsolete check for JellyBean (GH-534) (#544)
e31596f is described below

commit e31596f60eeb3d9a7d47844b3e0e45304530d30f
Author: Chris Brody <ch...@gmail.com>
AuthorDate: Mon Nov 12 12:06:45 2018 -0500

    Remove obsolete check for JellyBean (GH-534) (#544)
    
    to work properly on Android Pie
    
    was introduced in dc0bfeb0c (CB-11828)
    
    Resolves #534
    
    Co-authored-by: <pr...@users.noreply.github.com>
    Co-authored-by: Christopher J. Brody <ch...@gmail.com>
---
 cordova-js-src/exec.js | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/cordova-js-src/exec.js b/cordova-js-src/exec.js
index f73d87a..39e8c97 100644
--- a/cordova-js-src/exec.js
+++ b/cordova-js-src/exec.js
@@ -109,17 +109,6 @@ function androidExec(success, fail, service, action, args) {
 }
 
 androidExec.init = function() {
-    //CB-11828
-    //This failsafe checks the version of Android and if it's Jellybean, it switches it to
-    //using the Online Event bridge for communicating from Native to JS
-    //
-    //It's ugly, but it's necessary.
-    var check = navigator.userAgent.toLowerCase().match(/android\s[0-9].[0-9]/);
-    var version_code = check && check[0].match(/4.[0-3].*/);
-    if (version_code != null && nativeToJsBridgeMode == nativeToJsModes.EVAL_BRIDGE) {
-      nativeToJsBridgeMode = nativeToJsModes.ONLINE_EVENT;
-    }
-
     bridgeSecret = +prompt('', 'gap_init:' + nativeToJsBridgeMode);
     channel.onNativeReady.fire();
 };


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org