[GitHub] [hadoop-submarine] yuanzac commented on a change in pull request #52: SUBMARINE-247. Add test cases for Python Interpreter

[GitBox <gi...@apache.org>]

yuanzac commented on a change in pull request #52: SUBMARINE-247. Add test cases for Python Interpreter
URL: https://github.com/apache/hadoop-submarine/pull/52#discussion_r335924672
 
 

 ##########
 File path: submarine-workbench/interpreter/python-interpreter/src/test/java/org/apache/submarine/interpreter/PythonInterpreterTest.java
 ##########
 @@ -24,35 +24,98 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import static org.junit.Assert.assertEquals;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
 
-import java.io.IOException;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
 
 public class PythonInterpreterTest {
   private static final Logger LOG = LoggerFactory.getLogger(PythonInterpreterTest.class);
 
-  private static PythonInterpreter pythonInterpreter = null;
+  private static PythonInterpreter testPythonInterpreter1 = null;
+
+  private static PythonInterpreter testPythonInterpreter2 = null;
 
   @BeforeClass
   public static void setUp() {
-    pythonInterpreter = new PythonInterpreter();
-    pythonInterpreter.open();
+    testPythonInterpreter1 = new PythonInterpreter();
 
 Review comment:
   Why do we need two PythonInterpreter？
   Can we add a PythonInterpreter to infinityPythonJobforCancel and infinityPythonJobforClose as a member variable.
   And then set PythonInterpreter to then when initializing infinityPythonJobforCancel and infinityPythonJobforClose.
   Is that ok?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services