You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myriad.apache.org by "Klaus Ma (JIRA)" <ji...@apache.org> on 2016/06/18 15:32:05 UTC
[jira] [Comment Edited] (MYRIAD-228) Duplicated NM opts
[ https://issues.apache.org/jira/browse/MYRIAD-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337978#comment-15337978 ]
Klaus Ma edited comment on MYRIAD-228 at 6/18/16 3:31 PM:
----------------------------------------------------------
It seems we should clear environments when generate command, draft code diff:
{code}
index db945ec..424ecf6 100644
--- a/myriad-scheduler/src/main/java/org/apache/myriad/scheduler/NMExecutorCLGenImpl.java
+++ b/myriad-scheduler/src/main/java/org/apache/myriad/scheduler/NMExecutorCLGenImpl.java
@@ -68,14 +68,17 @@ public class NMExecutorCLGenImpl implements ExecutorCommandLineGenerator {
protected void generateEnvironment(ServiceResourceProfile profile, NMPorts ports) {
+ // clear old environment.
+ environment.clear();
+
//yarnEnvironemnt configuration from yaml file
Map<String, String> yarnEnvironmentMap = cfg.getYarnEnvironment();
if (yarnEnvironmentMap != null) {
{code}
[~adam-mesos], any comments on that?
was (Author: klaus1982):
It seems we should clear environments when generate command, draft code diff:
{code}
index db945ec..424ecf6 100644
--- a/myriad-scheduler/src/main/java/org/apache/myriad/scheduler/NMExecutorCLGenImpl.java
+++ b/myriad-scheduler/src/main/java/org/apache/myriad/scheduler/NMExecutorCLGenImpl.java
@@ -68,14 +68,17 @@ public class NMExecutorCLGenImpl implements ExecutorCommandLineGenerator {
protected void generateEnvironment(ServiceResourceProfile profile, NMPorts ports) {
+ // clear old environment.
+ environment.clear();
+
//yarnEnvironemnt configuration from yaml file
Map<String, String> yarnEnvironmentMap = cfg.getYarnEnvironment();
if (yarnEnvironmentMap != null) {
{code}
> Duplicated NM opts
> ------------------
>
> Key: MYRIAD-228
> URL: https://issues.apache.org/jira/browse/MYRIAD-228
> Project: Myriad
> Issue Type: Bug
> Reporter: Klaus Ma
>
> In {{NMExecutorCLGenImpl.java:addYarnNodemanagerOpt}}, it keep appending NM Opts. It'll make arguments too long.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)