[GitHub] [dolphinscheduler] WangJPLeo commented on a diff in pull request #9718: [Fix-9717] The failure policy of the task flow takes effect

[GitBox <gi...@apache.org>]

WangJPLeo commented on code in PR #9718:
URL: https://github.com/apache/dolphinscheduler/pull/9718#discussion_r857116832


##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/utils/DagHelper.java:
##########
@@ -565,20 +554,40 @@ public static boolean haveConditionsAfterNode(String parentNodeCode, List<TaskNo
         return false;
     }
 
+
     /**
      * is there have blocking node after the parent node
      */
     public static boolean haveBlockingAfterNode(String parentNodeCode,
                                                 DAG<String,TaskNode,TaskNodeRelation> dag) {
+        return haveSubAfterNode(parentNodeCode, dag, true, TaskConstants.TASK_TYPE_BLOCKING);
+    }
+
+    /**
+     * is there have all node after the parent node
+     */
+    public static boolean haveAllNodeAfterNode(String parentNodeCode,

Review Comment:
   A node with child nodes in the process. The conditions for submitting child nodes when the current node fails are: there are child nodes and the failure strategy is continue. @ruanwenjun 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org