You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/08/16 16:26:31 UTC

[GitHub] [beam] ihji commented on a change in pull request #15307: [BEAM-12735] Adding Python XLang examples to the RC validation script

ihji commented on a change in pull request #15307:
URL: https://github.com/apache/beam/pull/15307#discussion_r689682848



##########
File path: release/src/main/scripts/run_rc_validation.sh
##########
@@ -168,8 +184,7 @@ bq version
 echo "-----------------Checking gnome-terminal-----------------"
 if [[ -z `which gnome-terminal` ]]; then
   echo "You don't have gnome-terminal installed."
-  if [[ "$INSTALL_GNOME_TERMINAL" != true ]]; then
-    sudo apt-get upgrade
+  if [[ "$INSTALL_GNOME_TERMINAL" = true ]]; then

Review comment:
       I believe so. The software needs to be installed when the variable is true.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org