[GitHub] [geode] DonalEvans commented on a diff in pull request #7688: GEODE-10326: Convert MessageType to enum.

[GitBox <gi...@apache.org>]

DonalEvans commented on code in PR #7688:
URL: https://github.com/apache/geode/pull/7688#discussion_r880890220


##########
geode-cq/src/main/java/org/apache/geode/cache/query/cq/internal/CqServiceImpl.java:
##########
@@ -93,10 +101,10 @@
 public class CqServiceImpl implements CqService {
   private static final Logger logger = LogService.getLogger();
 
-  private static final Integer MESSAGE_TYPE_LOCAL_CREATE = MessageType.LOCAL_CREATE;
-  private static final Integer MESSAGE_TYPE_LOCAL_UPDATE = MessageType.LOCAL_UPDATE;
-  private static final Integer MESSAGE_TYPE_LOCAL_DESTROY = MessageType.LOCAL_DESTROY;
-  private static final Integer MESSAGE_TYPE_EXCEPTION = MessageType.EXCEPTION;
+  private static final MessageType MESSAGE_TYPE_LOCAL_CREATE = LOCAL_CREATE;
+  private static final MessageType MESSAGE_TYPE_LOCAL_UPDATE = LOCAL_UPDATE;
+  private static final MessageType MESSAGE_TYPE_LOCAL_DESTROY = LOCAL_DESTROY;
+  private static final MessageType MESSAGE_TYPE_EXCEPTION = EXCEPTION;

Review Comment:
   Are these constants necessary now? I think the `MessageType` values can just be used directly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org