You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "LsomeYeah (via GitHub)" <gi...@apache.org> on 2023/08/30 09:11:52 UTC

[GitHub] [incubator-paimon] LsomeYeah commented on a diff in pull request #1916: [flink] Rename DatabaseSyncMode to MultiTablesSinkMode

LsomeYeah commented on code in PR #1916:
URL: https://github.com/apache/incubator-paimon/pull/1916#discussion_r1309953314


##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/DatabaseSinkMode.java:
##########
@@ -16,26 +16,26 @@
  * limitations under the License.
  */
 
-package org.apache.paimon.flink.action.cdc;
+package org.apache.paimon.flink.action;
 
 import javax.annotation.Nullable;
 
 import java.io.Serializable;
 
 /**
- * There are two modes for database sync.
+ * There are two modes for database sink.
  *
- * <p>1) DIVIDED mode, start a sink for each table, the synchronization of the new table requires
- * restarting the job.
+ * <p>1) DIVIDED mode, start a sink for each table, detecting the new table requires restarting the
+ * job.
  *
  * <p>2) COMBINED mode, start a single combined sink for all tables, the new table will be
- * automatically synchronized.
+ * automatically detected.
  */
-public enum DatabaseSyncMode implements Serializable {
+public enum DatabaseSinkMode implements Serializable {

Review Comment:
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org