You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by aaltay <gi...@git.apache.org> on 2016/07/13 17:27:03 UTC

[GitHub] incubator-beam pull request #645: Temporarily reverting pickler changes

GitHub user aaltay opened a pull request:

    https://github.com/apache/incubator-beam/pull/645

    Temporarily reverting pickler changes

    Changes from @4e2d8ab is casing infinite recursion when some tests are directly invoked outside the testing framework.
    
    Added one such test to tox tests for testing failure case (directly by
    main function).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aaltay/incubator-beam pickle

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/645.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #645
    
----
commit 997764750a5d5ef1a501643fff8529f913c74ef8
Author: Ahmet Altay <al...@google.com>
Date:   2016-07-13T17:18:03Z

    Temporarily reverting pickler changes (@4e2d8ab). It is causing infinite
    recursion when some tests are directly invoked outside the testing
    framework.
    
    Added one such test to tox tests for testing failing case (directly by
    main function).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #645: Temporarily reverting pickler changes

Posted by aaltay <gi...@git.apache.org>.
Github user aaltay closed the pull request at:

    https://github.com/apache/incubator-beam/pull/645


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---