You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/22 16:53:23 UTC

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #12162: feat: add new dashboard with video game sales

betodealmeida commented on a change in pull request #12162:
URL: https://github.com/apache/incubator-superset/pull/12162#discussion_r547387451



##########
File path: superset/dashboards/commands/importers/v1/utils.py
##########
@@ -81,6 +81,15 @@ def update_id_refs(config: Dict[str, Any], chart_ids: Dict[str, int]) -> Dict[st
             for old_id, value in metadata["expanded_slices"].items()
         }
 
+    if "default_filters" in metadata:

Review comment:
       Good point!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org