github pull requests, ICLAs and voluntary contributions (was: Apache Flex in Github)

[Bertrand Delacretaz <bd...@apache.org>]

On Fri, Aug 17, 2012 at 2:29 PM, Justin Mclean <ju...@classsoftware.com> wrote:
> ...I could look up your github username, see that your've made a pull request, generate
> the patch myself and then apply to SVN but that's a fair of work and more importantly
> other people don't get to see and review the patch in JIRA....

Note also two things related to that:

1) In the http://www.apache.org/licenses/icla.txt that you signed,
"You represent that each of Your Contributions is Your original
creation" - of course this doesn't apply when committing a patch
created by someone else, but in that case you have to be able to point
to that someone and to where they made their contribution.

As you say, that's much easier if the patch in question is in jira
(attached, or linked to a github pull request, doesn't really matter
IMO) - but the important part is that you must be able to point
reliably to the source of the contribution, and the simplest way is to
include a jira ID in the commit message ("contributed for Foo
Barzinsky as part of FLEX-1234"). I assume Apache Flex wants to track
what's being done via jira issues anyway, at least for non-trivial
commits.

2) The ASF only accepts voluntary contributions, so you cannot go
hunting yourself for Flex patches on github on somewhere else, it's
the contribution's author who has to actively indicate (on this list
or in jira for example) what they mean to contribute.

http://wiki.apache.org/couchdb/CommitPolicy has additional info about
this (and http://wiki.apache.org/couchdb/ContributorWorkflow but
that's for an Apache project that's already using Git as their main
ASF repository).

-Bertrand

Re: github pull requests, ICLAs and voluntary contributions (was: Apache Flex in Github)

[Greg Reddin <gr...@gmail.com>]

On Fri, Aug 17, 2012 at 7:43 AM, Bertrand Delacretaz
<bd...@apache.org> wrote:
> Note also two things related to that:

Thanks, Bertrand. I knew something didn't quite feel right about
committers going to github to look up patches, but I couldn't quite
figure out what was bothering me.

Greg

Re: github pull requests, ICLAs and voluntary contributions (was: Apache Flex in Github)

[Carlos Rovira <ca...@codeoscopic.com>]

2012/8/17 Bertrand Delacretaz <bd...@apache.org>

> http://wiki.apache.org/couchdb/CommitPolicy has additional info about
> this (and http://wiki.apache.org/couchdb/ContributorWorkflow but
> that's for an Apache project that's already using Git as their main
> ASF repository).
>
> -Bertrand
>

Hi Bertrand,

great links! Those could be used as the model for our wiki. Based on a
brief reading I think the unique difference is that they does not have
"develop" and instead they use mainly master.
But overall seems CouchDB is using GIT (and GitHub) at Apache without
problem

Great!


-- 
Carlos Rovira
Director de Tecnología
M: +34 607 22 60 05
F:  +34 912 35 57 77
<http://www.codeoscopic.com>
CODEOSCOPIC S.A. <http://www.codeoscopic.com>
Avd. del General Perón, 32
Planta 10, Puertas P-Q
28020 Madrid

Re: github pull requests, ICLAs and voluntary contributions (was: Apache Flex in Github)

[Alex Harui <ah...@adobe.com>]

Can I get a ruling on two scenarios?  The first is in [1].

There are links to patch files on GitHub like this [2].  Is this a
"permanent" link?  Does it matter if it isn't?

Similarly, another contribution came in via the mailing list with a dropbox
URL like this: [3].

Is this insufficient because a file on dropbox can be removed so we would
lose a way to verify the contribution I checked in matches the contribution
offered?

I'm assuming the github urls are permanent and going to attempt to apply
those patches.


[1] https://issues.apache.org/jira/browse/FLEX-33177
[2] https://github.com/apache/flex/pull/8.patch
[3] https://dl.dropbox.com/u/8496144/test_itemRenderers.patch


-- 
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui