You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/10/11 14:53:00 UTC

[06/11] hbase-site git commit: Published site at 72552301ab772122dc4dd39941ad1acbe831f1ff.

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/6b0020b1/devapidocs/src-html/org/apache/hadoop/hbase/wal/WALFactory.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/wal/WALFactory.html b/devapidocs/src-html/org/apache/hadoop/hbase/wal/WALFactory.html
index 92967f2..d69bb8c 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/wal/WALFactory.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/wal/WALFactory.html
@@ -88,404 +88,428 @@
 <span class="sourceLineNo">080</span><a name="line.80"></a>
 <span class="sourceLineNo">081</span>  public static final String WAL_PROVIDER = "hbase.wal.provider";<a name="line.81"></a>
 <span class="sourceLineNo">082</span>  static final String DEFAULT_WAL_PROVIDER = Providers.defaultProvider.name();<a name="line.82"></a>
-<span class="sourceLineNo">083</span><a name="line.83"></a>
-<span class="sourceLineNo">084</span>  public static final String META_WAL_PROVIDER = "hbase.wal.meta_provider";<a name="line.84"></a>
+<span class="sourceLineNo">083</span>  public static final String WAL_PROVIDER_CLASS = "hbase.wal.provider.class";<a name="line.83"></a>
+<span class="sourceLineNo">084</span>  static final Class&lt;? extends WALProvider&gt; DEFAULT_WAL_PROVIDER_CLASS = AsyncFSWALProvider.class;<a name="line.84"></a>
 <span class="sourceLineNo">085</span><a name="line.85"></a>
-<span class="sourceLineNo">086</span>  final String factoryId;<a name="line.86"></a>
-<span class="sourceLineNo">087</span>  private final WALProvider provider;<a name="line.87"></a>
-<span class="sourceLineNo">088</span>  // The meta updates are written to a different wal. If this<a name="line.88"></a>
-<span class="sourceLineNo">089</span>  // regionserver holds meta regions, then this ref will be non-null.<a name="line.89"></a>
-<span class="sourceLineNo">090</span>  // lazily intialized; most RegionServers don't deal with META<a name="line.90"></a>
-<span class="sourceLineNo">091</span>  private final AtomicReference&lt;WALProvider&gt; metaProvider = new AtomicReference&lt;&gt;();<a name="line.91"></a>
-<span class="sourceLineNo">092</span><a name="line.92"></a>
-<span class="sourceLineNo">093</span>  /**<a name="line.93"></a>
-<span class="sourceLineNo">094</span>   * Configuration-specified WAL Reader used when a custom reader is requested<a name="line.94"></a>
-<span class="sourceLineNo">095</span>   */<a name="line.95"></a>
-<span class="sourceLineNo">096</span>  private final Class&lt;? extends AbstractFSWALProvider.Reader&gt; logReaderClass;<a name="line.96"></a>
-<span class="sourceLineNo">097</span><a name="line.97"></a>
-<span class="sourceLineNo">098</span>  /**<a name="line.98"></a>
-<span class="sourceLineNo">099</span>   * How long to attempt opening in-recovery wals<a name="line.99"></a>
-<span class="sourceLineNo">100</span>   */<a name="line.100"></a>
-<span class="sourceLineNo">101</span>  private final int timeoutMillis;<a name="line.101"></a>
-<span class="sourceLineNo">102</span><a name="line.102"></a>
-<span class="sourceLineNo">103</span>  private final Configuration conf;<a name="line.103"></a>
-<span class="sourceLineNo">104</span><a name="line.104"></a>
-<span class="sourceLineNo">105</span>  // Used for the singleton WALFactory, see below.<a name="line.105"></a>
-<span class="sourceLineNo">106</span>  private WALFactory(Configuration conf) {<a name="line.106"></a>
-<span class="sourceLineNo">107</span>    // this code is duplicated here so we can keep our members final.<a name="line.107"></a>
-<span class="sourceLineNo">108</span>    // until we've moved reader/writer construction down into providers, this initialization must<a name="line.108"></a>
-<span class="sourceLineNo">109</span>    // happen prior to provider initialization, in case they need to instantiate a reader/writer.<a name="line.109"></a>
-<span class="sourceLineNo">110</span>    timeoutMillis = conf.getInt("hbase.hlog.open.timeout", 300000);<a name="line.110"></a>
-<span class="sourceLineNo">111</span>    /* TODO Both of these are probably specific to the fs wal provider */<a name="line.111"></a>
-<span class="sourceLineNo">112</span>    logReaderClass = conf.getClass("hbase.regionserver.hlog.reader.impl", ProtobufLogReader.class,<a name="line.112"></a>
-<span class="sourceLineNo">113</span>      AbstractFSWALProvider.Reader.class);<a name="line.113"></a>
-<span class="sourceLineNo">114</span>    this.conf = conf;<a name="line.114"></a>
-<span class="sourceLineNo">115</span>    // end required early initialization<a name="line.115"></a>
-<span class="sourceLineNo">116</span><a name="line.116"></a>
-<span class="sourceLineNo">117</span>    // this instance can't create wals, just reader/writers.<a name="line.117"></a>
-<span class="sourceLineNo">118</span>    provider = null;<a name="line.118"></a>
-<span class="sourceLineNo">119</span>    factoryId = SINGLETON_ID;<a name="line.119"></a>
-<span class="sourceLineNo">120</span>  }<a name="line.120"></a>
-<span class="sourceLineNo">121</span><a name="line.121"></a>
-<span class="sourceLineNo">122</span>  @VisibleForTesting<a name="line.122"></a>
-<span class="sourceLineNo">123</span>  Providers getDefaultProvider() {<a name="line.123"></a>
-<span class="sourceLineNo">124</span>    return Providers.defaultProvider;<a name="line.124"></a>
-<span class="sourceLineNo">125</span>  }<a name="line.125"></a>
-<span class="sourceLineNo">126</span><a name="line.126"></a>
-<span class="sourceLineNo">127</span>  @VisibleForTesting<a name="line.127"></a>
-<span class="sourceLineNo">128</span>  public Class&lt;? extends WALProvider&gt; getProviderClass(String key, String defaultValue) {<a name="line.128"></a>
-<span class="sourceLineNo">129</span>    try {<a name="line.129"></a>
-<span class="sourceLineNo">130</span>      Providers provider = Providers.valueOf(conf.get(key, defaultValue));<a name="line.130"></a>
-<span class="sourceLineNo">131</span><a name="line.131"></a>
-<span class="sourceLineNo">132</span>      // AsyncFSWALProvider is not guaranteed to work on all Hadoop versions, when it's chosen as<a name="line.132"></a>
-<span class="sourceLineNo">133</span>      // the default and we can't use it, we want to fall back to FSHLog which we know works on<a name="line.133"></a>
-<span class="sourceLineNo">134</span>      // all versions.<a name="line.134"></a>
-<span class="sourceLineNo">135</span>      if (provider == getDefaultProvider() &amp;&amp; provider.clazz == AsyncFSWALProvider.class<a name="line.135"></a>
-<span class="sourceLineNo">136</span>          &amp;&amp; !AsyncFSWALProvider.load()) {<a name="line.136"></a>
-<span class="sourceLineNo">137</span>        // AsyncFSWAL has better performance in most cases, and also uses less resources, we will<a name="line.137"></a>
-<span class="sourceLineNo">138</span>        // try to use it if possible. It deeply hacks into the internal of DFSClient so will be<a name="line.138"></a>
-<span class="sourceLineNo">139</span>        // easily broken when upgrading hadoop.<a name="line.139"></a>
-<span class="sourceLineNo">140</span>        LOG.warn("Failed to load AsyncFSWALProvider, falling back to FSHLogProvider");<a name="line.140"></a>
-<span class="sourceLineNo">141</span>        return FSHLogProvider.class;<a name="line.141"></a>
-<span class="sourceLineNo">142</span>      }<a name="line.142"></a>
-<span class="sourceLineNo">143</span><a name="line.143"></a>
-<span class="sourceLineNo">144</span>      // N.b. If the user specifically requested AsyncFSWALProvider but their environment doesn't<a name="line.144"></a>
-<span class="sourceLineNo">145</span>      // support using it (e.g. AsyncFSWALProvider.load() == false), we should let this fail and<a name="line.145"></a>
-<span class="sourceLineNo">146</span>      // not fall back to FSHLogProvider.<a name="line.146"></a>
-<span class="sourceLineNo">147</span>      return provider.clazz;<a name="line.147"></a>
-<span class="sourceLineNo">148</span>    } catch (IllegalArgumentException exception) {<a name="line.148"></a>
-<span class="sourceLineNo">149</span>      // Fall back to them specifying a class name<a name="line.149"></a>
-<span class="sourceLineNo">150</span>      // Note that the passed default class shouldn't actually be used, since the above only fails<a name="line.150"></a>
-<span class="sourceLineNo">151</span>      // when there is a config value present.<a name="line.151"></a>
-<span class="sourceLineNo">152</span>      return conf.getClass(key, Providers.defaultProvider.clazz, WALProvider.class);<a name="line.152"></a>
-<span class="sourceLineNo">153</span>    }<a name="line.153"></a>
-<span class="sourceLineNo">154</span>  }<a name="line.154"></a>
-<span class="sourceLineNo">155</span><a name="line.155"></a>
-<span class="sourceLineNo">156</span>  static WALProvider createProvider(Class&lt;? extends WALProvider&gt; clazz) throws IOException {<a name="line.156"></a>
-<span class="sourceLineNo">157</span>    LOG.info("Instantiating WALProvider of type {}", clazz);<a name="line.157"></a>
-<span class="sourceLineNo">158</span>    try {<a name="line.158"></a>
-<span class="sourceLineNo">159</span>      return clazz.getDeclaredConstructor().newInstance();<a name="line.159"></a>
-<span class="sourceLineNo">160</span>    } catch (Exception e) {<a name="line.160"></a>
-<span class="sourceLineNo">161</span>      LOG.error("couldn't set up WALProvider, the configured class is " + clazz);<a name="line.161"></a>
-<span class="sourceLineNo">162</span>      LOG.debug("Exception details for failure to load WALProvider.", e);<a name="line.162"></a>
-<span class="sourceLineNo">163</span>      throw new IOException("couldn't set up WALProvider", e);<a name="line.163"></a>
-<span class="sourceLineNo">164</span>    }<a name="line.164"></a>
-<span class="sourceLineNo">165</span>  }<a name="line.165"></a>
-<span class="sourceLineNo">166</span><a name="line.166"></a>
-<span class="sourceLineNo">167</span>  /**<a name="line.167"></a>
-<span class="sourceLineNo">168</span>   * @param conf must not be null, will keep a reference to read params in later reader/writer<a name="line.168"></a>
-<span class="sourceLineNo">169</span>   *          instances.<a name="line.169"></a>
-<span class="sourceLineNo">170</span>   * @param factoryId a unique identifier for this factory. used i.e. by filesystem implementations<a name="line.170"></a>
-<span class="sourceLineNo">171</span>   *          to make a directory<a name="line.171"></a>
-<span class="sourceLineNo">172</span>   */<a name="line.172"></a>
-<span class="sourceLineNo">173</span>  public WALFactory(Configuration conf, String factoryId) throws IOException {<a name="line.173"></a>
-<span class="sourceLineNo">174</span>    // default enableSyncReplicationWALProvider is true, only disable SyncReplicationWALProvider<a name="line.174"></a>
-<span class="sourceLineNo">175</span>    // for HMaster or HRegionServer which take system table only. See HBASE-19999<a name="line.175"></a>
-<span class="sourceLineNo">176</span>    this(conf, factoryId, true);<a name="line.176"></a>
-<span class="sourceLineNo">177</span>  }<a name="line.177"></a>
-<span class="sourceLineNo">178</span><a name="line.178"></a>
-<span class="sourceLineNo">179</span>  /**<a name="line.179"></a>
-<span class="sourceLineNo">180</span>   * @param conf must not be null, will keep a reference to read params in later reader/writer<a name="line.180"></a>
-<span class="sourceLineNo">181</span>   *          instances.<a name="line.181"></a>
-<span class="sourceLineNo">182</span>   * @param factoryId a unique identifier for this factory. used i.e. by filesystem implementations<a name="line.182"></a>
-<span class="sourceLineNo">183</span>   *          to make a directory<a name="line.183"></a>
-<span class="sourceLineNo">184</span>   * @param enableSyncReplicationWALProvider whether wrap the wal provider to a<a name="line.184"></a>
-<span class="sourceLineNo">185</span>   *          {@link SyncReplicationWALProvider}<a name="line.185"></a>
-<span class="sourceLineNo">186</span>   */<a name="line.186"></a>
-<span class="sourceLineNo">187</span>  public WALFactory(Configuration conf, String factoryId, boolean enableSyncReplicationWALProvider)<a name="line.187"></a>
-<span class="sourceLineNo">188</span>      throws IOException {<a name="line.188"></a>
-<span class="sourceLineNo">189</span>    // until we've moved reader/writer construction down into providers, this initialization must<a name="line.189"></a>
-<span class="sourceLineNo">190</span>    // happen prior to provider initialization, in case they need to instantiate a reader/writer.<a name="line.190"></a>
-<span class="sourceLineNo">191</span>    timeoutMillis = conf.getInt("hbase.hlog.open.timeout", 300000);<a name="line.191"></a>
-<span class="sourceLineNo">192</span>    /* TODO Both of these are probably specific to the fs wal provider */<a name="line.192"></a>
-<span class="sourceLineNo">193</span>    logReaderClass = conf.getClass("hbase.regionserver.hlog.reader.impl", ProtobufLogReader.class,<a name="line.193"></a>
-<span class="sourceLineNo">194</span>      AbstractFSWALProvider.Reader.class);<a name="line.194"></a>
-<span class="sourceLineNo">195</span>    this.conf = conf;<a name="line.195"></a>
-<span class="sourceLineNo">196</span>    this.factoryId = factoryId;<a name="line.196"></a>
-<span class="sourceLineNo">197</span>    // end required early initialization<a name="line.197"></a>
-<span class="sourceLineNo">198</span>    if (conf.getBoolean("hbase.regionserver.hlog.enabled", true)) {<a name="line.198"></a>
-<span class="sourceLineNo">199</span>      WALProvider provider = createProvider(getProviderClass(WAL_PROVIDER, DEFAULT_WAL_PROVIDER));<a name="line.199"></a>
-<span class="sourceLineNo">200</span>      if (enableSyncReplicationWALProvider) {<a name="line.200"></a>
-<span class="sourceLineNo">201</span>        provider = new SyncReplicationWALProvider(provider);<a name="line.201"></a>
-<span class="sourceLineNo">202</span>      }<a name="line.202"></a>
-<span class="sourceLineNo">203</span>      provider.init(this, conf, null);<a name="line.203"></a>
-<span class="sourceLineNo">204</span>      provider.addWALActionsListener(new MetricsWAL());<a name="line.204"></a>
-<span class="sourceLineNo">205</span>      this.provider = provider;<a name="line.205"></a>
-<span class="sourceLineNo">206</span>    } else {<a name="line.206"></a>
-<span class="sourceLineNo">207</span>      // special handling of existing configuration behavior.<a name="line.207"></a>
-<span class="sourceLineNo">208</span>      LOG.warn("Running with WAL disabled.");<a name="line.208"></a>
-<span class="sourceLineNo">209</span>      provider = new DisabledWALProvider();<a name="line.209"></a>
-<span class="sourceLineNo">210</span>      provider.init(this, conf, factoryId);<a name="line.210"></a>
-<span class="sourceLineNo">211</span>    }<a name="line.211"></a>
-<span class="sourceLineNo">212</span>  }<a name="line.212"></a>
-<span class="sourceLineNo">213</span><a name="line.213"></a>
-<span class="sourceLineNo">214</span>  /**<a name="line.214"></a>
-<span class="sourceLineNo">215</span>   * Shutdown all WALs and clean up any underlying storage.<a name="line.215"></a>
-<span class="sourceLineNo">216</span>   * Use only when you will not need to replay and edits that have gone to any wals from this<a name="line.216"></a>
-<span class="sourceLineNo">217</span>   * factory.<a name="line.217"></a>
-<span class="sourceLineNo">218</span>   */<a name="line.218"></a>
-<span class="sourceLineNo">219</span>  public void close() throws IOException {<a name="line.219"></a>
-<span class="sourceLineNo">220</span>    final WALProvider metaProvider = this.metaProvider.get();<a name="line.220"></a>
-<span class="sourceLineNo">221</span>    if (null != metaProvider) {<a name="line.221"></a>
-<span class="sourceLineNo">222</span>      metaProvider.close();<a name="line.222"></a>
-<span class="sourceLineNo">223</span>    }<a name="line.223"></a>
-<span class="sourceLineNo">224</span>    // close is called on a WALFactory with null provider in the case of contention handling<a name="line.224"></a>
-<span class="sourceLineNo">225</span>    // within the getInstance method.<a name="line.225"></a>
-<span class="sourceLineNo">226</span>    if (null != provider) {<a name="line.226"></a>
-<span class="sourceLineNo">227</span>      provider.close();<a name="line.227"></a>
-<span class="sourceLineNo">228</span>    }<a name="line.228"></a>
-<span class="sourceLineNo">229</span>  }<a name="line.229"></a>
-<span class="sourceLineNo">230</span><a name="line.230"></a>
-<span class="sourceLineNo">231</span>  /**<a name="line.231"></a>
-<span class="sourceLineNo">232</span>   * Tell the underlying WAL providers to shut down, but do not clean up underlying storage.<a name="line.232"></a>
-<span class="sourceLineNo">233</span>   * If you are not ending cleanly and will need to replay edits from this factory's wals,<a name="line.233"></a>
-<span class="sourceLineNo">234</span>   * use this method if you can as it will try to leave things as tidy as possible.<a name="line.234"></a>
-<span class="sourceLineNo">235</span>   */<a name="line.235"></a>
-<span class="sourceLineNo">236</span>  public void shutdown() throws IOException {<a name="line.236"></a>
-<span class="sourceLineNo">237</span>    IOException exception = null;<a name="line.237"></a>
-<span class="sourceLineNo">238</span>    final WALProvider metaProvider = this.metaProvider.get();<a name="line.238"></a>
-<span class="sourceLineNo">239</span>    if (null != metaProvider) {<a name="line.239"></a>
-<span class="sourceLineNo">240</span>      try {<a name="line.240"></a>
-<span class="sourceLineNo">241</span>        metaProvider.shutdown();<a name="line.241"></a>
-<span class="sourceLineNo">242</span>      } catch(IOException ioe) {<a name="line.242"></a>
-<span class="sourceLineNo">243</span>        exception = ioe;<a name="line.243"></a>
-<span class="sourceLineNo">244</span>      }<a name="line.244"></a>
+<span class="sourceLineNo">086</span>  public static final String META_WAL_PROVIDER = "hbase.wal.meta_provider";<a name="line.86"></a>
+<span class="sourceLineNo">087</span>  public static final String META_WAL_PROVIDER_CLASS = "hbase.wal.meta_provider.class";<a name="line.87"></a>
+<span class="sourceLineNo">088</span><a name="line.88"></a>
+<span class="sourceLineNo">089</span>  final String factoryId;<a name="line.89"></a>
+<span class="sourceLineNo">090</span>  private final WALProvider provider;<a name="line.90"></a>
+<span class="sourceLineNo">091</span>  // The meta updates are written to a different wal. If this<a name="line.91"></a>
+<span class="sourceLineNo">092</span>  // regionserver holds meta regions, then this ref will be non-null.<a name="line.92"></a>
+<span class="sourceLineNo">093</span>  // lazily intialized; most RegionServers don't deal with META<a name="line.93"></a>
+<span class="sourceLineNo">094</span>  private final AtomicReference&lt;WALProvider&gt; metaProvider = new AtomicReference&lt;&gt;();<a name="line.94"></a>
+<span class="sourceLineNo">095</span><a name="line.95"></a>
+<span class="sourceLineNo">096</span>  /**<a name="line.96"></a>
+<span class="sourceLineNo">097</span>   * Configuration-specified WAL Reader used when a custom reader is requested<a name="line.97"></a>
+<span class="sourceLineNo">098</span>   */<a name="line.98"></a>
+<span class="sourceLineNo">099</span>  private final Class&lt;? extends AbstractFSWALProvider.Reader&gt; logReaderClass;<a name="line.99"></a>
+<span class="sourceLineNo">100</span><a name="line.100"></a>
+<span class="sourceLineNo">101</span>  /**<a name="line.101"></a>
+<span class="sourceLineNo">102</span>   * How long to attempt opening in-recovery wals<a name="line.102"></a>
+<span class="sourceLineNo">103</span>   */<a name="line.103"></a>
+<span class="sourceLineNo">104</span>  private final int timeoutMillis;<a name="line.104"></a>
+<span class="sourceLineNo">105</span><a name="line.105"></a>
+<span class="sourceLineNo">106</span>  private final Configuration conf;<a name="line.106"></a>
+<span class="sourceLineNo">107</span><a name="line.107"></a>
+<span class="sourceLineNo">108</span>  // Used for the singleton WALFactory, see below.<a name="line.108"></a>
+<span class="sourceLineNo">109</span>  private WALFactory(Configuration conf) {<a name="line.109"></a>
+<span class="sourceLineNo">110</span>    // this code is duplicated here so we can keep our members final.<a name="line.110"></a>
+<span class="sourceLineNo">111</span>    // until we've moved reader/writer construction down into providers, this initialization must<a name="line.111"></a>
+<span class="sourceLineNo">112</span>    // happen prior to provider initialization, in case they need to instantiate a reader/writer.<a name="line.112"></a>
+<span class="sourceLineNo">113</span>    timeoutMillis = conf.getInt("hbase.hlog.open.timeout", 300000);<a name="line.113"></a>
+<span class="sourceLineNo">114</span>    /* TODO Both of these are probably specific to the fs wal provider */<a name="line.114"></a>
+<span class="sourceLineNo">115</span>    logReaderClass = conf.getClass("hbase.regionserver.hlog.reader.impl", ProtobufLogReader.class,<a name="line.115"></a>
+<span class="sourceLineNo">116</span>      AbstractFSWALProvider.Reader.class);<a name="line.116"></a>
+<span class="sourceLineNo">117</span>    this.conf = conf;<a name="line.117"></a>
+<span class="sourceLineNo">118</span>    // end required early initialization<a name="line.118"></a>
+<span class="sourceLineNo">119</span><a name="line.119"></a>
+<span class="sourceLineNo">120</span>    // this instance can't create wals, just reader/writers.<a name="line.120"></a>
+<span class="sourceLineNo">121</span>    provider = null;<a name="line.121"></a>
+<span class="sourceLineNo">122</span>    factoryId = SINGLETON_ID;<a name="line.122"></a>
+<span class="sourceLineNo">123</span>  }<a name="line.123"></a>
+<span class="sourceLineNo">124</span><a name="line.124"></a>
+<span class="sourceLineNo">125</span>  @VisibleForTesting<a name="line.125"></a>
+<span class="sourceLineNo">126</span>  Providers getDefaultProvider() {<a name="line.126"></a>
+<span class="sourceLineNo">127</span>    return Providers.defaultProvider;<a name="line.127"></a>
+<span class="sourceLineNo">128</span>  }<a name="line.128"></a>
+<span class="sourceLineNo">129</span><a name="line.129"></a>
+<span class="sourceLineNo">130</span>  @VisibleForTesting<a name="line.130"></a>
+<span class="sourceLineNo">131</span>  /*<a name="line.131"></a>
+<span class="sourceLineNo">132</span>   * @param clsKey config key for provider classname<a name="line.132"></a>
+<span class="sourceLineNo">133</span>   * @param key config key for provider enum<a name="line.133"></a>
+<span class="sourceLineNo">134</span>   * @param defaultValue default value for provider enum<a name="line.134"></a>
+<span class="sourceLineNo">135</span>   * @return Class which extends WALProvider<a name="line.135"></a>
+<span class="sourceLineNo">136</span>   */<a name="line.136"></a>
+<span class="sourceLineNo">137</span>  public Class&lt;? extends WALProvider&gt; getProviderClass(String clsKey, String key,<a name="line.137"></a>
+<span class="sourceLineNo">138</span>      String defaultValue) {<a name="line.138"></a>
+<span class="sourceLineNo">139</span>    String clsName = conf.get(clsKey);<a name="line.139"></a>
+<span class="sourceLineNo">140</span>    if (clsName == null || clsName.isEmpty()) {<a name="line.140"></a>
+<span class="sourceLineNo">141</span>      clsName = conf.get(key, defaultValue);<a name="line.141"></a>
+<span class="sourceLineNo">142</span>    }<a name="line.142"></a>
+<span class="sourceLineNo">143</span>    if (clsName != null &amp;&amp; !clsName.isEmpty()) {<a name="line.143"></a>
+<span class="sourceLineNo">144</span>      try {<a name="line.144"></a>
+<span class="sourceLineNo">145</span>        return (Class&lt;? extends WALProvider&gt;) Class.forName(clsName);<a name="line.145"></a>
+<span class="sourceLineNo">146</span>      } catch (ClassNotFoundException exception) {<a name="line.146"></a>
+<span class="sourceLineNo">147</span>        // try with enum key next<a name="line.147"></a>
+<span class="sourceLineNo">148</span>      }<a name="line.148"></a>
+<span class="sourceLineNo">149</span>    }<a name="line.149"></a>
+<span class="sourceLineNo">150</span>    try {<a name="line.150"></a>
+<span class="sourceLineNo">151</span>      Providers provider = Providers.valueOf(conf.get(key, defaultValue));<a name="line.151"></a>
+<span class="sourceLineNo">152</span><a name="line.152"></a>
+<span class="sourceLineNo">153</span>      // AsyncFSWALProvider is not guaranteed to work on all Hadoop versions, when it's chosen as<a name="line.153"></a>
+<span class="sourceLineNo">154</span>      // the default and we can't use it, we want to fall back to FSHLog which we know works on<a name="line.154"></a>
+<span class="sourceLineNo">155</span>      // all versions.<a name="line.155"></a>
+<span class="sourceLineNo">156</span>      if (provider == getDefaultProvider() &amp;&amp; provider.clazz == AsyncFSWALProvider.class<a name="line.156"></a>
+<span class="sourceLineNo">157</span>          &amp;&amp; !AsyncFSWALProvider.load()) {<a name="line.157"></a>
+<span class="sourceLineNo">158</span>        // AsyncFSWAL has better performance in most cases, and also uses less resources, we will<a name="line.158"></a>
+<span class="sourceLineNo">159</span>        // try to use it if possible. It deeply hacks into the internal of DFSClient so will be<a name="line.159"></a>
+<span class="sourceLineNo">160</span>        // easily broken when upgrading hadoop.<a name="line.160"></a>
+<span class="sourceLineNo">161</span>        LOG.warn("Failed to load AsyncFSWALProvider, falling back to FSHLogProvider");<a name="line.161"></a>
+<span class="sourceLineNo">162</span>        return FSHLogProvider.class;<a name="line.162"></a>
+<span class="sourceLineNo">163</span>      }<a name="line.163"></a>
+<span class="sourceLineNo">164</span><a name="line.164"></a>
+<span class="sourceLineNo">165</span>      // N.b. If the user specifically requested AsyncFSWALProvider but their environment doesn't<a name="line.165"></a>
+<span class="sourceLineNo">166</span>      // support using it (e.g. AsyncFSWALProvider.load() == false), we should let this fail and<a name="line.166"></a>
+<span class="sourceLineNo">167</span>      // not fall back to FSHLogProvider.<a name="line.167"></a>
+<span class="sourceLineNo">168</span>      return provider.clazz;<a name="line.168"></a>
+<span class="sourceLineNo">169</span>    } catch (IllegalArgumentException exception) {<a name="line.169"></a>
+<span class="sourceLineNo">170</span>      // Fall back to them specifying a class name<a name="line.170"></a>
+<span class="sourceLineNo">171</span>      // Note that the passed default class shouldn't actually be used, since the above only fails<a name="line.171"></a>
+<span class="sourceLineNo">172</span>      // when there is a config value present.<a name="line.172"></a>
+<span class="sourceLineNo">173</span>      return conf.getClass(key, AsyncFSWALProvider.class, WALProvider.class);<a name="line.173"></a>
+<span class="sourceLineNo">174</span>    }<a name="line.174"></a>
+<span class="sourceLineNo">175</span>  }<a name="line.175"></a>
+<span class="sourceLineNo">176</span><a name="line.176"></a>
+<span class="sourceLineNo">177</span>  static WALProvider createProvider(Class&lt;? extends WALProvider&gt; clazz) throws IOException {<a name="line.177"></a>
+<span class="sourceLineNo">178</span>    LOG.info("Instantiating WALProvider of type {}", clazz);<a name="line.178"></a>
+<span class="sourceLineNo">179</span>    try {<a name="line.179"></a>
+<span class="sourceLineNo">180</span>      return clazz.getDeclaredConstructor().newInstance();<a name="line.180"></a>
+<span class="sourceLineNo">181</span>    } catch (Exception e) {<a name="line.181"></a>
+<span class="sourceLineNo">182</span>      LOG.error("couldn't set up WALProvider, the configured class is " + clazz);<a name="line.182"></a>
+<span class="sourceLineNo">183</span>      LOG.debug("Exception details for failure to load WALProvider.", e);<a name="line.183"></a>
+<span class="sourceLineNo">184</span>      throw new IOException("couldn't set up WALProvider", e);<a name="line.184"></a>
+<span class="sourceLineNo">185</span>    }<a name="line.185"></a>
+<span class="sourceLineNo">186</span>  }<a name="line.186"></a>
+<span class="sourceLineNo">187</span><a name="line.187"></a>
+<span class="sourceLineNo">188</span>  /**<a name="line.188"></a>
+<span class="sourceLineNo">189</span>   * @param conf must not be null, will keep a reference to read params in later reader/writer<a name="line.189"></a>
+<span class="sourceLineNo">190</span>   *          instances.<a name="line.190"></a>
+<span class="sourceLineNo">191</span>   * @param factoryId a unique identifier for this factory. used i.e. by filesystem implementations<a name="line.191"></a>
+<span class="sourceLineNo">192</span>   *          to make a directory<a name="line.192"></a>
+<span class="sourceLineNo">193</span>   */<a name="line.193"></a>
+<span class="sourceLineNo">194</span>  public WALFactory(Configuration conf, String factoryId) throws IOException {<a name="line.194"></a>
+<span class="sourceLineNo">195</span>    // default enableSyncReplicationWALProvider is true, only disable SyncReplicationWALProvider<a name="line.195"></a>
+<span class="sourceLineNo">196</span>    // for HMaster or HRegionServer which take system table only. See HBASE-19999<a name="line.196"></a>
+<span class="sourceLineNo">197</span>    this(conf, factoryId, true);<a name="line.197"></a>
+<span class="sourceLineNo">198</span>  }<a name="line.198"></a>
+<span class="sourceLineNo">199</span><a name="line.199"></a>
+<span class="sourceLineNo">200</span>  /**<a name="line.200"></a>
+<span class="sourceLineNo">201</span>   * @param conf must not be null, will keep a reference to read params in later reader/writer<a name="line.201"></a>
+<span class="sourceLineNo">202</span>   *          instances.<a name="line.202"></a>
+<span class="sourceLineNo">203</span>   * @param factoryId a unique identifier for this factory. used i.e. by filesystem implementations<a name="line.203"></a>
+<span class="sourceLineNo">204</span>   *          to make a directory<a name="line.204"></a>
+<span class="sourceLineNo">205</span>   * @param enableSyncReplicationWALProvider whether wrap the wal provider to a<a name="line.205"></a>
+<span class="sourceLineNo">206</span>   *          {@link SyncReplicationWALProvider}<a name="line.206"></a>
+<span class="sourceLineNo">207</span>   */<a name="line.207"></a>
+<span class="sourceLineNo">208</span>  public WALFactory(Configuration conf, String factoryId, boolean enableSyncReplicationWALProvider)<a name="line.208"></a>
+<span class="sourceLineNo">209</span>      throws IOException {<a name="line.209"></a>
+<span class="sourceLineNo">210</span>    // until we've moved reader/writer construction down into providers, this initialization must<a name="line.210"></a>
+<span class="sourceLineNo">211</span>    // happen prior to provider initialization, in case they need to instantiate a reader/writer.<a name="line.211"></a>
+<span class="sourceLineNo">212</span>    timeoutMillis = conf.getInt("hbase.hlog.open.timeout", 300000);<a name="line.212"></a>
+<span class="sourceLineNo">213</span>    /* TODO Both of these are probably specific to the fs wal provider */<a name="line.213"></a>
+<span class="sourceLineNo">214</span>    logReaderClass = conf.getClass("hbase.regionserver.hlog.reader.impl", ProtobufLogReader.class,<a name="line.214"></a>
+<span class="sourceLineNo">215</span>      AbstractFSWALProvider.Reader.class);<a name="line.215"></a>
+<span class="sourceLineNo">216</span>    this.conf = conf;<a name="line.216"></a>
+<span class="sourceLineNo">217</span>    this.factoryId = factoryId;<a name="line.217"></a>
+<span class="sourceLineNo">218</span>    // end required early initialization<a name="line.218"></a>
+<span class="sourceLineNo">219</span>    if (conf.getBoolean("hbase.regionserver.hlog.enabled", true)) {<a name="line.219"></a>
+<span class="sourceLineNo">220</span>      WALProvider provider = createProvider(<a name="line.220"></a>
+<span class="sourceLineNo">221</span>          getProviderClass(WAL_PROVIDER_CLASS, WAL_PROVIDER, DEFAULT_WAL_PROVIDER));<a name="line.221"></a>
+<span class="sourceLineNo">222</span>      if (enableSyncReplicationWALProvider) {<a name="line.222"></a>
+<span class="sourceLineNo">223</span>        provider = new SyncReplicationWALProvider(provider);<a name="line.223"></a>
+<span class="sourceLineNo">224</span>      }<a name="line.224"></a>
+<span class="sourceLineNo">225</span>      provider.init(this, conf, null);<a name="line.225"></a>
+<span class="sourceLineNo">226</span>      provider.addWALActionsListener(new MetricsWAL());<a name="line.226"></a>
+<span class="sourceLineNo">227</span>      this.provider = provider;<a name="line.227"></a>
+<span class="sourceLineNo">228</span>    } else {<a name="line.228"></a>
+<span class="sourceLineNo">229</span>      // special handling of existing configuration behavior.<a name="line.229"></a>
+<span class="sourceLineNo">230</span>      LOG.warn("Running with WAL disabled.");<a name="line.230"></a>
+<span class="sourceLineNo">231</span>      provider = new DisabledWALProvider();<a name="line.231"></a>
+<span class="sourceLineNo">232</span>      provider.init(this, conf, factoryId);<a name="line.232"></a>
+<span class="sourceLineNo">233</span>    }<a name="line.233"></a>
+<span class="sourceLineNo">234</span>  }<a name="line.234"></a>
+<span class="sourceLineNo">235</span><a name="line.235"></a>
+<span class="sourceLineNo">236</span>  /**<a name="line.236"></a>
+<span class="sourceLineNo">237</span>   * Shutdown all WALs and clean up any underlying storage.<a name="line.237"></a>
+<span class="sourceLineNo">238</span>   * Use only when you will not need to replay and edits that have gone to any wals from this<a name="line.238"></a>
+<span class="sourceLineNo">239</span>   * factory.<a name="line.239"></a>
+<span class="sourceLineNo">240</span>   */<a name="line.240"></a>
+<span class="sourceLineNo">241</span>  public void close() throws IOException {<a name="line.241"></a>
+<span class="sourceLineNo">242</span>    final WALProvider metaProvider = this.metaProvider.get();<a name="line.242"></a>
+<span class="sourceLineNo">243</span>    if (null != metaProvider) {<a name="line.243"></a>
+<span class="sourceLineNo">244</span>      metaProvider.close();<a name="line.244"></a>
 <span class="sourceLineNo">245</span>    }<a name="line.245"></a>
-<span class="sourceLineNo">246</span>    provider.shutdown();<a name="line.246"></a>
-<span class="sourceLineNo">247</span>    if (null != exception) {<a name="line.247"></a>
-<span class="sourceLineNo">248</span>      throw exception;<a name="line.248"></a>
-<span class="sourceLineNo">249</span>    }<a name="line.249"></a>
-<span class="sourceLineNo">250</span>  }<a name="line.250"></a>
-<span class="sourceLineNo">251</span><a name="line.251"></a>
-<span class="sourceLineNo">252</span>  public List&lt;WAL&gt; getWALs() {<a name="line.252"></a>
-<span class="sourceLineNo">253</span>    return provider.getWALs();<a name="line.253"></a>
-<span class="sourceLineNo">254</span>  }<a name="line.254"></a>
-<span class="sourceLineNo">255</span><a name="line.255"></a>
-<span class="sourceLineNo">256</span>  @VisibleForTesting<a name="line.256"></a>
-<span class="sourceLineNo">257</span>  WALProvider getMetaProvider() throws IOException {<a name="line.257"></a>
-<span class="sourceLineNo">258</span>    for (;;) {<a name="line.258"></a>
-<span class="sourceLineNo">259</span>      WALProvider provider = this.metaProvider.get();<a name="line.259"></a>
-<span class="sourceLineNo">260</span>      if (provider != null) {<a name="line.260"></a>
-<span class="sourceLineNo">261</span>        return provider;<a name="line.261"></a>
-<span class="sourceLineNo">262</span>      }<a name="line.262"></a>
-<span class="sourceLineNo">263</span>      provider = createProvider(getProviderClass(META_WAL_PROVIDER,<a name="line.263"></a>
-<span class="sourceLineNo">264</span>          conf.get(WAL_PROVIDER, DEFAULT_WAL_PROVIDER)));<a name="line.264"></a>
-<span class="sourceLineNo">265</span>      provider.init(this, conf, AbstractFSWALProvider.META_WAL_PROVIDER_ID);<a name="line.265"></a>
-<span class="sourceLineNo">266</span>      provider.addWALActionsListener(new MetricsWAL());<a name="line.266"></a>
-<span class="sourceLineNo">267</span>      if (metaProvider.compareAndSet(null, provider)) {<a name="line.267"></a>
-<span class="sourceLineNo">268</span>        return provider;<a name="line.268"></a>
-<span class="sourceLineNo">269</span>      } else {<a name="line.269"></a>
-<span class="sourceLineNo">270</span>        // someone is ahead of us, close and try again.<a name="line.270"></a>
-<span class="sourceLineNo">271</span>        provider.close();<a name="line.271"></a>
-<span class="sourceLineNo">272</span>      }<a name="line.272"></a>
-<span class="sourceLineNo">273</span>    }<a name="line.273"></a>
-<span class="sourceLineNo">274</span>  }<a name="line.274"></a>
-<span class="sourceLineNo">275</span><a name="line.275"></a>
-<span class="sourceLineNo">276</span>  /**<a name="line.276"></a>
-<span class="sourceLineNo">277</span>   * @param region the region which we want to get a WAL for it. Could be null.<a name="line.277"></a>
-<span class="sourceLineNo">278</span>   */<a name="line.278"></a>
-<span class="sourceLineNo">279</span>  public WAL getWAL(RegionInfo region) throws IOException {<a name="line.279"></a>
-<span class="sourceLineNo">280</span>    // use different WAL for hbase:meta<a name="line.280"></a>
-<span class="sourceLineNo">281</span>    if (region != null &amp;&amp; region.isMetaRegion() &amp;&amp;<a name="line.281"></a>
-<span class="sourceLineNo">282</span>      region.getReplicaId() == RegionInfo.DEFAULT_REPLICA_ID) {<a name="line.282"></a>
-<span class="sourceLineNo">283</span>      return getMetaProvider().getWAL(region);<a name="line.283"></a>
-<span class="sourceLineNo">284</span>    } else {<a name="line.284"></a>
-<span class="sourceLineNo">285</span>      return provider.getWAL(region);<a name="line.285"></a>
-<span class="sourceLineNo">286</span>    }<a name="line.286"></a>
-<span class="sourceLineNo">287</span>  }<a name="line.287"></a>
-<span class="sourceLineNo">288</span><a name="line.288"></a>
-<span class="sourceLineNo">289</span>  public Reader createReader(final FileSystem fs, final Path path) throws IOException {<a name="line.289"></a>
-<span class="sourceLineNo">290</span>    return createReader(fs, path, (CancelableProgressable)null);<a name="line.290"></a>
-<span class="sourceLineNo">291</span>  }<a name="line.291"></a>
-<span class="sourceLineNo">292</span><a name="line.292"></a>
-<span class="sourceLineNo">293</span>  /**<a name="line.293"></a>
-<span class="sourceLineNo">294</span>   * Create a reader for the WAL. If you are reading from a file that's being written to and need<a name="line.294"></a>
-<span class="sourceLineNo">295</span>   * to reopen it multiple times, use {@link WAL.Reader#reset()} instead of this method<a name="line.295"></a>
-<span class="sourceLineNo">296</span>   * then just seek back to the last known good position.<a name="line.296"></a>
-<span class="sourceLineNo">297</span>   * @return A WAL reader.  Close when done with it.<a name="line.297"></a>
-<span class="sourceLineNo">298</span>   * @throws IOException<a name="line.298"></a>
-<span class="sourceLineNo">299</span>   */<a name="line.299"></a>
-<span class="sourceLineNo">300</span>  public Reader createReader(final FileSystem fs, final Path path,<a name="line.300"></a>
-<span class="sourceLineNo">301</span>      CancelableProgressable reporter) throws IOException {<a name="line.301"></a>
-<span class="sourceLineNo">302</span>    return createReader(fs, path, reporter, true);<a name="line.302"></a>
-<span class="sourceLineNo">303</span>  }<a name="line.303"></a>
-<span class="sourceLineNo">304</span><a name="line.304"></a>
-<span class="sourceLineNo">305</span>  public Reader createReader(final FileSystem fs, final Path path, CancelableProgressable reporter,<a name="line.305"></a>
-<span class="sourceLineNo">306</span>      boolean allowCustom) throws IOException {<a name="line.306"></a>
-<span class="sourceLineNo">307</span>    Class&lt;? extends AbstractFSWALProvider.Reader&gt; lrClass =<a name="line.307"></a>
-<span class="sourceLineNo">308</span>        allowCustom ? logReaderClass : ProtobufLogReader.class;<a name="line.308"></a>
-<span class="sourceLineNo">309</span>    try {<a name="line.309"></a>
-<span class="sourceLineNo">310</span>      // A wal file could be under recovery, so it may take several<a name="line.310"></a>
-<span class="sourceLineNo">311</span>      // tries to get it open. Instead of claiming it is corrupted, retry<a name="line.311"></a>
-<span class="sourceLineNo">312</span>      // to open it up to 5 minutes by default.<a name="line.312"></a>
-<span class="sourceLineNo">313</span>      long startWaiting = EnvironmentEdgeManager.currentTime();<a name="line.313"></a>
-<span class="sourceLineNo">314</span>      long openTimeout = timeoutMillis + startWaiting;<a name="line.314"></a>
-<span class="sourceLineNo">315</span>      int nbAttempt = 0;<a name="line.315"></a>
-<span class="sourceLineNo">316</span>      AbstractFSWALProvider.Reader reader = null;<a name="line.316"></a>
-<span class="sourceLineNo">317</span>      while (true) {<a name="line.317"></a>
-<span class="sourceLineNo">318</span>        try {<a name="line.318"></a>
-<span class="sourceLineNo">319</span>          reader = lrClass.getDeclaredConstructor().newInstance();<a name="line.319"></a>
-<span class="sourceLineNo">320</span>          reader.init(fs, path, conf, null);<a name="line.320"></a>
-<span class="sourceLineNo">321</span>          return reader;<a name="line.321"></a>
-<span class="sourceLineNo">322</span>        } catch (IOException e) {<a name="line.322"></a>
-<span class="sourceLineNo">323</span>          if (reader != null) {<a name="line.323"></a>
-<span class="sourceLineNo">324</span>            try {<a name="line.324"></a>
-<span class="sourceLineNo">325</span>              reader.close();<a name="line.325"></a>
-<span class="sourceLineNo">326</span>            } catch (IOException exception) {<a name="line.326"></a>
-<span class="sourceLineNo">327</span>              LOG.warn("Could not close FSDataInputStream" + exception.getMessage());<a name="line.327"></a>
-<span class="sourceLineNo">328</span>              LOG.debug("exception details", exception);<a name="line.328"></a>
-<span class="sourceLineNo">329</span>            }<a name="line.329"></a>
-<span class="sourceLineNo">330</span>          }<a name="line.330"></a>
-<span class="sourceLineNo">331</span><a name="line.331"></a>
-<span class="sourceLineNo">332</span>          String msg = e.getMessage();<a name="line.332"></a>
-<span class="sourceLineNo">333</span>          if (msg != null<a name="line.333"></a>
-<span class="sourceLineNo">334</span>              &amp;&amp; (msg.contains("Cannot obtain block length")<a name="line.334"></a>
-<span class="sourceLineNo">335</span>                  || msg.contains("Could not obtain the last block") || msg<a name="line.335"></a>
-<span class="sourceLineNo">336</span>                    .matches("Blocklist for [^ ]* has changed.*"))) {<a name="line.336"></a>
-<span class="sourceLineNo">337</span>            if (++nbAttempt == 1) {<a name="line.337"></a>
-<span class="sourceLineNo">338</span>              LOG.warn("Lease should have recovered. This is not expected. Will retry", e);<a name="line.338"></a>
-<span class="sourceLineNo">339</span>            }<a name="line.339"></a>
-<span class="sourceLineNo">340</span>            if (reporter != null &amp;&amp; !reporter.progress()) {<a name="line.340"></a>
-<span class="sourceLineNo">341</span>              throw new InterruptedIOException("Operation is cancelled");<a name="line.341"></a>
-<span class="sourceLineNo">342</span>            }<a name="line.342"></a>
-<span class="sourceLineNo">343</span>            if (nbAttempt &gt; 2 &amp;&amp; openTimeout &lt; EnvironmentEdgeManager.currentTime()) {<a name="line.343"></a>
-<span class="sourceLineNo">344</span>              LOG.error("Can't open after " + nbAttempt + " attempts and "<a name="line.344"></a>
-<span class="sourceLineNo">345</span>                  + (EnvironmentEdgeManager.currentTime() - startWaiting) + "ms " + " for " + path);<a name="line.345"></a>
-<span class="sourceLineNo">346</span>            } else {<a name="line.346"></a>
-<span class="sourceLineNo">347</span>              try {<a name="line.347"></a>
-<span class="sourceLineNo">348</span>                Thread.sleep(nbAttempt &lt; 3 ? 500 : 1000);<a name="line.348"></a>
-<span class="sourceLineNo">349</span>                continue; // retry<a name="line.349"></a>
-<span class="sourceLineNo">350</span>              } catch (InterruptedException ie) {<a name="line.350"></a>
-<span class="sourceLineNo">351</span>                InterruptedIOException iioe = new InterruptedIOException();<a name="line.351"></a>
-<span class="sourceLineNo">352</span>                iioe.initCause(ie);<a name="line.352"></a>
-<span class="sourceLineNo">353</span>                throw iioe;<a name="line.353"></a>
-<span class="sourceLineNo">354</span>              }<a name="line.354"></a>
-<span class="sourceLineNo">355</span>            }<a name="line.355"></a>
-<span class="sourceLineNo">356</span>            throw new LeaseNotRecoveredException(e);<a name="line.356"></a>
-<span class="sourceLineNo">357</span>          } else {<a name="line.357"></a>
-<span class="sourceLineNo">358</span>            throw e;<a name="line.358"></a>
-<span class="sourceLineNo">359</span>          }<a name="line.359"></a>
-<span class="sourceLineNo">360</span>        }<a name="line.360"></a>
-<span class="sourceLineNo">361</span>      }<a name="line.361"></a>
-<span class="sourceLineNo">362</span>    } catch (IOException ie) {<a name="line.362"></a>
-<span class="sourceLineNo">363</span>      throw ie;<a name="line.363"></a>
-<span class="sourceLineNo">364</span>    } catch (Exception e) {<a name="line.364"></a>
-<span class="sourceLineNo">365</span>      throw new IOException("Cannot get log reader", e);<a name="line.365"></a>
-<span class="sourceLineNo">366</span>    }<a name="line.366"></a>
-<span class="sourceLineNo">367</span>  }<a name="line.367"></a>
-<span class="sourceLineNo">368</span><a name="line.368"></a>
-<span class="sourceLineNo">369</span>  /**<a name="line.369"></a>
-<span class="sourceLineNo">370</span>   * Create a writer for the WAL.<a name="line.370"></a>
-<span class="sourceLineNo">371</span>   * Uses defaults.<a name="line.371"></a>
-<span class="sourceLineNo">372</span>   * &lt;p&gt;<a name="line.372"></a>
-<span class="sourceLineNo">373</span>   * Should be package-private. public only for tests and<a name="line.373"></a>
-<span class="sourceLineNo">374</span>   * {@link org.apache.hadoop.hbase.regionserver.wal.Compressor}<a name="line.374"></a>
-<span class="sourceLineNo">375</span>   * @return A WAL writer. Close when done with it.<a name="line.375"></a>
-<span class="sourceLineNo">376</span>   */<a name="line.376"></a>
-<span class="sourceLineNo">377</span>  public Writer createWALWriter(final FileSystem fs, final Path path) throws IOException {<a name="line.377"></a>
-<span class="sourceLineNo">378</span>    return FSHLogProvider.createWriter(conf, fs, path, false);<a name="line.378"></a>
-<span class="sourceLineNo">379</span>  }<a name="line.379"></a>
-<span class="sourceLineNo">380</span><a name="line.380"></a>
-<span class="sourceLineNo">381</span>  /**<a name="line.381"></a>
-<span class="sourceLineNo">382</span>   * Should be package-private, visible for recovery testing.<a name="line.382"></a>
-<span class="sourceLineNo">383</span>   * Uses defaults.<a name="line.383"></a>
-<span class="sourceLineNo">384</span>   * @return an overwritable writer for recovered edits. caller should close.<a name="line.384"></a>
-<span class="sourceLineNo">385</span>   */<a name="line.385"></a>
-<span class="sourceLineNo">386</span>  @VisibleForTesting<a name="line.386"></a>
-<span class="sourceLineNo">387</span>  public Writer createRecoveredEditsWriter(final FileSystem fs, final Path path)<a name="line.387"></a>
-<span class="sourceLineNo">388</span>      throws IOException {<a name="line.388"></a>
-<span class="sourceLineNo">389</span>    return FSHLogProvider.createWriter(conf, fs, path, true);<a name="line.389"></a>
-<span class="sourceLineNo">390</span>  }<a name="line.390"></a>
-<span class="sourceLineNo">391</span><a name="line.391"></a>
-<span class="sourceLineNo">392</span>  // These static methods are currently used where it's impractical to<a name="line.392"></a>
-<span class="sourceLineNo">393</span>  // untangle the reliance on state in the filesystem. They rely on singleton<a name="line.393"></a>
-<span class="sourceLineNo">394</span>  // WALFactory that just provides Reader / Writers.<a name="line.394"></a>
-<span class="sourceLineNo">395</span>  // For now, first Configuration object wins. Practically this just impacts the reader/writer class<a name="line.395"></a>
-<span class="sourceLineNo">396</span>  private static final AtomicReference&lt;WALFactory&gt; singleton = new AtomicReference&lt;&gt;();<a name="line.396"></a>
-<span class="sourceLineNo">397</span>  private static final String SINGLETON_ID = WALFactory.class.getName();<a name="line.397"></a>
-<span class="sourceLineNo">398</span>  <a name="line.398"></a>
-<span class="sourceLineNo">399</span>  // Public only for FSHLog<a name="line.399"></a>
-<span class="sourceLineNo">400</span>  public static WALFactory getInstance(Configuration configuration) {<a name="line.400"></a>
-<span class="sourceLineNo">401</span>    WALFactory factory = singleton.get();<a name="line.401"></a>
-<span class="sourceLineNo">402</span>    if (null == factory) {<a name="line.402"></a>
-<span class="sourceLineNo">403</span>      WALFactory temp = new WALFactory(configuration);<a name="line.403"></a>
-<span class="sourceLineNo">404</span>      if (singleton.compareAndSet(null, temp)) {<a name="line.404"></a>
-<span class="sourceLineNo">405</span>        factory = temp;<a name="line.405"></a>
-<span class="sourceLineNo">406</span>      } else {<a name="line.406"></a>
-<span class="sourceLineNo">407</span>        // someone else beat us to initializing<a name="line.407"></a>
-<span class="sourceLineNo">408</span>        try {<a name="line.408"></a>
-<span class="sourceLineNo">409</span>          temp.close();<a name="line.409"></a>
-<span class="sourceLineNo">410</span>        } catch (IOException exception) {<a name="line.410"></a>
-<span class="sourceLineNo">411</span>          LOG.debug("failed to close temporary singleton. ignoring.", exception);<a name="line.411"></a>
-<span class="sourceLineNo">412</span>        }<a name="line.412"></a>
-<span class="sourceLineNo">413</span>        factory = singleton.get();<a name="line.413"></a>
-<span class="sourceLineNo">414</span>      }<a name="line.414"></a>
-<span class="sourceLineNo">415</span>    }<a name="line.415"></a>
-<span class="sourceLineNo">416</span>    return factory;<a name="line.416"></a>
-<span class="sourceLineNo">417</span>  }<a name="line.417"></a>
-<span class="sourceLineNo">418</span><a name="line.418"></a>
-<span class="sourceLineNo">419</span>  /**<a name="line.419"></a>
-<span class="sourceLineNo">420</span>   * Create a reader for the given path, accept custom reader classes from conf.<a name="line.420"></a>
-<span class="sourceLineNo">421</span>   * If you already have a WALFactory, you should favor the instance method.<a name="line.421"></a>
-<span class="sourceLineNo">422</span>   * @return a WAL Reader, caller must close.<a name="line.422"></a>
-<span class="sourceLineNo">423</span>   */<a name="line.423"></a>
-<span class="sourceLineNo">424</span>  public static Reader createReader(final FileSystem fs, final Path path,<a name="line.424"></a>
-<span class="sourceLineNo">425</span>      final Configuration configuration) throws IOException {<a name="line.425"></a>
-<span class="sourceLineNo">426</span>    return getInstance(configuration).createReader(fs, path);<a name="line.426"></a>
-<span class="sourceLineNo">427</span>  }<a name="line.427"></a>
-<span class="sourceLineNo">428</span><a name="line.428"></a>
-<span class="sourceLineNo">429</span>  /**<a name="line.429"></a>
-<span class="sourceLineNo">430</span>   * Create a reader for the given path, accept custom reader classes from conf.<a name="line.430"></a>
-<span class="sourceLineNo">431</span>   * If you already have a WALFactory, you should favor the instance method.<a name="line.431"></a>
-<span class="sourceLineNo">432</span>   * @return a WAL Reader, caller must close.<a name="line.432"></a>
-<span class="sourceLineNo">433</span>   */<a name="line.433"></a>
-<span class="sourceLineNo">434</span>  static Reader createReader(final FileSystem fs, final Path path,<a name="line.434"></a>
-<span class="sourceLineNo">435</span>      final Configuration configuration, final CancelableProgressable reporter) throws IOException {<a name="line.435"></a>
-<span class="sourceLineNo">436</span>    return getInstance(configuration).createReader(fs, path, reporter);<a name="line.436"></a>
-<span class="sourceLineNo">437</span>  }<a name="line.437"></a>
-<span class="sourceLineNo">438</span><a name="line.438"></a>
-<span class="sourceLineNo">439</span>  /**<a name="line.439"></a>
-<span class="sourceLineNo">440</span>   * Create a reader for the given path, ignore custom reader classes from conf.<a name="line.440"></a>
-<span class="sourceLineNo">441</span>   * If you already have a WALFactory, you should favor the instance method.<a name="line.441"></a>
-<span class="sourceLineNo">442</span>   * only public pending move of {@link org.apache.hadoop.hbase.regionserver.wal.Compressor}<a name="line.442"></a>
-<span class="sourceLineNo">443</span>   * @return a WAL Reader, caller must close.<a name="line.443"></a>
-<span class="sourceLineNo">444</span>   */<a name="line.444"></a>
-<span class="sourceLineNo">445</span>  public static Reader createReaderIgnoreCustomClass(final FileSystem fs, final Path path,<a name="line.445"></a>
-<span class="sourceLineNo">446</span>      final Configuration configuration) throws IOException {<a name="line.446"></a>
-<span class="sourceLineNo">447</span>    return getInstance(configuration).createReader(fs, path, null, false);<a name="line.447"></a>
-<span class="sourceLineNo">448</span>  }<a name="line.448"></a>
-<span class="sourceLineNo">449</span><a name="line.449"></a>
-<span class="sourceLineNo">450</span>  /**<a name="line.450"></a>
-<span class="sourceLineNo">451</span>   * If you already have a WALFactory, you should favor the instance method.<a name="line.451"></a>
-<span class="sourceLineNo">452</span>   * Uses defaults.<a name="line.452"></a>
-<span class="sourceLineNo">453</span>   * @return a Writer that will overwrite files. Caller must close.<a name="line.453"></a>
-<span class="sourceLineNo">454</span>   */<a name="line.454"></a>
-<span class="sourceLineNo">455</span>  static Writer createRecoveredEditsWriter(final FileSystem fs, final Path path,<a name="line.455"></a>
-<span class="sourceLineNo">456</span>      final Configuration configuration)<a name="line.456"></a>
-<span class="sourceLineNo">457</span>      throws IOException {<a name="line.457"></a>
-<span class="sourceLineNo">458</span>    return FSHLogProvider.createWriter(configuration, fs, path, true);<a name="line.458"></a>
-<span class="sourceLineNo">459</span>  }<a name="line.459"></a>
-<span class="sourceLineNo">460</span><a name="line.460"></a>
-<span class="sourceLineNo">461</span>  /**<a name="line.461"></a>
-<span class="sourceLineNo">462</span>   * If you already have a WALFactory, you should favor the instance method.<a name="line.462"></a>
-<span class="sourceLineNo">463</span>   * Uses defaults.<a name="line.463"></a>
-<span class="sourceLineNo">464</span>   * @return a writer that won't overwrite files. Caller must close.<a name="line.464"></a>
-<span class="sourceLineNo">465</span>   */<a name="line.465"></a>
-<span class="sourceLineNo">466</span>  @VisibleForTesting<a name="line.466"></a>
-<span class="sourceLineNo">467</span>  public static Writer createWALWriter(final FileSystem fs, final Path path,<a name="line.467"></a>
-<span class="sourceLineNo">468</span>      final Configuration configuration)<a name="line.468"></a>
-<span class="sourceLineNo">469</span>      throws IOException {<a name="line.469"></a>
-<span class="sourceLineNo">470</span>    return FSHLogProvider.createWriter(configuration, fs, path, false);<a name="line.470"></a>
-<span class="sourceLineNo">471</span>  }<a name="line.471"></a>
-<span class="sourceLineNo">472</span><a name="line.472"></a>
-<span class="sourceLineNo">473</span>  public final WALProvider getWALProvider() {<a name="line.473"></a>
-<span class="sourceLineNo">474</span>    return this.provider;<a name="line.474"></a>
-<span class="sourceLineNo">475</span>  }<a name="line.475"></a>
-<span class="sourceLineNo">476</span><a name="line.476"></a>
-<span class="sourceLineNo">477</span>  public final WALProvider getMetaWALProvider() {<a name="line.477"></a>
-<span class="sourceLineNo">478</span>    return this.metaProvider.get();<a name="line.478"></a>
-<span class="sourceLineNo">479</span>  }<a name="line.479"></a>
-<span class="sourceLineNo">480</span>}<a name="line.480"></a>
+<span class="sourceLineNo">246</span>    // close is called on a WALFactory with null provider in the case of contention handling<a name="line.246"></a>
+<span class="sourceLineNo">247</span>    // within the getInstance method.<a name="line.247"></a>
+<span class="sourceLineNo">248</span>    if (null != provider) {<a name="line.248"></a>
+<span class="sourceLineNo">249</span>      provider.close();<a name="line.249"></a>
+<span class="sourceLineNo">250</span>    }<a name="line.250"></a>
+<span class="sourceLineNo">251</span>  }<a name="line.251"></a>
+<span class="sourceLineNo">252</span><a name="line.252"></a>
+<span class="sourceLineNo">253</span>  /**<a name="line.253"></a>
+<span class="sourceLineNo">254</span>   * Tell the underlying WAL providers to shut down, but do not clean up underlying storage.<a name="line.254"></a>
+<span class="sourceLineNo">255</span>   * If you are not ending cleanly and will need to replay edits from this factory's wals,<a name="line.255"></a>
+<span class="sourceLineNo">256</span>   * use this method if you can as it will try to leave things as tidy as possible.<a name="line.256"></a>
+<span class="sourceLineNo">257</span>   */<a name="line.257"></a>
+<span class="sourceLineNo">258</span>  public void shutdown() throws IOException {<a name="line.258"></a>
+<span class="sourceLineNo">259</span>    IOException exception = null;<a name="line.259"></a>
+<span class="sourceLineNo">260</span>    final WALProvider metaProvider = this.metaProvider.get();<a name="line.260"></a>
+<span class="sourceLineNo">261</span>    if (null != metaProvider) {<a name="line.261"></a>
+<span class="sourceLineNo">262</span>      try {<a name="line.262"></a>
+<span class="sourceLineNo">263</span>        metaProvider.shutdown();<a name="line.263"></a>
+<span class="sourceLineNo">264</span>      } catch(IOException ioe) {<a name="line.264"></a>
+<span class="sourceLineNo">265</span>        exception = ioe;<a name="line.265"></a>
+<span class="sourceLineNo">266</span>      }<a name="line.266"></a>
+<span class="sourceLineNo">267</span>    }<a name="line.267"></a>
+<span class="sourceLineNo">268</span>    provider.shutdown();<a name="line.268"></a>
+<span class="sourceLineNo">269</span>    if (null != exception) {<a name="line.269"></a>
+<span class="sourceLineNo">270</span>      throw exception;<a name="line.270"></a>
+<span class="sourceLineNo">271</span>    }<a name="line.271"></a>
+<span class="sourceLineNo">272</span>  }<a name="line.272"></a>
+<span class="sourceLineNo">273</span><a name="line.273"></a>
+<span class="sourceLineNo">274</span>  public List&lt;WAL&gt; getWALs() {<a name="line.274"></a>
+<span class="sourceLineNo">275</span>    return provider.getWALs();<a name="line.275"></a>
+<span class="sourceLineNo">276</span>  }<a name="line.276"></a>
+<span class="sourceLineNo">277</span><a name="line.277"></a>
+<span class="sourceLineNo">278</span>  @VisibleForTesting<a name="line.278"></a>
+<span class="sourceLineNo">279</span>  WALProvider getMetaProvider() throws IOException {<a name="line.279"></a>
+<span class="sourceLineNo">280</span>    for (;;) {<a name="line.280"></a>
+<span class="sourceLineNo">281</span>      WALProvider provider = this.metaProvider.get();<a name="line.281"></a>
+<span class="sourceLineNo">282</span>      if (provider != null) {<a name="line.282"></a>
+<span class="sourceLineNo">283</span>        return provider;<a name="line.283"></a>
+<span class="sourceLineNo">284</span>      }<a name="line.284"></a>
+<span class="sourceLineNo">285</span>      boolean metaWALProvPresent = conf.get(META_WAL_PROVIDER_CLASS) != null;<a name="line.285"></a>
+<span class="sourceLineNo">286</span>      provider = createProvider(getProviderClass(<a name="line.286"></a>
+<span class="sourceLineNo">287</span>          metaWALProvPresent ? META_WAL_PROVIDER_CLASS : WAL_PROVIDER_CLASS,<a name="line.287"></a>
+<span class="sourceLineNo">288</span>          META_WAL_PROVIDER, conf.get(WAL_PROVIDER, DEFAULT_WAL_PROVIDER)));<a name="line.288"></a>
+<span class="sourceLineNo">289</span>      provider.init(this, conf, AbstractFSWALProvider.META_WAL_PROVIDER_ID);<a name="line.289"></a>
+<span class="sourceLineNo">290</span>      provider.addWALActionsListener(new MetricsWAL());<a name="line.290"></a>
+<span class="sourceLineNo">291</span>      if (metaProvider.compareAndSet(null, provider)) {<a name="line.291"></a>
+<span class="sourceLineNo">292</span>        return provider;<a name="line.292"></a>
+<span class="sourceLineNo">293</span>      } else {<a name="line.293"></a>
+<span class="sourceLineNo">294</span>        // someone is ahead of us, close and try again.<a name="line.294"></a>
+<span class="sourceLineNo">295</span>        provider.close();<a name="line.295"></a>
+<span class="sourceLineNo">296</span>      }<a name="line.296"></a>
+<span class="sourceLineNo">297</span>    }<a name="line.297"></a>
+<span class="sourceLineNo">298</span>  }<a name="line.298"></a>
+<span class="sourceLineNo">299</span><a name="line.299"></a>
+<span class="sourceLineNo">300</span>  /**<a name="line.300"></a>
+<span class="sourceLineNo">301</span>   * @param region the region which we want to get a WAL for it. Could be null.<a name="line.301"></a>
+<span class="sourceLineNo">302</span>   */<a name="line.302"></a>
+<span class="sourceLineNo">303</span>  public WAL getWAL(RegionInfo region) throws IOException {<a name="line.303"></a>
+<span class="sourceLineNo">304</span>    // use different WAL for hbase:meta<a name="line.304"></a>
+<span class="sourceLineNo">305</span>    if (region != null &amp;&amp; region.isMetaRegion() &amp;&amp;<a name="line.305"></a>
+<span class="sourceLineNo">306</span>      region.getReplicaId() == RegionInfo.DEFAULT_REPLICA_ID) {<a name="line.306"></a>
+<span class="sourceLineNo">307</span>      return getMetaProvider().getWAL(region);<a name="line.307"></a>
+<span class="sourceLineNo">308</span>    } else {<a name="line.308"></a>
+<span class="sourceLineNo">309</span>      return provider.getWAL(region);<a name="line.309"></a>
+<span class="sourceLineNo">310</span>    }<a name="line.310"></a>
+<span class="sourceLineNo">311</span>  }<a name="line.311"></a>
+<span class="sourceLineNo">312</span><a name="line.312"></a>
+<span class="sourceLineNo">313</span>  public Reader createReader(final FileSystem fs, final Path path) throws IOException {<a name="line.313"></a>
+<span class="sourceLineNo">314</span>    return createReader(fs, path, (CancelableProgressable)null);<a name="line.314"></a>
+<span class="sourceLineNo">315</span>  }<a name="line.315"></a>
+<span class="sourceLineNo">316</span><a name="line.316"></a>
+<span class="sourceLineNo">317</span>  /**<a name="line.317"></a>
+<span class="sourceLineNo">318</span>   * Create a reader for the WAL. If you are reading from a file that's being written to and need<a name="line.318"></a>
+<span class="sourceLineNo">319</span>   * to reopen it multiple times, use {@link WAL.Reader#reset()} instead of this method<a name="line.319"></a>
+<span class="sourceLineNo">320</span>   * then just seek back to the last known good position.<a name="line.320"></a>
+<span class="sourceLineNo">321</span>   * @return A WAL reader.  Close when done with it.<a name="line.321"></a>
+<span class="sourceLineNo">322</span>   * @throws IOException<a name="line.322"></a>
+<span class="sourceLineNo">323</span>   */<a name="line.323"></a>
+<span class="sourceLineNo">324</span>  public Reader createReader(final FileSystem fs, final Path path,<a name="line.324"></a>
+<span class="sourceLineNo">325</span>      CancelableProgressable reporter) throws IOException {<a name="line.325"></a>
+<span class="sourceLineNo">326</span>    return createReader(fs, path, reporter, true);<a name="line.326"></a>
+<span class="sourceLineNo">327</span>  }<a name="line.327"></a>
+<span class="sourceLineNo">328</span><a name="line.328"></a>
+<span class="sourceLineNo">329</span>  public Reader createReader(final FileSystem fs, final Path path, CancelableProgressable reporter,<a name="line.329"></a>
+<span class="sourceLineNo">330</span>      boolean allowCustom) throws IOException {<a name="line.330"></a>
+<span class="sourceLineNo">331</span>    Class&lt;? extends AbstractFSWALProvider.Reader&gt; lrClass =<a name="line.331"></a>
+<span class="sourceLineNo">332</span>        allowCustom ? logReaderClass : ProtobufLogReader.class;<a name="line.332"></a>
+<span class="sourceLineNo">333</span>    try {<a name="line.333"></a>
+<span class="sourceLineNo">334</span>      // A wal file could be under recovery, so it may take several<a name="line.334"></a>
+<span class="sourceLineNo">335</span>      // tries to get it open. Instead of claiming it is corrupted, retry<a name="line.335"></a>
+<span class="sourceLineNo">336</span>      // to open it up to 5 minutes by default.<a name="line.336"></a>
+<span class="sourceLineNo">337</span>      long startWaiting = EnvironmentEdgeManager.currentTime();<a name="line.337"></a>
+<span class="sourceLineNo">338</span>      long openTimeout = timeoutMillis + startWaiting;<a name="line.338"></a>
+<span class="sourceLineNo">339</span>      int nbAttempt = 0;<a name="line.339"></a>
+<span class="sourceLineNo">340</span>      AbstractFSWALProvider.Reader reader = null;<a name="line.340"></a>
+<span class="sourceLineNo">341</span>      while (true) {<a name="line.341"></a>
+<span class="sourceLineNo">342</span>        try {<a name="line.342"></a>
+<span class="sourceLineNo">343</span>          reader = lrClass.getDeclaredConstructor().newInstance();<a name="line.343"></a>
+<span class="sourceLineNo">344</span>          reader.init(fs, path, conf, null);<a name="line.344"></a>
+<span class="sourceLineNo">345</span>          return reader;<a name="line.345"></a>
+<span class="sourceLineNo">346</span>        } catch (IOException e) {<a name="line.346"></a>
+<span class="sourceLineNo">347</span>          if (reader != null) {<a name="line.347"></a>
+<span class="sourceLineNo">348</span>            try {<a name="line.348"></a>
+<span class="sourceLineNo">349</span>              reader.close();<a name="line.349"></a>
+<span class="sourceLineNo">350</span>            } catch (IOException exception) {<a name="line.350"></a>
+<span class="sourceLineNo">351</span>              LOG.warn("Could not close FSDataInputStream" + exception.getMessage());<a name="line.351"></a>
+<span class="sourceLineNo">352</span>              LOG.debug("exception details", exception);<a name="line.352"></a>
+<span class="sourceLineNo">353</span>            }<a name="line.353"></a>
+<span class="sourceLineNo">354</span>          }<a name="line.354"></a>
+<span class="sourceLineNo">355</span><a name="line.355"></a>
+<span class="sourceLineNo">356</span>          String msg = e.getMessage();<a name="line.356"></a>
+<span class="sourceLineNo">357</span>          if (msg != null<a name="line.357"></a>
+<span class="sourceLineNo">358</span>              &amp;&amp; (msg.contains("Cannot obtain block length")<a name="line.358"></a>
+<span class="sourceLineNo">359</span>                  || msg.contains("Could not obtain the last block") || msg<a name="line.359"></a>
+<span class="sourceLineNo">360</span>                    .matches("Blocklist for [^ ]* has changed.*"))) {<a name="line.360"></a>
+<span class="sourceLineNo">361</span>            if (++nbAttempt == 1) {<a name="line.361"></a>
+<span class="sourceLineNo">362</span>              LOG.warn("Lease should have recovered. This is not expected. Will retry", e);<a name="line.362"></a>
+<span class="sourceLineNo">363</span>            }<a name="line.363"></a>
+<span class="sourceLineNo">364</span>            if (reporter != null &amp;&amp; !reporter.progress()) {<a name="line.364"></a>
+<span class="sourceLineNo">365</span>              throw new InterruptedIOException("Operation is cancelled");<a name="line.365"></a>
+<span class="sourceLineNo">366</span>            }<a name="line.366"></a>
+<span class="sourceLineNo">367</span>            if (nbAttempt &gt; 2 &amp;&amp; openTimeout &lt; EnvironmentEdgeManager.currentTime()) {<a name="line.367"></a>
+<span class="sourceLineNo">368</span>              LOG.error("Can't open after " + nbAttempt + " attempts and "<a name="line.368"></a>
+<span class="sourceLineNo">369</span>                  + (EnvironmentEdgeManager.currentTime() - startWaiting) + "ms " + " for " + path);<a name="line.369"></a>
+<span class="sourceLineNo">370</span>            } else {<a name="line.370"></a>
+<span class="sourceLineNo">371</span>              try {<a name="line.371"></a>
+<span class="sourceLineNo">372</span>                Thread.sleep(nbAttempt &lt; 3 ? 500 : 1000);<a name="line.372"></a>
+<span class="sourceLineNo">373</span>                continue; // retry<a name="line.373"></a>
+<span class="sourceLineNo">374</span>              } catch (InterruptedException ie) {<a name="line.374"></a>
+<span class="sourceLineNo">375</span>                InterruptedIOException iioe = new InterruptedIOException();<a name="line.375"></a>
+<span class="sourceLineNo">376</span>                iioe.initCause(ie);<a name="line.376"></a>
+<span class="sourceLineNo">377</span>                throw iioe;<a name="line.377"></a>
+<span class="sourceLineNo">378</span>              }<a name="line.378"></a>
+<span class="sourceLineNo">379</span>            }<a name="line.379"></a>
+<span class="sourceLineNo">380</span>            throw new LeaseNotRecoveredException(e);<a name="line.380"></a>
+<span class="sourceLineNo">381</span>          } else {<a name="line.381"></a>
+<span class="sourceLineNo">382</span>            throw e;<a name="line.382"></a>
+<span class="sourceLineNo">383</span>          }<a name="line.383"></a>
+<span class="sourceLineNo">384</span>        }<a name="line.384"></a>
+<span class="sourceLineNo">385</span>      }<a name="line.385"></a>
+<span class="sourceLineNo">386</span>    } catch (IOException ie) {<a name="line.386"></a>
+<span class="sourceLineNo">387</span>      throw ie;<a name="line.387"></a>
+<span class="sourceLineNo">388</span>    } catch (Exception e) {<a name="line.388"></a>
+<span class="sourceLineNo">389</span>      throw new IOException("Cannot get log reader", e);<a name="line.389"></a>
+<span class="sourceLineNo">390</span>    }<a name="line.390"></a>
+<span class="sourceLineNo">391</span>  }<a name="line.391"></a>
+<span class="sourceLineNo">392</span><a name="line.392"></a>
+<span class="sourceLineNo">393</span>  /**<a name="line.393"></a>
+<span class="sourceLineNo">394</span>   * Create a writer for the WAL.<a name="line.394"></a>
+<span class="sourceLineNo">395</span>   * Uses defaults.<a name="line.395"></a>
+<span class="sourceLineNo">396</span>   * &lt;p&gt;<a name="line.396"></a>
+<span class="sourceLineNo">397</span>   * Should be package-private. public only for tests and<a name="line.397"></a>
+<span class="sourceLineNo">398</span>   * {@link org.apache.hadoop.hbase.regionserver.wal.Compressor}<a name="line.398"></a>
+<span class="sourceLineNo">399</span>   * @return A WAL writer. Close when done with it.<a name="line.399"></a>
+<span class="sourceLineNo">400</span>   */<a name="line.400"></a>
+<span class="sourceLineNo">401</span>  public Writer createWALWriter(final FileSystem fs, final Path path) throws IOException {<a name="line.401"></a>
+<span class="sourceLineNo">402</span>    return FSHLogProvider.createWriter(conf, fs, path, false);<a name="line.402"></a>
+<span class="sourceLineNo">403</span>  }<a name="line.403"></a>
+<span class="sourceLineNo">404</span><a name="line.404"></a>
+<span class="sourceLineNo">405</span>  /**<a name="line.405"></a>
+<span class="sourceLineNo">406</span>   * Should be package-private, visible for recovery testing.<a name="line.406"></a>
+<span class="sourceLineNo">407</span>   * Uses defaults.<a name="line.407"></a>
+<span class="sourceLineNo">408</span>   * @return an overwritable writer for recovered edits. caller should close.<a name="line.408"></a>
+<span class="sourceLineNo">409</span>   */<a name="line.409"></a>
+<span class="sourceLineNo">410</span>  @VisibleForTesting<a name="line.410"></a>
+<span class="sourceLineNo">411</span>  public Writer createRecoveredEditsWriter(final FileSystem fs, final Path path)<a name="line.411"></a>
+<span class="sourceLineNo">412</span>      throws IOException {<a name="line.412"></a>
+<span class="sourceLineNo">413</span>    return FSHLogProvider.createWriter(conf, fs, path, true);<a name="line.413"></a>
+<span class="sourceLineNo">414</span>  }<a name="line.414"></a>
+<span class="sourceLineNo">415</span><a name="line.415"></a>
+<span class="sourceLineNo">416</span>  // These static methods are currently used where it's impractical to<a name="line.416"></a>
+<span class="sourceLineNo">417</span>  // untangle the reliance on state in the filesystem. They rely on singleton<a name="line.417"></a>
+<span class="sourceLineNo">418</span>  // WALFactory that just provides Reader / Writers.<a name="line.418"></a>
+<span class="sourceLineNo">419</span>  // For now, first Configuration object wins. Practically this just impacts the reader/writer class<a name="line.419"></a>
+<span class="sourceLineNo">420</span>  private static final AtomicReference&lt;WALFactory&gt; singleton = new AtomicReference&lt;&gt;();<a name="line.420"></a>
+<span class="sourceLineNo">421</span>  private static final String SINGLETON_ID = WALFactory.class.getName();<a name="line.421"></a>
+<span class="sourceLineNo">422</span>  <a name="line.422"></a>
+<span class="sourceLineNo">423</span>  // Public only for FSHLog<a name="line.423"></a>
+<span class="sourceLineNo">424</span>  public static WALFactory getInstance(Configuration configuration) {<a name="line.424"></a>
+<span class="sourceLineNo">425</span>    WALFactory factory = singleton.get();<a name="line.425"></a>
+<span class="sourceLineNo">426</span>    if (null == factory) {<a name="line.426"></a>
+<span class="sourceLineNo">427</span>      WALFactory temp = new WALFactory(configuration);<a name="line.427"></a>
+<span class="sourceLineNo">428</span>      if (singleton.compareAndSet(null, temp)) {<a name="line.428"></a>
+<span class="sourceLineNo">429</span>        factory = temp;<a name="line.429"></a>
+<span class="sourceLineNo">430</span>      } else {<a name="line.430"></a>
+<span class="sourceLineNo">431</span>        // someone else beat us to initializing<a name="line.431"></a>
+<span class="sourceLineNo">432</span>        try {<a name="line.432"></a>
+<span class="sourceLineNo">433</span>          temp.close();<a name="line.433"></a>
+<span class="sourceLineNo">434</span>        } catch (IOException exception) {<a name="line.434"></a>
+<span class="sourceLineNo">435</span>          LOG.debug("failed to close temporary singleton. ignoring.", exception);<a name="line.435"></a>
+<span class="sourceLineNo">436</span>        }<a name="line.436"></a>
+<span class="sourceLineNo">437</span>        factory = singleton.get();<a name="line.437"></a>
+<span class="sourceLineNo">438</span>      }<a name="line.438"></a>
+<span class="sourceLineNo">439</span>    }<a name="line.439"></a>
+<span class="sourceLineNo">440</span>    return factory;<a name="line.440"></a>
+<span class="sourceLineNo">441</span>  }<a name="line.441"></a>
+<span class="sourceLineNo">442</span><a name="line.442"></a>
+<span class="sourceLineNo">443</span>  /**<a name="line.443"></a>
+<span class="sourceLineNo">444</span>   * Create a reader for the given path, accept custom reader classes from conf.<a name="line.444"></a>
+<span class="sourceLineNo">445</span>   * If you already have a WALFactory, you should favor the instance method.<a name="line.445"></a>
+<span class="sourceLineNo">446</span>   * @return a WAL Reader, caller must close.<a name="line.446"></a>
+<span class="sourceLineNo">447</span>   */<a name="line.447"></a>
+<span class="sourceLineNo">448</span>  public static Reader createReader(final FileSystem fs, final Path path,<a name="line.448"></a>
+<span class="sourceLineNo">449</span>      final Configuration configuration) throws IOException {<a name="line.449"></a>
+<span class="sourceLineNo">450</span>    return getInstance(configuration).createReader(fs, path);<a name="line.450"></a>
+<span class="sourceLineNo">451</span>  }<a name="line.451"></a>
+<span class="sourceLineNo">452</span><a name="line.452"></a>
+<span class="sourceLineNo">453</span>  /**<a name="line.453"></a>
+<span class="sourceLineNo">454</span>   * Create a reader for the given path, accept custom reader classes from conf.<a name="line.454"></a>
+<span class="sourceLineNo">455</span>   * If you already have a WALFactory, you should favor the instance method.<a name="line.455"></a>
+<span class="sourceLineNo">456</span>   * @return a WAL Reader, caller must close.<a name="line.456"></a>
+<span class="sourceLineNo">457</span>   */<a name="line.457"></a>
+<span class="sourceLineNo">458</span>  static Reader createReader(final FileSystem fs, final Path path,<a name="line.458"></a>
+<span class="sourceLineNo">459</span>      final Configuration configuration, final CancelableProgressable reporter) throws IOException {<a name="line.459"></a>
+<span class="sourceLineNo">460</span>    return getInstance(configuration).createReader(fs, path, reporter);<a name="line.460"></a>
+<span class="sourceLineNo">461</span>  }<a name="line.461"></a>
+<span class="sourceLineNo">462</span><a name="line.462"></a>
+<span class="sourceLineNo">463</span>  /**<a name="line.463"></a>
+<span class="sourceLineNo">464</span>   * Create a reader for the given path, ignore custom reader classes from conf.<a name="line.464"></a>
+<span class="sourceLineNo">465</span>   * If you already have a WALFactory, you should favor the instance method.<a name="line.465"></a>
+<span class="sourceLineNo">466</span>   * only public pending move of {@link org.apache.hadoop.hbase.regionserver.wal.Compressor}<a name="line.466"></a>
+<span class="sourceLineNo">467</span>   * @return a WAL Reader, caller must close.<a name="line.467"></a>
+<span class="sourceLineNo">468</span>   */<a name="line.468"></a>
+<span class="sourceLineNo">469</span>  public static Reader createReaderIgnoreCustomClass(final FileSystem fs, final Path path,<a name="line.469"></a>
+<span class="sourceLineNo">470</span>      final Configuration configuration) throws IOException {<a name="line.470"></a>
+<span class="sourceLineNo">471</span>    return getInstance(configuration).createReader(fs, path, null, false);<a name="line.471"></a>
+<span class="sourceLineNo">472</span>  }<a name="line.472"></a>
+<span class="sourceLineNo">473</span><a name="line.473"></a>
+<span class="sourceLineNo">474</span>  /**<a name="line.474"></a>
+<span class="sourceLineNo">475</span>   * If you already have a WALFactory, you should favor the instance method.<a name="line.475"></a>
+<span class="sourceLineNo">476</span>   * Uses defaults.<a name="line.476"></a>
+<span class="sourceLineNo">477</span>   * @return a Writer that will overwrite files. Caller must close.<a name="line.477"></a>
+<span class="sourceLineNo">478</span>   */<a name="line.478"></a>
+<span class="sourceLineNo">479</span>  static Writer createRecoveredEditsWriter(final FileSystem fs, final Path path,<a name="line.479"></a>
+<span class="sourceLineNo">480</span>      final Configuration configuration)<a name="line.480"></a>
+<span class="sourceLineNo">481</span>      throws IOException {<a name="line.481"></a>
+<span class="sourceLineNo">482</span>    return FSHLogProvider.createWriter(configuration, fs, path, true);<a name="line.482"></a>
+<span class="sourceLineNo">483</span>  }<a name="line.483"></a>
+<span class="sourceLineNo">484</span><a name="line.484"></a>
+<span class="sourceLineNo">485</span>  /**<a name="line.485"></a>
+<span class="sourceLineNo">486</span>   * If you already have a WALFactory, you should favor the instance method.<a name="line.486"></a>
+<span class="sourceLineNo">487</span>   * Uses defaults.<a name="line.487"></a>
+<span class="sourceLineNo">488</span>   * @return a writer that won't overwrite files. Caller must close.<a name="line.488"></a>
+<span class="sourceLineNo">489</span>   */<a name="line.489"></a>
+<span class="sourceLineNo">490</span>  @VisibleForTesting<a name="line.490"></a>
+<span class="sourceLineNo">491</span>  public static Writer createWALWriter(final FileSystem fs, final Path path,<a name="line.491"></a>
+<span class="sourceLineNo">492</span>      final Configuration configuration)<a name="line.492"></a>
+<span class="sourceLineNo">493</span>      throws IOException {<a name="line.493"></a>
+<span class="sourceLineNo">494</span>    return FSHLogProvider.createWriter(configuration, fs, path, false);<a name="line.494"></a>
+<span class="sourceLineNo">495</span>  }<a name="line.495"></a>
+<span class="sourceLineNo">496</span><a name="line.496"></a>
+<span class="sourceLineNo">497</span>  public final WALProvider getWALProvider() {<a name="line.497"></a>
+<span class="sourceLineNo">498</span>    return this.provider;<a name="line.498"></a>
+<span class="sourceLineNo">499</span>  }<a name="line.499"></a>
+<span class="sourceLineNo">500</span><a name="line.500"></a>
+<span class="sourceLineNo">501</span>  public final WALProvider getMetaWALProvider() {<a name="line.501"></a>
+<span class="sourceLineNo">502</span>    return this.metaProvider.get();<a name="line.502"></a>
+<span class="sourceLineNo">503</span>  }<a name="line.503"></a>
+<span class="sourceLineNo">504</span>}<a name="line.504"></a>
 
 
 

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/6b0020b1/downloads.html
----------------------------------------------------------------------
diff --git a/downloads.html b/downloads.html
index 28cce67..6ba0cc1 100644
--- a/downloads.html
+++ b/downloads.html
@@ -7,7 +7,7 @@
   <head>
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
-    <meta name="Date-Revision-yyyymmdd" content="20181010" />
+    <meta name="Date-Revision-yyyymmdd" content="20181011" />
     <meta http-equiv="Content-Language" content="en" />
     <title>Apache HBase &#x2013; Apache HBase Downloads</title>
     <link rel="stylesheet" href="./css/apache-maven-fluido-1.4-HBase.min.css" />
@@ -423,7 +423,7 @@ under the License. -->
                         <a href="https://www.apache.org/">The Apache Software Foundation</a>.
             All rights reserved.      
                     
-                  <li id="publishDate" class="pull-right">Last Published: 2018-10-10</li>
+                  <li id="publishDate" class="pull-right">Last Published: 2018-10-11</li>
             </p>
                 </div>
 

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/6b0020b1/export_control.html
----------------------------------------------------------------------
diff --git a/export_control.html b/export_control.html
index f208a8b..13bbb7a 100644
--- a/export_control.html
+++ b/export_control.html
@@ -7,7 +7,7 @@
   <head>
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
-    <meta name="Date-Revision-yyyymmdd" content="20181010" />
+    <meta name="Date-Revision-yyyymmdd" content="20181011" />
     <meta http-equiv="Content-Language" content="en" />
     <title>Apache HBase &#x2013; 
       Export Control
@@ -331,7 +331,7 @@ for more details.</p>
                         <a href="https://www.apache.org/">The Apache Software Foundation</a>.
             All rights reserved.      
                     
-                  <li id="publishDate" class="pull-right">Last Published: 2018-10-10</li>
+                  <li id="publishDate" class="pull-right">Last Published: 2018-10-11</li>
             </p>
                 </div>
 

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/6b0020b1/index.html
----------------------------------------------------------------------
diff --git a/index.html b/index.html
index 6a03e9c..e5868b3 100644
--- a/index.html
+++ b/index.html
@@ -7,7 +7,7 @@
   <head>
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
-    <meta name="Date-Revision-yyyymmdd" content="20181010" />
+    <meta name="Date-Revision-yyyymmdd" content="20181011" />
     <meta http-equiv="Content-Language" content="en" />
     <title>Apache HBase &#x2013; Apache HBaseâ„¢ Home</title>
     <link rel="stylesheet" href="./css/apache-maven-fluido-1.4-HBase.min.css" />
@@ -411,7 +411,7 @@ Apache HBase is an open-source, distributed, versioned, non-relational database
                         <a href="https://www.apache.org/">The Apache Software Foundation</a>.
             All rights reserved.      
                     
-                  <li id="publishDate" class="pull-right">Last Published: 2018-10-10</li>
+                  <li id="publishDate" class="pull-right">Last Published: 2018-10-11</li>
             </p>
                 </div>
 

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/6b0020b1/integration.html
----------------------------------------------------------------------
diff --git a/integration.html b/integration.html
index b5e8683..838a113 100644
--- a/integration.html
+++ b/integration.html
@@ -7,7 +7,7 @@
   <head>
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
-    <meta name="Date-Revision-yyyymmdd" content="20181010" />
+    <meta name="Date-Revision-yyyymmdd" content="20181011" />
     <meta http-equiv="Content-Language" content="en" />
     <title>Apache HBase &#x2013; CI Management</title>
     <link rel="stylesheet" href="./css/apache-maven-fluido-1.4-HBase.min.css" />
@@ -291,7 +291,7 @@
                         <a href="https://www.apache.org/">The Apache Software Foundation</a>.
             All rights reserved.      
                     
-                  <li id="publishDate" class="pull-right">Last Published: 2018-10-10</li>
+                  <li id="publishDate" class="pull-right">Last Published: 2018-10-11</li>
             </p>
                 </div>
 

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/6b0020b1/issue-tracking.html
----------------------------------------------------------------------
diff --git a/issue-tracking.html b/issue-tracking.html
index 8f44146..d89d18c 100644
--- a/issue-tracking.html
+++ b/issue-tracking.html
@@ -7,7 +7,7 @@
   <head>
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
-    <meta name="Date-Revision-yyyymmdd" content="20181010" />
+    <meta name="Date-Revision-yyyymmdd" content="20181011" />
     <meta http-equiv="Content-Language" content="en" />
     <title>Apache HBase &#x2013; Issue Management</title>
     <link rel="stylesheet" href="./css/apache-maven-fluido-1.4-HBase.min.css" />
@@ -288,7 +288,7 @@
                         <a href="https://www.apache.org/">The Apache Software Foundation</a>.
             All rights reserved.      
                     
-                  <li id="publishDate" class="pull-right">Last Published: 2018-10-10</li>
+                  <li id="publishDate" class="pull-right">Last Published: 2018-10-11</li>
             </p>
                 </div>