You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Emmanuel Lécharny <el...@gmail.com> on 2014/10/26 20:58:42 UTC
Re: svn commit: r1634381 - in /directory/studio/branches/studio-tycho/plugins:
aciitemeditor/META-INF/MANIFEST.MF schemaeditor/META-INF/MANIFEST.MF valueeditors/META-INF/MANIFEST.MF
I stefan,
I have a question : why is it necessary to remove the version from the
import package? Isn't it better to enforce the use of a specific version
? (just wondering...)
Le 26/10/14 20:05, seelmann@apache.org a écrit :
> Author: seelmann
> Date: Sun Oct 26 19:05:52 2014
> New Revision: 1634381
>
> URL: http://svn.apache.org/r1634381
> Log:
> Add missing activator and localization. remove versions from import package
>
> Modified:
> directory/studio/branches/studio-tycho/plugins/aciitemeditor/META-INF/MANIFEST.MF
> directory/studio/branches/studio-tycho/plugins/schemaeditor/META-INF/MANIFEST.MF
> directory/studio/branches/studio-tycho/plugins/valueeditors/META-INF/MANIFEST.MF
>
> Modified: directory/studio/branches/studio-tycho/plugins/aciitemeditor/META-INF/MANIFEST.MF
> URL: http://svn.apache.org/viewvc/directory/studio/branches/studio-tycho/plugins/aciitemeditor/META-INF/MANIFEST.MF?rev=1634381&r1=1634380&r2=1634381&view=diff
> ==============================================================================
> --- directory/studio/branches/studio-tycho/plugins/aciitemeditor/META-INF/MANIFEST.MF (original)
> +++ directory/studio/branches/studio-tycho/plugins/aciitemeditor/META-INF/MANIFEST.MF Sun Oct 26 19:05:52 2014
> @@ -6,6 +6,8 @@ Bundle-Version: 2.0.0.qualifier
> Bundle-SymbolicName: org.apache.directory.studio.aciitemeditor;singleton:=true
> Bundle-License: http://www.apache.org/licenses/LICENSE-2.0.txt
> Bundle-RequiredExecutionEnvironment: JavaSE-1.6
> +Bundle-Localization: plugin
> +Bundle-Activator: org.apache.directory.studio.aciitemeditor.Activator
> Eclipse-LazyStart: true
> Export-Package: org.apache.directory.studio.aciitemeditor
> Require-Bundle: org.eclipse.core.runtime,
>
> Modified: directory/studio/branches/studio-tycho/plugins/schemaeditor/META-INF/MANIFEST.MF
> URL: http://svn.apache.org/viewvc/directory/studio/branches/studio-tycho/plugins/schemaeditor/META-INF/MANIFEST.MF?rev=1634381&r1=1634380&r2=1634381&view=diff
> ==============================================================================
> --- directory/studio/branches/studio-tycho/plugins/schemaeditor/META-INF/MANIFEST.MF (original)
> +++ directory/studio/branches/studio-tycho/plugins/schemaeditor/META-INF/MANIFEST.MF Sun Oct 26 19:05:52 2014
> @@ -6,12 +6,14 @@ Bundle-Version: 2.0.0.qualifier
> Bundle-SymbolicName: org.apache.directory.studio.schemaeditor;singleton:=true
> Bundle-License: http://www.apache.org/licenses/LICENSE-2.0.txt
> Bundle-RequiredExecutionEnvironment: JavaSE-1.6
> +Bundle-Localization: plugin
> +Bundle-Activator: org.apache.directory.studio.schemaeditor.Activator
> Eclipse-LazyStart: true
> Export-Package: org.apache.directory.studio.schemaeditor
> -Import-Package: org.apache.commons.collections;version="3.2.1",
> - org.apache.commons.collections.map;version="3.2.1",
> - org.apache.commons.io;version="2.4",
> - org.apache.log4j;bundle-version="1.2.17",
> +Import-Package: org.apache.commons.collections,
> + org.apache.commons.collections.map,
> + org.apache.commons.io,
> + org.apache.log4j,
> org.dom4j,
> org.dom4j.io
> Require-Bundle: org.eclipse.core.runtime,
>
> Modified: directory/studio/branches/studio-tycho/plugins/valueeditors/META-INF/MANIFEST.MF
> URL: http://svn.apache.org/viewvc/directory/studio/branches/studio-tycho/plugins/valueeditors/META-INF/MANIFEST.MF?rev=1634381&r1=1634380&r2=1634381&view=diff
> ==============================================================================
> --- directory/studio/branches/studio-tycho/plugins/valueeditors/META-INF/MANIFEST.MF (original)
> +++ directory/studio/branches/studio-tycho/plugins/valueeditors/META-INF/MANIFEST.MF Sun Oct 26 19:05:52 2014
> @@ -6,14 +6,16 @@ Bundle-Version: 2.0.0.qualifier
> Bundle-SymbolicName: org.apache.directory.studio.valueeditors;singleton:=true
> Bundle-License: http://www.apache.org/licenses/LICENSE-2.0.txt
> Bundle-RequiredExecutionEnvironment: JavaSE-1.6
> +Bundle-Localization: plugin
> +Bundle-Activator: org.apache.directory.studio.valueeditors.ValueEditorsActivator
> Eclipse-LazyStart: true
> Export-Package: org.apache.directory.studio.valueeditors,
> org.apache.directory.studio.valueeditors.dn,
> org.apache.directory.studio.valueeditors.integer
> Import-Package: org.apache.commons.lang,
> - org.apache.commons.codec;bundle-version="1.8",
> - org.apache.commons.codec.binary;bundle-version="1.8",
> - org.apache.commons.io;bundle-version="2.4"
> + org.apache.commons.codec,
> + org.apache.commons.codec.binary,
> + org.apache.commons.io
> Require-Bundle: org.eclipse.core.runtime,
> org.apache.directory.api.ldap.model;bundle-version="1.0.0.M24",
> org.apache.directory.api.util;bundle-version="1.0.0.M24",
>
>
Re: svn commit: r1634381 - in /directory/studio/branches/studio-tycho/plugins:
aciitemeditor/META-INF/MANIFEST.MF schemaeditor/META-INF/MANIFEST.MF valueeditors/META-INF/MANIFEST.MF
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 26/10/14 21:13, Stefan Seelmann a écrit :
> Hi Emmanuel,
>
> I removed it for now because Eclipse complained about the version "2.4"
> of commons.io, the right OSGi version would be 2.4.0.
I think that 2.4 will get extended automatically to 2.4.0. In fact, 2.4
stands for 2.4.* :
http://www.eclipse.org/virgo/documentation/virgo-documentation-3.6.0.M03/docs/virgo-user-guide/html/ch02s02.html
"Package Version :
Each exported package has a version. The exported package’s version may
be specified on the Export-Package manifest header. For example
Export-Package: org.foo;version="2.9",org.bar;version="1"
exports two packages: |org.foo|, at version |2.9.0| and |org.bar|, at
version |1.0.0|."
> Also for
> Import-Package it must be named "version", not "bundle-version" (in
> valueeditor).
My bad.
> As far as I understand that named version is the minimum
> version, not a fixed version.
It can, we can also define a range, like [2.4,2.6] (which means all the
versions between 2.4.0 and 2.6.N.
> But I agree that a version makes sense,
> I'd add them later when migration is done and all works fine.
Okie, makes sense. At some point, I think we should have the Manifest
containing meta-information, not real versions, otherwise it will be a
real burden to update all the manifests which contain versions... I have
no idea if it's possible though.
Re: svn commit: r1634381 - in /directory/studio/branches/studio-tycho/plugins:
aciitemeditor/META-INF/MANIFEST.MF schemaeditor/META-INF/MANIFEST.MF valueeditors/META-INF/MANIFEST.MF
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 26/10/14 21:13, Stefan Seelmann a écrit :
> Hi Emmanuel,
>
> I removed it for now because Eclipse complained about the version "2.4"
> of commons.io, the right OSGi version would be 2.4.0. Also for
> Import-Package it must be named "version", not "bundle-version" (in
> valueeditor).
After having checked, the difference is subtile.
'version=' stands for the package version.
'bundle-version=' stands for the bundle, and it requires the
'bundle-symbolic-name=' to be valid.
Note that, as weird as it may sound, a bundle may have more than one
version for a package.
Here, we could have used bundle-version=... assuming that we have
specified the commons-io bundle symbolic name, like :
org.apache.commons.codec;bundle-symbolic-name="org.apache.commons.io";bundle-version="1.8",
As we build a bundle from the commons-io jar, it should work...
Here is the created commons-io bundle's MANIFEST :
Manifest-Version: 1.0
Export-Package:
org.apache.commons.io;version="1.4.9999",
org.apache.commons.io.comparator;version="1.4.9999",
org.apache.commons.io.filefilter;version="1.4.9999",
org.apache.commons.io.input;version="1.4.9999",
org.apache.commons.io.output;version="1.4.9999",
org.apache.commons.io;version="2.4",
org.apache.commons.io.comparator;version="2.4",
org.apache.commons.io.filefilter;version="2.4",
org.apache.commons.io.input;version="2.4",
org.apache.commons.io.output;version="2.4",
org.apache.commons.io.monitor;version="2.4"
Bundle-SymbolicName: org.apache.commons.io
Bundle-Name: Commons IO
Bundle-Version: 2.4.0
Specification-Version: 2.4
...
Re: svn commit: r1634381 - in /directory/studio/branches/studio-tycho/plugins:
aciitemeditor/META-INF/MANIFEST.MF schemaeditor/META-INF/MANIFEST.MF valueeditors/META-INF/MANIFEST.MF
Posted by Stefan Seelmann <ma...@stefan-seelmann.de>.
Hi Emmanuel,
I removed it for now because Eclipse complained about the version "2.4"
of commons.io, the right OSGi version would be 2.4.0. Also for
Import-Package it must be named "version", not "bundle-version" (in
valueeditor). As far as I understand that named version is the minimum
version, not a fixed version. But I agree that a version makes sense,
I'd add them later when migration is done and all works fine.
Kind Regards,
Stefan
On 10/26/2014 08:58 PM, Emmanuel Lécharny wrote:
> I stefan,
>
> I have a question : why is it necessary to remove the version from the
> import package? Isn't it better to enforce the use of a specific version
> ? (just wondering...)
>
>
>
> Le 26/10/14 20:05, seelmann@apache.org a écrit :
>> Author: seelmann
>> Date: Sun Oct 26 19:05:52 2014
>> New Revision: 1634381
>>
>> URL: http://svn.apache.org/r1634381
>> Log:
>> Add missing activator and localization. remove versions from import package
>>
>> Modified:
>> directory/studio/branches/studio-tycho/plugins/aciitemeditor/META-INF/MANIFEST.MF
>> directory/studio/branches/studio-tycho/plugins/schemaeditor/META-INF/MANIFEST.MF
>> directory/studio/branches/studio-tycho/plugins/valueeditors/META-INF/MANIFEST.MF
>>
>> Modified: directory/studio/branches/studio-tycho/plugins/aciitemeditor/META-INF/MANIFEST.MF
>> URL: http://svn.apache.org/viewvc/directory/studio/branches/studio-tycho/plugins/aciitemeditor/META-INF/MANIFEST.MF?rev=1634381&r1=1634380&r2=1634381&view=diff
>> ==============================================================================
>> --- directory/studio/branches/studio-tycho/plugins/aciitemeditor/META-INF/MANIFEST.MF (original)
>> +++ directory/studio/branches/studio-tycho/plugins/aciitemeditor/META-INF/MANIFEST.MF Sun Oct 26 19:05:52 2014
>> @@ -6,6 +6,8 @@ Bundle-Version: 2.0.0.qualifier
>> Bundle-SymbolicName: org.apache.directory.studio.aciitemeditor;singleton:=true
>> Bundle-License: http://www.apache.org/licenses/LICENSE-2.0.txt
>> Bundle-RequiredExecutionEnvironment: JavaSE-1.6
>> +Bundle-Localization: plugin
>> +Bundle-Activator: org.apache.directory.studio.aciitemeditor.Activator
>> Eclipse-LazyStart: true
>> Export-Package: org.apache.directory.studio.aciitemeditor
>> Require-Bundle: org.eclipse.core.runtime,
>>
>> Modified: directory/studio/branches/studio-tycho/plugins/schemaeditor/META-INF/MANIFEST.MF
>> URL: http://svn.apache.org/viewvc/directory/studio/branches/studio-tycho/plugins/schemaeditor/META-INF/MANIFEST.MF?rev=1634381&r1=1634380&r2=1634381&view=diff
>> ==============================================================================
>> --- directory/studio/branches/studio-tycho/plugins/schemaeditor/META-INF/MANIFEST.MF (original)
>> +++ directory/studio/branches/studio-tycho/plugins/schemaeditor/META-INF/MANIFEST.MF Sun Oct 26 19:05:52 2014
>> @@ -6,12 +6,14 @@ Bundle-Version: 2.0.0.qualifier
>> Bundle-SymbolicName: org.apache.directory.studio.schemaeditor;singleton:=true
>> Bundle-License: http://www.apache.org/licenses/LICENSE-2.0.txt
>> Bundle-RequiredExecutionEnvironment: JavaSE-1.6
>> +Bundle-Localization: plugin
>> +Bundle-Activator: org.apache.directory.studio.schemaeditor.Activator
>> Eclipse-LazyStart: true
>> Export-Package: org.apache.directory.studio.schemaeditor
>> -Import-Package: org.apache.commons.collections;version="3.2.1",
>> - org.apache.commons.collections.map;version="3.2.1",
>> - org.apache.commons.io;version="2.4",
>> - org.apache.log4j;bundle-version="1.2.17",
>> +Import-Package: org.apache.commons.collections,
>> + org.apache.commons.collections.map,
>> + org.apache.commons.io,
>> + org.apache.log4j,
>> org.dom4j,
>> org.dom4j.io
>> Require-Bundle: org.eclipse.core.runtime,
>>
>> Modified: directory/studio/branches/studio-tycho/plugins/valueeditors/META-INF/MANIFEST.MF
>> URL: http://svn.apache.org/viewvc/directory/studio/branches/studio-tycho/plugins/valueeditors/META-INF/MANIFEST.MF?rev=1634381&r1=1634380&r2=1634381&view=diff
>> ==============================================================================
>> --- directory/studio/branches/studio-tycho/plugins/valueeditors/META-INF/MANIFEST.MF (original)
>> +++ directory/studio/branches/studio-tycho/plugins/valueeditors/META-INF/MANIFEST.MF Sun Oct 26 19:05:52 2014
>> @@ -6,14 +6,16 @@ Bundle-Version: 2.0.0.qualifier
>> Bundle-SymbolicName: org.apache.directory.studio.valueeditors;singleton:=true
>> Bundle-License: http://www.apache.org/licenses/LICENSE-2.0.txt
>> Bundle-RequiredExecutionEnvironment: JavaSE-1.6
>> +Bundle-Localization: plugin
>> +Bundle-Activator: org.apache.directory.studio.valueeditors.ValueEditorsActivator
>> Eclipse-LazyStart: true
>> Export-Package: org.apache.directory.studio.valueeditors,
>> org.apache.directory.studio.valueeditors.dn,
>> org.apache.directory.studio.valueeditors.integer
>> Import-Package: org.apache.commons.lang,
>> - org.apache.commons.codec;bundle-version="1.8",
>> - org.apache.commons.codec.binary;bundle-version="1.8",
>> - org.apache.commons.io;bundle-version="2.4"
>> + org.apache.commons.codec,
>> + org.apache.commons.codec.binary,
>> + org.apache.commons.io
>> Require-Bundle: org.eclipse.core.runtime,
>> org.apache.directory.api.ldap.model;bundle-version="1.0.0.M24",
>> org.apache.directory.api.util;bundle-version="1.0.0.M24",
>>
>>
>