You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/06/19 19:07:23 UTC
Review Request 70903: Killed all tasks on the agent when draining.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70903/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
Bugs: MESOS-9821
https://issues.apache.org/jira/browse/MESOS-9821
Repository: mesos
Description
-------
This patch updates the agent's `DrainSlaveMessage` handler
to kill all tasks on the agent when the message is received.
Diffs
-----
include/mesos/type_utils.hpp 57b1893160dbe874aa9fec00a3d1b640b9c54906
src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
Diff: https://reviews.apache.org/r/70903/diff/1/
Testing
-------
Testing details at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 70903: Killed all tasks on the agent when draining.
Posted by Greg Mann <gr...@mesosphere.io>.
> On June 21, 2019, 5:28 p.m., Joseph Wu wrote:
> > src/slave/slave.cpp
> > Lines 1005-1009 (patched)
> > <https://reviews.apache.org/r/70903/diff/1/?file=2151408#file2151408line1005>
> >
> > Perhaps you can move this entire section and below into a separate `_drain()` continuation so that the recovery code an re-use it.
> >
> > I'm expecting the recovery to set `drainInfo` separately, but then need to start killing (this code) again.
The way BBannier wrote the recovery code, it just re-processes the entire `DrainSlaveMessage`, so I think this is OK as-is for now.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70903/#review216058
-----------------------------------------------------------
On June 19, 2019, 7:07 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70903/
> -----------------------------------------------------------
>
> (Updated June 19, 2019, 7:07 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9821
> https://issues.apache.org/jira/browse/MESOS-9821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the agent's `DrainSlaveMessage` handler
> to kill all tasks on the agent when the message is received.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 57b1893160dbe874aa9fec00a3d1b640b9c54906
> src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
>
>
> Diff: https://reviews.apache.org/r/70903/diff/1/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70903: Killed all tasks on the agent when draining.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70903/#review216058
-----------------------------------------------------------
src/slave/slave.cpp
Lines 1005-1009 (patched)
<https://reviews.apache.org/r/70903/#comment303033>
Perhaps you can move this entire section and below into a separate `_drain()` continuation so that the recovery code an re-use it.
I'm expecting the recovery to set `drainInfo` separately, but then need to start killing (this code) again.
src/slave/slave.cpp
Lines 1013-1014 (patched)
<https://reviews.apache.org/r/70903/#comment303032>
Might help to mention this mirrors the (hard coded! D:) defaults in the default and command executors.
- Joseph Wu
On June 19, 2019, 12:07 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70903/
> -----------------------------------------------------------
>
> (Updated June 19, 2019, 12:07 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9821
> https://issues.apache.org/jira/browse/MESOS-9821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the agent's `DrainSlaveMessage` handler
> to kill all tasks on the agent when the message is received.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 57b1893160dbe874aa9fec00a3d1b640b9c54906
> src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
>
>
> Diff: https://reviews.apache.org/r/70903/diff/1/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70903: Killed all tasks on the agent when draining.
Posted by Greg Mann <gr...@mesosphere.io>.
> On June 27, 2019, 1:36 p.m., Benjamin Bannier wrote:
> > src/slave/slave.cpp
> > Lines 1005 (patched)
> > <https://reviews.apache.org/r/70903/diff/2/?file=2152205#file2152205line1005>
> >
> > If we'd just take a `const variant<Task, TaskInfo>&` here we could remove some noise at the call sites. We could then extra the `kill_policy` inside the lambda by visiting the respective variant.
I tried this out and I think the `Variant` version is actually a bit noisier and harder to read. I'm going to drop this issue and leave as-is, since the noise at the callsites here is pretty minimal (just a ternary operator).
> On June 27, 2019, 1:36 p.m., Benjamin Bannier wrote:
> > src/slave/slave.cpp
> > Lines 1010-1016 (patched)
> > <https://reviews.apache.org/r/70903/diff/2/?file=2152205#file2152205line1010>
> >
> > What about custom executors? :/
> >
> > I feel that in general we shouldn't make assumptions about what certain executors are doing, and instead introduce our own agent-specific value (best controllable via a flag).
> >
> > While you are working on this block you could immediately initialize `killPolicyGracePeriod` with the default value, and then possibily overwrite it with the user-provided input.
> >
> > Note that with your first conditional we would inject the 3s even if a kill policy was set (to e.g., be interpreted by a custom executor).
Maybe the following makes sense:
- For the default executor and the command executor, use their default grace period of 3 seconds when no kill policy was set on the task.
- For the Docker executor and custom executors, use the 'executor_shutdown_grace_period' set on the agent. This is the default grace period used by the Docker executor, and perhaps also a reasonable default to assume for custom executors?
> On June 27, 2019, 1:36 p.m., Benjamin Bannier wrote:
> > src/slave/slave.cpp
> > Lines 1043-1046 (patched)
> > <https://reviews.apache.org/r/70903/diff/2/?file=2152205#file2152205line1043>
> >
> > What do you think about introducing a variable for the kill policy to prevent this from spanning so many lines?
> >
> > Here and below.
Assigning the task kill policy to a local variable also ends up taking up several lines... I think I prefer this form, so I'm going to drop this issue for now.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70903/#review216192
-----------------------------------------------------------
On June 25, 2019, 8:12 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70903/
> -----------------------------------------------------------
>
> (Updated June 25, 2019, 8:12 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9821
> https://issues.apache.org/jira/browse/MESOS-9821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the agent's `DrainSlaveMessage` handler
> to kill all tasks on the agent when the message is received.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 57b1893160dbe874aa9fec00a3d1b640b9c54906
> src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
>
>
> Diff: https://reviews.apache.org/r/70903/diff/2/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70903: Killed all tasks on the agent when draining.
Posted by Greg Mann <gr...@mesosphere.io>.
> On June 27, 2019, 1:36 p.m., Benjamin Bannier wrote:
> > src/slave/slave.cpp
> > Lines 1010-1016 (patched)
> > <https://reviews.apache.org/r/70903/diff/2/?file=2152205#file2152205line1010>
> >
> > What about custom executors? :/
> >
> > I feel that in general we shouldn't make assumptions about what certain executors are doing, and instead introduce our own agent-specific value (best controllable via a flag).
> >
> > While you are working on this block you could immediately initialize `killPolicyGracePeriod` with the default value, and then possibily overwrite it with the user-provided input.
> >
> > Note that with your first conditional we would inject the 3s even if a kill policy was set (to e.g., be interpreted by a custom executor).
>
> Greg Mann wrote:
> Maybe the following makes sense:
> - For the default executor and the command executor, use their default grace period of 3 seconds when no kill policy was set on the task.
> - For the Docker executor and custom executors, use the 'executor_shutdown_grace_period' set on the agent. This is the default grace period used by the Docker executor, and perhaps also a reasonable default to assume for custom executors?
After some more thought, I think it may be OK to simply pass through the drain max grace period when it's set and the task grace period is unknown. The worst-case scenario here is that we would apply a longer grace period than intended, which seems OK.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70903/#review216192
-----------------------------------------------------------
On July 1, 2019, 7:57 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70903/
> -----------------------------------------------------------
>
> (Updated July 1, 2019, 7:57 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9821
> https://issues.apache.org/jira/browse/MESOS-9821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the agent's `DrainSlaveMessage` handler
> to kill all tasks on the agent when the message is received.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp ed9190b50c18bd218e2d2c04a6aff82687d2996d
> src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
>
>
> Diff: https://reviews.apache.org/r/70903/diff/3/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70903: Killed all tasks on the agent when draining.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70903/#review216192
-----------------------------------------------------------
src/slave/slave.cpp
Lines 1003 (patched)
<https://reviews.apache.org/r/70903/#comment303268>
`max_grace_period` is an `optional` field, and this line would use a value of zero if it is unset. We should call this out in the proto documentation of `DrainConfig.max_grace_period`.
src/slave/slave.cpp
Lines 1005 (patched)
<https://reviews.apache.org/r/70903/#comment303271>
If we'd just take a `const variant<Task, TaskInfo>&` here we could remove some noise at the call sites. We could then extra the `kill_policy` inside the lambda by visiting the respective variant.
src/slave/slave.cpp
Lines 1010-1016 (patched)
<https://reviews.apache.org/r/70903/#comment303273>
What about custom executors? :/
I feel that in general we shouldn't make assumptions about what certain executors are doing, and instead introduce our own agent-specific value (best controllable via a flag).
While you are working on this block you could immediately initialize `killPolicyGracePeriod` with the default value, and then possibily overwrite it with the user-provided input.
Note that with your first conditional we would inject the 3s even if a kill policy was set (to e.g., be interpreted by a custom executor).
src/slave/slave.cpp
Lines 1024-1026 (patched)
<https://reviews.apache.org/r/70903/#comment303275>
nit: I'd avoid the `else` branch after `return` and simply `return Option<KillPolicy>` here, or just `None` if we'd give the lambda an explicit return type (would also simplify the previous `return`).
src/slave/slave.cpp
Lines 1043-1046 (patched)
<https://reviews.apache.org/r/70903/#comment303272>
What do you think about introducing a variable for the kill policy to prevent this from spanning so many lines?
Here and below.
- Benjamin Bannier
On June 25, 2019, 10:12 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70903/
> -----------------------------------------------------------
>
> (Updated June 25, 2019, 10:12 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9821
> https://issues.apache.org/jira/browse/MESOS-9821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the agent's `DrainSlaveMessage` handler
> to kill all tasks on the agent when the message is received.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 57b1893160dbe874aa9fec00a3d1b640b9c54906
> src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
>
>
> Diff: https://reviews.apache.org/r/70903/diff/2/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70903: Killed all tasks on the agent when draining.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70903/#review216330
-----------------------------------------------------------
src/slave/slave.cpp
Lines 1034 (patched)
<https://reviews.apache.org/r/70903/#comment303498>
This could use some comment explaining why the `utils::copy` is needed. I believe frameworks will be removed while inside `kill()`, which calls `statusUpdate()`, which checks `framework->idle()`, and then calls `removeFramework`.
Normally, unless the modification to the copied list is very obvious, a comment is needed to justify the copy.
Similar with the other copies within this loop. (And the one `executor->launchedTasks` that isn't copied.)
- Joseph Wu
On July 1, 2019, 12:57 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70903/
> -----------------------------------------------------------
>
> (Updated July 1, 2019, 12:57 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9821
> https://issues.apache.org/jira/browse/MESOS-9821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the agent's `DrainSlaveMessage` handler
> to kill all tasks on the agent when the message is received.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp ed9190b50c18bd218e2d2c04a6aff82687d2996d
> src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
>
>
> Diff: https://reviews.apache.org/r/70903/diff/3/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70903: Killed all tasks on the agent when draining.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70903/#review216574
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On July 12, 2019, 2:54 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70903/
> -----------------------------------------------------------
>
> (Updated July 12, 2019, 2:54 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9821
> https://issues.apache.org/jira/browse/MESOS-9821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the agent's `DrainSlaveMessage` handler
> to kill all tasks on the agent when the message is received.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp ed9190b50c18bd218e2d2c04a6aff82687d2996d
> src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
>
>
> Diff: https://reviews.apache.org/r/70903/diff/5/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70903: Killed all tasks on the agent when draining.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70903/
-----------------------------------------------------------
(Updated July 12, 2019, 9:54 p.m.)
Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
Bugs: MESOS-9821
https://issues.apache.org/jira/browse/MESOS-9821
Repository: mesos
Description
-------
This patch updates the agent's `DrainSlaveMessage` handler
to kill all tasks on the agent when the message is received.
Diffs (updated)
-----
include/mesos/type_utils.hpp ed9190b50c18bd218e2d2c04a6aff82687d2996d
src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
Diff: https://reviews.apache.org/r/70903/diff/5/
Changes: https://reviews.apache.org/r/70903/diff/4-5/
Testing
-------
Testing details at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 70903: Killed all tasks on the agent when draining.
Posted by Greg Mann <gr...@mesosphere.io>.
> On July 12, 2019, 8:31 p.m., Joseph Wu wrote:
> > src/slave/slave.cpp
> > Lines 1010-1018 (patched)
> > <https://reviews.apache.org/r/70903/diff/4/?file=2154280#file2154280line1010>
> >
> > This is missing the case for when the override is set, but the task's grace period is not set (or unknown).
> > Per: https://reviews.apache.org/r/70903/#comment303273
> >
> > I suggest:
> > ```
> > if (maxGracePeriod.isNone()) {
> > return None();
> > }
> >
> > KillPolicy overridenKillPolicy;
> > overridenKillPolicy.mutable_grace_period()->CopyFrom(maxGracePeriod.get());
> >
> > // Task kill policy is not set or unknown.
> > if (killPolicy.isNone() || !killPolicy->has_grace_period()) {
> > return overridenKillPolicy;
> > }
> >
> > // Task kill policy is less than the override.
> > if (maxGracePeriod.get() < killPolicy->grace_period()) {
> > return overridenKillPolicy;
> > }
> >
> > return None();
> > ```
Thanks for catching this!
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70903/#review216567
-----------------------------------------------------------
On July 12, 2019, 9:54 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70903/
> -----------------------------------------------------------
>
> (Updated July 12, 2019, 9:54 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9821
> https://issues.apache.org/jira/browse/MESOS-9821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the agent's `DrainSlaveMessage` handler
> to kill all tasks on the agent when the message is received.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp ed9190b50c18bd218e2d2c04a6aff82687d2996d
> src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
>
>
> Diff: https://reviews.apache.org/r/70903/diff/5/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70903: Killed all tasks on the agent when draining.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70903/#review216567
-----------------------------------------------------------
src/slave/slave.cpp
Lines 1010-1018 (patched)
<https://reviews.apache.org/r/70903/#comment303778>
This is missing the case for when the override is set, but the task's grace period is not set (or unknown).
Per: https://reviews.apache.org/r/70903/#comment303273
I suggest:
```
if (maxGracePeriod.isNone()) {
return None();
}
KillPolicy overridenKillPolicy;
overridenKillPolicy.mutable_grace_period()->CopyFrom(maxGracePeriod.get());
// Task kill policy is not set or unknown.
if (killPolicy.isNone() || !killPolicy->has_grace_period()) {
return overridenKillPolicy;
}
// Task kill policy is less than the override.
if (maxGracePeriod.get() < killPolicy->grace_period()) {
return overridenKillPolicy;
}
return None();
```
- Joseph Wu
On July 10, 2019, 12:07 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70903/
> -----------------------------------------------------------
>
> (Updated July 10, 2019, 12:07 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9821
> https://issues.apache.org/jira/browse/MESOS-9821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the agent's `DrainSlaveMessage` handler
> to kill all tasks on the agent when the message is received.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp ed9190b50c18bd218e2d2c04a6aff82687d2996d
> src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
>
>
> Diff: https://reviews.apache.org/r/70903/diff/4/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70903: Killed all tasks on the agent when draining.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70903/
-----------------------------------------------------------
(Updated July 10, 2019, 7:07 p.m.)
Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
Bugs: MESOS-9821
https://issues.apache.org/jira/browse/MESOS-9821
Repository: mesos
Description
-------
This patch updates the agent's `DrainSlaveMessage` handler
to kill all tasks on the agent when the message is received.
Diffs (updated)
-----
include/mesos/type_utils.hpp ed9190b50c18bd218e2d2c04a6aff82687d2996d
src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
Diff: https://reviews.apache.org/r/70903/diff/4/
Changes: https://reviews.apache.org/r/70903/diff/3-4/
Testing
-------
Testing details at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 70903: Killed all tasks on the agent when draining.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70903/
-----------------------------------------------------------
(Updated July 1, 2019, 7:57 p.m.)
Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
Bugs: MESOS-9821
https://issues.apache.org/jira/browse/MESOS-9821
Repository: mesos
Description
-------
This patch updates the agent's `DrainSlaveMessage` handler
to kill all tasks on the agent when the message is received.
Diffs (updated)
-----
include/mesos/type_utils.hpp ed9190b50c18bd218e2d2c04a6aff82687d2996d
src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
Diff: https://reviews.apache.org/r/70903/diff/3/
Changes: https://reviews.apache.org/r/70903/diff/2-3/
Testing
-------
Testing details at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 70903: Killed all tasks on the agent when draining.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70903/
-----------------------------------------------------------
(Updated June 25, 2019, 8:12 p.m.)
Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
Bugs: MESOS-9821
https://issues.apache.org/jira/browse/MESOS-9821
Repository: mesos
Description
-------
This patch updates the agent's `DrainSlaveMessage` handler
to kill all tasks on the agent when the message is received.
Diffs (updated)
-----
include/mesos/type_utils.hpp 57b1893160dbe874aa9fec00a3d1b640b9c54906
src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
Diff: https://reviews.apache.org/r/70903/diff/2/
Changes: https://reviews.apache.org/r/70903/diff/1-2/
Testing
-------
Testing details at the end of this chain.
Thanks,
Greg Mann