You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Neha Narkhede <ne...@gmail.com> on 2014/12/03 00:17:49 UTC

Re: Review Request 27818: Patch for KAFKA-328

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27818/#review63605
-----------------------------------------------------------

Ship it!


Ship It!

- Neha Narkhede


On Nov. 29, 2014, 7:07 a.m., Balaji Seshadri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27818/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2014, 7:07 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-328
>     https://issues.apache.org/jira/browse/KAFKA-328
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-328 Write unit test for kafka server startup and shutdown API - Review Comments
> 
> 
> Diffs
> -----
> 
>   core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala 1bfb501b2f29c50f3fc5f930fdaad02e03b91e4f 
>   core/src/test/scala/unit/kafka/server/ServerStartupTest.scala a0ed4855f2550a0eb2e363dd2fccd8377a9ac172 
> 
> Diff: https://reviews.apache.org/r/27818/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Balaji Seshadri
> 
>