[GitHub] [dolphinscheduler] ruanwenjun commented on issue #10617: [Improvement][Master] Remove the extra check of slot

[GitBox <gi...@apache.org>]

ruanwenjun commented on issue #10617:
URL: https://github.com/apache/dolphinscheduler/issues/10617#issuecomment-1166775235

   > I have a different point, although we already have the database transaction to gurantee the command just be consumed once, but it's not a lightweight operations and will increase the database pressure, so I think the slot check, as the pre-check, is still necessary. WDYT
   
   We will check the slot when query from the database, so in most of the time, there will not database rollback. My concern is that is we use the `slotCheck` here, some user may think this method can guarantee the command be consumed safe by one master. So if we really don't want to remove these, we still need to add a comment to tell this method is not safe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org