[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

[GitBox <gi...@apache.org>]

bakaid commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.
URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378754450
 
 

 ##########
 File path: libminifi/src/c2/C2Agent.cpp
 ##########
 @@ -539,9 +563,9 @@ void C2Agent::handle_describe(const C2ContentResponse &resp) {
   } else if (resp.name == "manifest") {
     auto keys = configuration_->getConfiguredKeys();
     C2Payload response(Operation::ACKNOWLEDGE, resp.ident, false, true);
-    response.setLabel("configuration_options");
+    response.setLabel("configurationOptions");
 
 Review comment:
   Why does this have the same label as the response for "configuration"?
   It would also have the same label as the response for "jstack", but "jstack" hasn't been changed to "configurationOptions".
   This does not look right.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services