[GitHub] [pinot] weixiangsun commented on a change in pull request #7584: Add LASTWITHTIME aggregate function support #7315

[GitBox <gi...@apache.org>]

weixiangsun commented on a change in pull request #7584:
URL: https://github.com/apache/pinot/pull/7584#discussion_r731100282



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionFactory.java
##########
@@ -156,6 +156,13 @@ public static AggregationFunction getAggregationFunction(FunctionContext functio
             return new AvgAggregationFunction(firstArgument);
           case MODE:
             return new ModeAggregationFunction(arguments);
+          case LASTWITHTIME:
+            if (arguments.size() > 1) {
+              ExpressionContext secondArgument = arguments.get(1);
+              return new LastWithTimeAggregationFunction(firstArgument, secondArgument);
+            } else {
+              throw new IllegalArgumentException();

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org