You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Jason Pyeron <jp...@pdinc.us> on 2014/01/02 13:40:19 UTC
[OGNL] big patches or lots of little patches?
I am working OGNL-145 right now and it is a lot of work and a lot of changes.
I think it is best to make the change in atomic chunks and to collect the lint
patches up and apply them when done.
What does the group think?
-Jason
> -----Original Message-----
> From: Lukasz Lenart (JIRA)
> Sent: Thursday, January 02, 2014 1:50
> Subject: [jira] [Commented] (OGNL-241) remove unneeded
> reflection in OgnlException
>
>
> [
>
https://issues.apache.org/jira/browse/OGNL-241?page=com.atlassian.jira.plugin.sy
stem.issuetabpanels:comment->
tabpanel&focusedCommentId=13860050#comment-13860050 ]
>
> Lukasz Lenart commented on OGNL-241:
> ------------------------------------
>
> Can you prepare a patch or pull request?
>
> > remove unneeded reflection in OgnlException
> > -------------------------------------------
> >
> > Key: OGNL-241
> > URL: https://issues.apache.org/jira/browse/OGNL-241
> > Project: Commons OGNL
> > Issue Type: Improvement
> > Components: Core Runtime
> > Affects Versions: 4.0
> > Reporter: Jason Pyeron
> > Fix For: 4.0
> >
> > Attachments:
> > 0001-OGNL-241-clean-up-the-OgnlException-for-Java-1.4-and.patch
> >
> >
> > Since OGNL no longer supports Java 1.3 and below, the
> initCause method is always available.
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
- -
- Jason Pyeron PD Inc. http://www.pdinc.us -
- Principal Consultant 10 West 24th Street #100 -
- +1 (443) 269-1555 x333 Baltimore, Maryland 21218 -
- -
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
This message is copyright PD Inc, subject to license 20080407P00.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
RE: [OGNL] big patches or lots of little patches?
Posted by Jason Pyeron <jp...@pdinc.us>.
> -----Original Message-----
> From: Lukasz Lenart
> Sent: Thursday, January 02, 2014 7:46
>
> The best is patch per JIRA issue IMHO - if there is more work
> to do with one issue, create subtasks to handle them
That is what I am doing for OGNL-145.
Once I am sure the static state removals/changes are working perfectly without
side effects I can go back and re order the patches making them neat and one per
issue.
>
>
> 2014/1/2 Jason Pyeron <jp...@pdinc.us>:
> > I am working OGNL-145 right now and it is a lot of work and
> a lot of changes.
> >
> > I think it is best to make the change in atomic chunks and
> to collect
> > the lint patches up and apply them when done.
> >
> > What does the group think?
> >
> > -Jason
> >
> >> -----Original Message-----
> >> From: Lukasz Lenart (JIRA)
> >> Sent: Thursday, January 02, 2014 1:50
> >> Subject: [jira] [Commented] (OGNL-241) remove unneeded
> reflection in
> >> OgnlException
> >>
> >>
> >> [
> >>
> >
> https://issues.apache.org/jira/browse/OGNL-241?page=com.atlassian.jira
> > .plugin.sy
> > stem.issuetabpanels:comment->
> > tabpanel&focusedCommentId=13860050#comment-13860050 ]
> >>
> >> Lukasz Lenart commented on OGNL-241:
> >> ------------------------------------
> >>
> >> Can you prepare a patch or pull request?
> >>
> >> > remove unneeded reflection in OgnlException
> >> > -------------------------------------------
> >> >
> >> > Key: OGNL-241
> >> > URL:
> https://issues.apache.org/jira/browse/OGNL-241
> >> > Project: Commons OGNL
> >> > Issue Type: Improvement
> >> > Components: Core Runtime
> >> > Affects Versions: 4.0
> >> > Reporter: Jason Pyeron
> >> > Fix For: 4.0
> >> >
> >> > Attachments:
> >> > 0001-OGNL-241-clean-up-the-OgnlException-for-Java-1.4-and.patch
> >> >
> >> >
> >> > Since OGNL no longer supports Java 1.3 and below, the
> >> initCause method is always available.
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
- -
- Jason Pyeron PD Inc. http://www.pdinc.us -
- Principal Consultant 10 West 24th Street #100 -
- +1 (443) 269-1555 x333 Baltimore, Maryland 21218 -
- -
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
This message is copyright PD Inc, subject to license 20080407P00.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [OGNL] big patches or lots of little patches?
Posted by Lukasz Lenart <lu...@apache.org>.
The best is patch per JIRA issue IMHO - if there is more work to do
with one issue, create subtasks to handle them
2014/1/2 Jason Pyeron <jp...@pdinc.us>:
> I am working OGNL-145 right now and it is a lot of work and a lot of changes.
>
> I think it is best to make the change in atomic chunks and to collect the lint
> patches up and apply them when done.
>
> What does the group think?
>
> -Jason
>
>> -----Original Message-----
>> From: Lukasz Lenart (JIRA)
>> Sent: Thursday, January 02, 2014 1:50
>> Subject: [jira] [Commented] (OGNL-241) remove unneeded
>> reflection in OgnlException
>>
>>
>> [
>>
> https://issues.apache.org/jira/browse/OGNL-241?page=com.atlassian.jira.plugin.sy
> stem.issuetabpanels:comment->
> tabpanel&focusedCommentId=13860050#comment-13860050 ]
>>
>> Lukasz Lenart commented on OGNL-241:
>> ------------------------------------
>>
>> Can you prepare a patch or pull request?
>>
>> > remove unneeded reflection in OgnlException
>> > -------------------------------------------
>> >
>> > Key: OGNL-241
>> > URL: https://issues.apache.org/jira/browse/OGNL-241
>> > Project: Commons OGNL
>> > Issue Type: Improvement
>> > Components: Core Runtime
>> > Affects Versions: 4.0
>> > Reporter: Jason Pyeron
>> > Fix For: 4.0
>> >
>> > Attachments:
>> > 0001-OGNL-241-clean-up-the-OgnlException-for-Java-1.4-and.patch
>> >
>> >
>> > Since OGNL no longer supports Java 1.3 and below, the
>> initCause method is always available.
>
> --
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> - -
> - Jason Pyeron PD Inc. http://www.pdinc.us -
> - Principal Consultant 10 West 24th Street #100 -
> - +1 (443) 269-1555 x333 Baltimore, Maryland 21218 -
> - -
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> This message is copyright PD Inc, subject to license 20080407P00.
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org