You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "carloea2 (via GitHub)" <gi...@apache.org> on 2026/08/31 04:01:42 UTC

[PR] fix(pyamber): keep peek side effect free [texera]

carloea2 opened a new pull request, #8226:
URL: https://github.com/apache/texera/pull/8226

   ### What is this PR for?
   
   Scan subqueues with a local index when peeking so observation does not advance the round-robin cursor or alter the next message returned by `get()`.
   
   Closes #8225
   
   ### What type of PR is it?
   
   Bug Fix
   
   ### How was this PR tested?
   
   ```text
   python -c "import sys,pytest; sys.path[:0]=[worktree amber source, main amber source]; raise SystemExit(pytest.main(['amber/src/test/python/core/util/customized_queue/test_linked_blocking_multi_queue.py','amber/src/test/python/core/models/test_internal_queue.py','-q','-p','no:cacheprovider']))"
   76 passed, 1 xfailed
   
   ruff check amber/src/main/python amber/src/test/python
   All checks passed
   
   ruff format --check amber/src/main/python amber/src/test/python
   213 files already formatted
   ```
   
   A direct post-fix probe confirmed that peek does not change the cursor or the next message:
   
   ```text
   cursor_before_peek=0
   peek=second
   cursor_after_peek=0
   next_after_peek=first
   ```
   
   Generated-by: Codex


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(pyamber): keep peek side effect free [texera]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #8226:
URL: https://github.com/apache/texera/pull/8226#issuecomment-5483915485

   I am converting this PR to a draft: please follow our PR template and mark it ready for review. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(pyamber): keep peek side effect free [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8226:
URL: https://github.com/apache/texera/pull/8226#issuecomment-5473528587

   <!-- backport-auto-label-report -->
   ### Backport auto-label report
   
   This `fix:` PR was checked against each actively-supported release branch. `release/*` labels drive the post-merge backport, so add or remove one to change where this fix lands.
   
   | Release branch | Analysis |
   | --- | --- |
   | ⚠️ `release/v1.3` | Not labeled automatically — none of the files this PR modifies exist on this branch (`amber/src/main/python/core/util/customized_queue/linked_blocking_multi_queue.py`, `amber/src/test/python/core/util/customized_queue/test_linked_blocking_multi_queue.py`). The fix may target code that isn't on this release, or the files were moved/renamed after the branch was cut. **Please check and add `release/v1.3` by hand if this fix should be backported here.** |
   | ✅ `release/v1.2` | Change detected on this branch — label added; this fix is queued to backport here. Requested review from @xuang7. |
   
   _[Auto-label run](https://github.com/apache/texera/actions/runs/33355693539)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(pyamber): keep peek side effect free [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8226:
URL: https://github.com/apache/texera/pull/8226#issuecomment-5473560354

   <!-- texera-benchmarks-comment -->
   ## ⚠️ Benchmark changes need a look
   
   🟢 4 better · 🔴 5 worse · ⚪ 6 noise (<±5%) · 0 without baseline
   
   > Compared against main `70c2114` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
   
   [Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/33355703863)
   
   | | config | throughput | MB/s | latency | max Δ latest / 7d |
   |---|---|---:|---:|---:|---:|
   | 🔴 | bs=10 sw=10 sl=64 | 549 | 0.335 | 17,973/25,107/25,107 us | 🟢 -17.4% / 🔴 +69.8% |
   | 🔴 | bs=100 sw=10 sl=64 | 1,112 | 0.679 | 86,693/143,520/143,520 us | 🔴 +31.5% / 🔴 +42.2% |
   | 🔴 | bs=1000 sw=10 sl=64 | 1,307 | 0.798 | 753,029/892,056/892,056 us | 🔴 +10.5% / 🟢 -18.5% |
   
   <details><summary>Baseline details</summary>
   
   Latest main `70c2114` from same runner
   
   | config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
   |---|---|---:|---:|---:|---:|---:|
   | bs=10 sw=10 sl=64 | throughput | 549 tuples/sec | 512 tuples/sec | 844.57 tuples/sec | +7.2% | -35.0% |
   | bs=10 sw=10 sl=64 | MB/s | 0.335 MB/s | 0.313 MB/s | 0.515 MB/s | +7.0% | -35.0% |
   | bs=10 sw=10 sl=64 | p50 | 17,973 us | 16,966 us | 11,837 us | +5.9% | +51.8% |
   | bs=10 sw=10 sl=64 | p95 | 25,107 us | 30,382 us | 14,788 us | -17.4% | +69.8% |
   | bs=10 sw=10 sl=64 | p99 | 25,107 us | 30,382 us | 17,651 us | -17.4% | +42.2% |
   | bs=100 sw=10 sl=64 | throughput | 1,112 tuples/sec | 1,151 tuples/sec | 1,084 tuples/sec | -3.4% | +2.6% |
   | bs=100 sw=10 sl=64 | MB/s | 0.679 MB/s | 0.703 MB/s | 0.662 MB/s | -3.4% | +2.6% |
   | bs=100 sw=10 sl=64 | p50 | 86,693 us | 86,581 us | 94,505 us | +0.1% | -8.3% |
   | bs=100 sw=10 sl=64 | p95 | 143,520 us | 109,153 us | 100,941 us | +31.5% | +42.2% |
   | bs=100 sw=10 sl=64 | p99 | 143,520 us | 109,153 us | 108,642 us | +31.5% | +32.1% |
   | bs=1000 sw=10 sl=64 | throughput | 1,307 tuples/sec | 1,335 tuples/sec | 1,119 tuples/sec | -2.1% | +16.8% |
   | bs=1000 sw=10 sl=64 | MB/s | 0.798 MB/s | 0.815 MB/s | 0.683 MB/s | -2.1% | +16.8% |
   | bs=1000 sw=10 sl=64 | p50 | 753,029 us | 745,053 us | 924,404 us | +1.1% | -18.5% |
   | bs=1000 sw=10 sl=64 | p95 | 892,056 us | 807,167 us | 967,785 us | +10.5% | -7.8% |
   | bs=1000 sw=10 sl=64 | p99 | 892,056 us | 807,167 us | 995,630 us | +10.5% | -10.4% |
   
   </details>
   
   <details><summary>Raw CSV</summary>
   
   ```csv
   config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
   0,10,10,64,20,364.45,200,128000,549,0.335,17973.32,25106.72,25106.72
   1,100,10,64,20,1798.25,2000,1280000,1112,0.679,86693.41,143519.71,143519.71
   2,1000,10,64,20,15303.00,20000,12800000,1307,0.798,753029.42,892056.42,892056.42
   ```
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(pyamber): keep peek side effect free [texera]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8226:
URL: https://github.com/apache/texera/pull/8226#issuecomment-5473548733

   ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8226?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 93.94%. Comparing base ([`70c2114`](https://app.codecov.io/gh/apache/texera/commit/70c21145887920528d7d5540e3fb790b43e8b759?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e332a14`](https://app.codecov.io/gh/apache/texera/commit/e332a1431e7160fbfbbd598956b019c21b74202d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #8226      +/-   ##
   ============================================
   - Coverage     93.94%   93.94%   -0.01%     
     Complexity     4759     4759              
   ============================================
     Files          1185     1185              
     Lines         48069    48067       -2     
     Branches       5359     5359              
   ============================================
   - Hits          45159    45157       -2     
     Misses         1480     1480              
     Partials       1430     1430              
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/texera/pull/8226/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
   |---|---|---|---|
   | [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8226/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | | Carriedforward from [70c2114](https://app.codecov.io/gh/apache/texera/commit/70c21145887920528d7d5540e3fb790b43e8b759?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [agent-service](https://app.codecov.io/gh/apache/texera/pull/8226/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [70c2114](https://app.codecov.io/gh/apache/texera/commit/70c21145887920528d7d5540e3fb790b43e8b759?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [amber](https://app.codecov.io/gh/apache/texera/pull/8226/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `89.99% <ø> (ø)` | | Carriedforward from [70c2114](https://app.codecov.io/gh/apache/texera/commit/70c21145887920528d7d5540e3fb790b43e8b759?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8226/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.67% <ø> (ø)` | | Carriedforward from [70c2114](https://app.codecov.io/gh/apache/texera/commit/70c21145887920528d7d5540e3fb790b43e8b759?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [config-service](https://app.codecov.io/gh/apache/texera/pull/8226/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `86.86% <ø> (ø)` | | Carriedforward from [70c2114](https://app.codecov.io/gh/apache/texera/commit/70c21145887920528d7d5540e3fb790b43e8b759?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [file-service](https://app.codecov.io/gh/apache/texera/pull/8226/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.91% <ø> (ø)` | | Carriedforward from [70c2114](https://app.codecov.io/gh/apache/texera/commit/70c21145887920528d7d5540e3fb790b43e8b759?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [frontend](https://app.codecov.io/gh/apache/texera/pull/8226/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.49% <ø> (ø)` | | Carriedforward from [70c2114](https://app.codecov.io/gh/apache/texera/commit/70c21145887920528d7d5540e3fb790b43e8b759?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8226/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.31% <ø> (ø)` | | Carriedforward from [70c2114](https://app.codecov.io/gh/apache/texera/commit/70c21145887920528d7d5540e3fb790b43e8b759?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [pyamber](https://app.codecov.io/gh/apache/texera/pull/8226/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.87% <100.00%> (-0.01%)` | :arrow_down: | |
   | [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8226/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [70c2114](https://app.codecov.io/gh/apache/texera/commit/70c21145887920528d7d5540e3fb790b43e8b759?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8226?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(pyamber): keep peek side effect free [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8226:
URL: https://github.com/apache/texera/pull/8226#issuecomment-5986683095

   This pull request has been automatically marked as **stale** because it has
   not had any activity for 30 days. It will be closed in **7 days** if no
   further activity occurs.
   
   If this PR is still relevant, please:
   - Push new commits or rebase onto the latest `main`, or
   - Comment with a status update, or
   - Address any open review feedback.
   
   To exempt this PR from auto-close, a maintainer can add the `pinned` label.
   Thank you for your contribution to Apache Texera (incubating)!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(pyamber): keep peek side effect free [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8226:
URL: https://github.com/apache/texera/pull/8226#issuecomment-6116314442

   This pull request has been automatically closed due to 37 days of inactivity.
   If you would like to continue this work, please re-open the PR or open a new
   one referencing this. Thank you for your contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(pyamber): keep peek side effect free [texera]

Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #8226:
URL: https://github.com/apache/texera/pull/8226#issuecomment-5484012128

   The description now follows the current template, and this is ready for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(pyamber): keep peek side effect free [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8226:
URL: https://github.com/apache/texera/pull/8226#issuecomment-5473528433

   <!-- texera:template-compliance -->
   👋 Thanks for opening this pull request, @carloea2!
   
   It looks like the pull request description doesn't quite follow our template yet:
   
   - The **What changes were proposed in this PR?** section is missing; please keep the template's headings.
   - The **Was this PR authored or co-authored using generative AI tooling?** section is missing; please keep the template's headings.
   
   Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
   
   You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(pyamber): keep peek side effect free [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8226:
URL: https://github.com/apache/texera/pull/8226#issuecomment-5473528625

   <!-- texera-reviewer-suggestion -->
   ### Automated Reviewer Suggestions
   
   Based on the `git blame` history of the changed files, we recommend the following reviewers:
   
   - **Contributors with relevant context:** `@mengw15`
     You can notify them by mentioning `@mengw15` in a comment.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(pyamber): keep peek side effect free [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #8226: feat(pyamber): keep peek side effect free
URL: https://github.com/apache/texera/pull/8226


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org