You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@groovy.apache.org by daniel_sun <re...@hotmail.com> on 2016/10/12 12:47:05 UTC
[PROGRESS REPORT 20161012]groovy-parser
Hi dev list,
The brand new parser for Groovy can parse all groovy code of
*Grails-3.2.0(1150 PASSES / 1150 IN TOTAL)*, almost all groovy code of
*Gradle-3.1(3961 PASSES / 3963 IN TOTAL)*, all groovy code of *Spock(294
PASSES / 294 IN TOTAL)*, all groovy code of *Geb-1.0(409 PASSES / 409 IN
TOTAL)*. The whole test result is: *tests failed: 3, passed: 19405,
ignored: 9*, you can find the details at
http://ci.groovy-lang.org/viewType.html?buildTypeId=Groovy_Antlr4grammar&guest=1
Now we have the following issues to fix :
a) the 3 failing test cases related to macro(The PR
https://github.com/apache/groovy/pull/443 can fix them);
b) 2 issues to confirm or fix:
1, https://github.com/danielsun1106/groovy-parser/issues/11
(to confirm)
2, https://github.com/danielsun1106/groovy-parser/issues/10
(to fix)
c) 'src/test/groovy/EscapedUnicodeTest.groovy' is writtern in unicode
escapes and stops groovy generating class files, so I commented it for the
time being. IMO, it seems meaningless to test it becuase the keywords are
also written in unicode escapes. BTW, the brand new parser can handle
unicode escape identifiers properly, e.g. def \u9fa5 = 123
At last, I want to thank* Jochen Theodorou* and *Paul King* who
helped me confirm issues and offered suggestions, *Sergei Egorov* who helped
me fix the 3 failing test cases related to MacroGroovy, *Cédric Champeau*
who offered me a new CI instance :)
Cheers,
Daniel.Sun
--
View this message in context: http://groovy.329449.n5.nabble.com/PROGRESS-REPORT-20161012-groovy-parser-tp5736074.html
Sent from the Groovy Dev mailing list archive at Nabble.com.
Re: [PROGRESS REPORT 20161012]groovy-parser
Posted by daniel_sun <re...@hotmail.com>.
Hi Sergei,
The new parser generates much more accurate position information of AST nodes, which I think will be a good start of Groovy 3. Thanks for your advice again :)
Cheers,
Daniel.Sun
在 "Sergei Egorov [via Groovy]" <ml...@n5.nabble.com>，2016年10月12日 下午8:53写道：
Hi Daniel,
I'll repeat - IMO we should fix the parser, not the MacroGroovy code. MacroGroovy tests just spotted an issue with the source info (line, column) breaking change. However, if we're planning to integrate Antlr4 grammar as a drop-in solution, I think it must be backward compatible. Other's AST code might break as well if they rely on the source positions.
Thanks for mention BTW :)
BR,
Sergei
On Wed, Oct 12, 2016 at 3:47 PM daniel_sun <[hidden email]> wrote:
Hi dev list,
The brand new parser for Groovy can parse all groovy code of
*Grails-3.2.0(1150 PASSES / 1150 IN TOTAL)*, almost all groovy code of
*Gradle-3.1(3961 PASSES / 3963 IN TOTAL)*, all groovy code of *Spock(294
PASSES / 294 IN TOTAL)*, all groovy code of *Geb-1.0(409 PASSES / 409 IN
TOTAL)*. The whole test result is: *tests failed: 3, passed: 19405,
ignored: 9*, you can find the details at
http://ci.groovy-lang.org/viewType.html?buildTypeId=Groovy_Antlr4grammar&guest=1
Now we have the following issues to fix :
a) the 3 failing test cases related to macro(The PR
https://github.com/apache/groovy/pull/443 can fix them);
b) 2 issues to confirm or fix:
1, https://github.com/danielsun1106/groovy-parser/issues/11
(to confirm)
2, https://github.com/danielsun1106/groovy-parser/issues/10
(to fix)
c) 'src/test/groovy/EscapedUnicodeTest.groovy' is writtern in unicode
escapes and stops groovy generating class files, so I commented it for the
time being. IMO, it seems meaningless to test it becuase the keywords are
also written in unicode escapes. BTW, the brand new parser can handle
unicode escape identifiers properly, e.g. def \u9fa5 = 123
At last, I want to thank* Jochen Theodorou* and *Paul King* who
helped me confirm issues and offered suggestions, *Sergei Egorov* who helped
me fix the 3 failing test cases related to MacroGroovy, *Cédric Champeau*
who offered me a new CI instance :)
Cheers,
Daniel.Sun
--
View this message in context: http://groovy.329449.n5.nabble.com/PROGRESS-REPORT-20161012-groovy-parser-tp5736074.html
Sent from the Groovy Dev mailing list archive at Nabble.com.
________________________________
If you reply to this email, your message will be added to the discussion below:
http://groovy.329449.n5.nabble.com/PROGRESS-REPORT-20161012-groovy-parser-tp5736074p5736075.html
To unsubscribe from [PROGRESS REPORT 20161012]groovy-parser, click here<http://groovy.329449.n5.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=5736074&code=cmVhbGJsdWVzdW5AaG90bWFpbC5jb218NTczNjA3NHwxMTQ2MjE4MjI1>.
NAML<http://groovy.329449.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
--
View this message in context: http://groovy.329449.n5.nabble.com/PROGRESS-REPORT-20161012-groovy-parser-tp5736074p5736076.html
Sent from the Groovy Dev mailing list archive at Nabble.com.
Re: [PROGRESS REPORT 20161012]groovy-parser
Posted by Sergei Egorov <bs...@gmail.com>.
Hi Daniel,
I'll repeat - IMO we should fix the parser, not the MacroGroovy code.
MacroGroovy tests just spotted an issue with the source info (line, column)
breaking change. However, if we're planning to integrate Antlr4 grammar as
a drop-in solution, I think it must be backward compatible. Other's AST
code might break as well if they rely on the source positions.
Thanks for mention BTW :)
BR,
Sergei
On Wed, Oct 12, 2016 at 3:47 PM daniel_sun <re...@hotmail.com> wrote:
> Hi dev list,
>
> The brand new parser for Groovy can parse all groovy code of
> *Grails-3.2.0(1150 PASSES / 1150 IN TOTAL)*, almost all groovy code of
> *Gradle-3.1(3961 PASSES / 3963 IN TOTAL)*, all groovy code of *Spock(294
> PASSES / 294 IN TOTAL)*, all groovy code of *Geb-1.0(409 PASSES / 409 IN
> TOTAL)*. The whole test result is: *tests failed: 3, passed: 19405,
> ignored: 9*, you can find the details at
>
> http://ci.groovy-lang.org/viewType.html?buildTypeId=Groovy_Antlr4grammar&guest=1
>
> Now we have the following issues to fix :
> a) the 3 failing test cases related to macro(The PR
> https://github.com/apache/groovy/pull/443 can fix them);
>
> b) 2 issues to confirm or fix:
> 1, https://github.com/danielsun1106/groovy-parser/issues/11
> (to confirm)
> 2, https://github.com/danielsun1106/groovy-parser/issues/10
> (to fix)
>
> c) 'src/test/groovy/EscapedUnicodeTest.groovy' is writtern in unicode
> escapes and stops groovy generating class files, so I commented it for the
> time being. IMO, it seems meaningless to test it becuase the keywords are
> also written in unicode escapes. BTW, the brand new parser can handle
> unicode escape identifiers properly, e.g. def \u9fa5 = 123
>
> At last, I want to thank* Jochen Theodorou* and *Paul King* who
> helped me confirm issues and offered suggestions, *Sergei Egorov* who
> helped
> me fix the 3 failing test cases related to MacroGroovy, *Cédric Champeau*
> who offered me a new CI instance :)
>
> Cheers,
> Daniel.Sun
>
>
>
> --
> View this message in context:
> http://groovy.329449.n5.nabble.com/PROGRESS-REPORT-20161012-groovy-parser-tp5736074.html
> Sent from the Groovy Dev mailing list archive at Nabble.com.
>
Re: [PROGRESS REPORT 20161012]groovy-parser
Posted by daniel_sun <re...@hotmail.com>.
BTW, Groovy 2.5.0 can be built and tested via setting the new parser as the
default parser.
*groovy-parser:*
https://github.com/danielsun1106/groovy-parser
*groovy fork:*
https://github.com/danielsun1106/groovy
Cheers,
Daniel.Sun
--
View this message in context: http://groovy.329449.n5.nabble.com/PROGRESS-REPORT-20161012-groovy-parser-tp5736074p5736077.html
Sent from the Groovy Dev mailing list archive at Nabble.com.