[GitHub] [cordova-ios] Menardi commented on a change in pull request #795: [minor] fix *-Info.plist & config.xml functionality

[GitBox <gi...@apache.org>]

Menardi commented on a change in pull request #795:
URL: https://github.com/apache/cordova-ios/pull/795#discussion_r502807355



##########
File path: bin/templates/scripts/cordova/lib/projectFile.js
##########
@@ -40,13 +40,43 @@ function parseProjectFile (locations) {
     const xcodeproj = xcode.project(pbxPath);
     xcodeproj.parseSync();
 
+    const workspaceName =
+        fs.readdirSync(project_dir).find(d => d.includes('.xcworkspace')) || '';
+
+    const projectName = workspaceName.replace('.xcworkspace', '');

Review comment:
       I've noticed we have a [`getIOSProjectname` function in `cordova-common`](https://github.com/apache/cordova-common/blob/87167bd45670291b68e6e02852a6b4faf63ed247/src/ConfigChanges/ConfigFile.js#L233), maybe you could use it here?
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org