You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/01/14 13:13:20 UTC
[GitHub] [incubator-ratis] maobaolong opened a new pull request #49:
RATIS-792. NPE. ServerOpts.metaQuorum should be required
maobaolong opened a new pull request #49: RATIS-792. NPE. ServerOpts.metaQuorum should be required
URL: https://github.com/apache/incubator-ratis/pull/49
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-ratis] runzhiwang commented on pull request #49: RATIS-792. NPE. ServerOpts.metaQuorum should be required
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #49:
URL: https://github.com/apache/incubator-ratis/pull/49#issuecomment-647467284
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] maobaolong commented on pull request #49: RATIS-792. NPE. ServerOpts.metaQuorum should be required
Posted by GitBox <gi...@apache.org>.
maobaolong commented on pull request #49:
URL: https://github.com/apache/incubator-ratis/pull/49#issuecomment-647465824
@jandrunas Thank you very much for your review. I've done test by execute MetadataServer without any argument.
With this PR.
Exception in thread "main" com.beust.jcommander.ParameterException: The following option is required: [-q | --metaQuorum]
at com.beust.jcommander.JCommander.validateOptions(JCommander.java:381)
at com.beust.jcommander.JCommander.parse(JCommander.java:341)
at com.beust.jcommander.JCommander.parse(JCommander.java:319)
at org.apache.ratis.logservice.server.MetadataServer.main(MetadataServer.java:121)
WIthout this PR.
Exception in thread "main" java.lang.NullPointerException
at org.apache.ratis.logservice.util.LogServiceUtils.getPeersFromQuorum(LogServiceUtils.java:43)
at org.apache.ratis.logservice.server.MetadataServer.start(MetadataServer.java:92)
at org.apache.ratis.logservice.server.MetadataServer.main(MetadataServer.java:127)
Suppressed: java.lang.NullPointerException
at org.apache.ratis.logservice.server.MetadataServer.close(MetadataServer.java:145)
at org.apache.ratis.logservice.server.MetadataServer.main(MetadataServer.java:136)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] maobaolong commented on pull request #49: RATIS-792. NPE. ServerOpts.metaQuorum should be required
Posted by GitBox <gi...@apache.org>.
maobaolong commented on pull request #49:
URL: https://github.com/apache/incubator-ratis/pull/49#issuecomment-667168373
@lokeshj1703 Thanks for your review, this is my first blood for the ratis, I'd like to make more contribution after this. 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] arp7 merged pull request #49: RATIS-792. NPE. ServerOpts.metaQuorum should be required
Posted by GitBox <gi...@apache.org>.
arp7 merged pull request #49:
URL: https://github.com/apache/incubator-ratis/pull/49
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] lokeshj1703 commented on pull request #49: RATIS-792. NPE. ServerOpts.metaQuorum should be required
Posted by GitBox <gi...@apache.org>.
lokeshj1703 commented on pull request #49:
URL: https://github.com/apache/incubator-ratis/pull/49#issuecomment-667796929
@maobaolong Looking forward to your contributions. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] maobaolong commented on pull request #49: RATIS-792. NPE. ServerOpts.metaQuorum should be required
Posted by GitBox <gi...@apache.org>.
maobaolong commented on pull request #49:
URL: https://github.com/apache/incubator-ratis/pull/49#issuecomment-667440248
@arp7 Thank you very much for merge this for me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] lokeshj1703 commented on pull request #49: RATIS-792. NPE. ServerOpts.metaQuorum should be required
Posted by GitBox <gi...@apache.org>.
lokeshj1703 commented on pull request #49:
URL: https://github.com/apache/incubator-ratis/pull/49#issuecomment-667045014
@maobaolong Can you please rebase and push an empty commit so that we get a CI run?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] joshelser commented on pull request #49: RATIS-792. NPE. ServerOpts.metaQuorum should be required
Posted by GitBox <gi...@apache.org>.
joshelser commented on pull request #49:
URL: https://github.com/apache/incubator-ratis/pull/49#issuecomment-638505087
I think this is fine. You do any testing with this change, @maobaolong ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org