[GitHub] [incubator-echarts] Ovilia commented on a change in pull request #10441: Correct subtext textAlign, add 'x', 'y' option to subtextStyle

[GitBox <gi...@apache.org>]

Ovilia commented on a change in pull request #10441: Correct subtext textAlign, add 'x', 'y' option to subtextStyle  
URL: https://github.com/apache/incubator-echarts/pull/10441#discussion_r287236863
 
 

 ##########
 File path: src/component/title.js
 ##########
 @@ -127,8 +128,9 @@ echarts.extendComponentView({
         var subTextEl = new graphic.Text({
             style: graphic.setTextStyle({}, subtextStyleModel, {
                 text: subText,
+                x: subtextStyleModel.get('x'),
 
 Review comment:
   Are `x` and `y` attributes you add? Are they used for setting subtitle to be a different position to the title? In this case, I think `x` and `y` should be an absolute value, rather than the position relative to the title.
   My suggestion is, when user has to set title and subtitle for totally different positions, they should use an array of titles for them. So there's no need to provide new attributes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org