You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/04/11 03:49:24 UTC
[kudu-CR] KUDU-3078: paramterize ts sentry-itest to use Ranger
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15714
Change subject: KUDU-3078: paramterize ts_sentry-itest to use Ranger
......................................................................
KUDU-3078: paramterize ts_sentry-itest to use Ranger
Following the example set in dacb8203f05ca2d873d524501214bfe5144ac9bb,
this updates the test harness in ts_sentry-itest to be parameterized by
authz provider.
Change-Id: I2232cfe0295cce83154cd01b5104c9d1b6ed955d
---
M src/kudu/integration-tests/CMakeLists.txt
R src/kudu/integration-tests/ts_authz-itest.cc
2 files changed, 259 insertions(+), 88 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/15714/1
--
To view, visit http://gerrit.cloudera.org:8080/15714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2232cfe0295cce83154cd01b5104c9d1b6ed955d
Gerrit-Change-Number: 15714
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] KUDU-3078: parameterize ts sentry-itest to use Ranger
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15714 )
Change subject: KUDU-3078: parameterize ts_sentry-itest to use Ranger
......................................................................
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/15714/4/src/kudu/integration-tests/ts_authz-itest.cc
File src/kudu/integration-tests/ts_authz-itest.cc:
http://gerrit.cloudera.org:8080/#/c/15714/4/src/kudu/integration-tests/ts_authz-itest.cc@269
PS4, Line 269: // Test harness used to se
> nit: add a short description for this test harness?
Done
http://gerrit.cloudera.org:8080/#/c/15714/4/src/kudu/integration-tests/ts_authz-itest.cc@301
PS4, Line 301: virtual Status SetUpTables() = 0;
> nit: we may want to call it out by granting table level privilege, column l
Done
http://gerrit.cloudera.org:8080/#/c/15714/4/src/kudu/integration-tests/ts_authz-itest.cc@692
PS4, Line 692: r->AddColumn(another_column)->Typ
> No such behavior exists in Ranger with short polling intervals in Ranger cl
Done
--
To view, visit http://gerrit.cloudera.org:8080/15714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2232cfe0295cce83154cd01b5104c9d1b6ed955d
Gerrit-Change-Number: 15714
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 13 Apr 2020 06:12:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3078: parameterize ts sentry-itest to use Ranger
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15714 )
Change subject: KUDU-3078: parameterize ts_sentry-itest to use Ranger
......................................................................
Patch Set 4: Code-Review+2
(3 comments)
LGTM, just a few nits.
http://gerrit.cloudera.org:8080/#/c/15714/4/src/kudu/integration-tests/ts_authz-itest.cc
File src/kudu/integration-tests/ts_authz-itest.cc:
http://gerrit.cloudera.org:8080/#/c/15714/4/src/kudu/integration-tests/ts_authz-itest.cc@269
PS4, Line 269: class TSAuthzITestHarness
nit: add a short description for this test harness?
http://gerrit.cloudera.org:8080/#/c/15714/4/src/kudu/integration-tests/ts_authz-itest.cc@301
PS4, Line 301: virtual Status GrantTablePrivilege
nit: we may want to call it out by granting table level privilege, column level privilege is also granted for Sentry and Ranger.
http://gerrit.cloudera.org:8080/#/c/15714/4/src/kudu/integration-tests/ts_authz-itest.cc@692
PS4, Line 692: No such behavior exists in Ranger
No such behavior exists in Ranger with short polling intervals in Ranger client?
--
To view, visit http://gerrit.cloudera.org:8080/15714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2232cfe0295cce83154cd01b5104c9d1b6ed955d
Gerrit-Change-Number: 15714
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 13 Apr 2020 05:47:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3078: paramterize ts sentry-itest to use Ranger
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15714
to look at the new patch set (#3).
Change subject: KUDU-3078: paramterize ts_sentry-itest to use Ranger
......................................................................
KUDU-3078: paramterize ts_sentry-itest to use Ranger
Following the example set in dacb8203f05ca2d873d524501214bfe5144ac9bb,
this updates the test harness in ts_sentry-itest to be parameterized by
authz provider.
Change-Id: I2232cfe0295cce83154cd01b5104c9d1b6ed955d
---
M src/kudu/integration-tests/CMakeLists.txt
R src/kudu/integration-tests/ts_authz-itest.cc
2 files changed, 213 insertions(+), 87 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/15714/3
--
To view, visit http://gerrit.cloudera.org:8080/15714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2232cfe0295cce83154cd01b5104c9d1b6ed955d
Gerrit-Change-Number: 15714
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3078: parameterize ts sentry-itest to use Ranger
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15714 )
Change subject: KUDU-3078: parameterize ts_sentry-itest to use Ranger
......................................................................
KUDU-3078: parameterize ts_sentry-itest to use Ranger
Following the example set in dacb8203f05ca2d873d524501214bfe5144ac9bb,
this updates the test harness in ts_sentry-itest (now ts_authz-itest) to
be parameterized by authz provider.
Change-Id: I2232cfe0295cce83154cd01b5104c9d1b6ed955d
Reviewed-on: http://gerrit.cloudera.org:8080/15714
Reviewed-by: Hao Hao <ha...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/CMakeLists.txt
R src/kudu/integration-tests/ts_authz-itest.cc
2 files changed, 247 insertions(+), 92 deletions(-)
Approvals:
Hao Hao: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2232cfe0295cce83154cd01b5104c9d1b6ed955d
Gerrit-Change-Number: 15714
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-3078: parameterize ts sentry-itest to use Ranger
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15714
to look at the new patch set (#5).
Change subject: KUDU-3078: parameterize ts_sentry-itest to use Ranger
......................................................................
KUDU-3078: parameterize ts_sentry-itest to use Ranger
Following the example set in dacb8203f05ca2d873d524501214bfe5144ac9bb,
this updates the test harness in ts_sentry-itest (now ts_authz-itest) to
be parameterized by authz provider.
Change-Id: I2232cfe0295cce83154cd01b5104c9d1b6ed955d
---
M src/kudu/integration-tests/CMakeLists.txt
R src/kudu/integration-tests/ts_authz-itest.cc
2 files changed, 247 insertions(+), 92 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/15714/5
--
To view, visit http://gerrit.cloudera.org:8080/15714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2232cfe0295cce83154cd01b5104c9d1b6ed955d
Gerrit-Change-Number: 15714
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-3078: parameterize ts sentry-itest to use Ranger
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15714 )
Change subject: KUDU-3078: parameterize ts_sentry-itest to use Ranger
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2232cfe0295cce83154cd01b5104c9d1b6ed955d
Gerrit-Change-Number: 15714
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 13 Apr 2020 06:21:36 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3078: paramterize ts sentry-itest to use Ranger
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15714
to look at the new patch set (#2).
Change subject: KUDU-3078: paramterize ts_sentry-itest to use Ranger
......................................................................
KUDU-3078: paramterize ts_sentry-itest to use Ranger
Following the example set in dacb8203f05ca2d873d524501214bfe5144ac9bb,
this updates the test harness in ts_sentry-itest to be parameterized by
authz provider.
Change-Id: I2232cfe0295cce83154cd01b5104c9d1b6ed955d
---
M src/kudu/integration-tests/CMakeLists.txt
R src/kudu/integration-tests/ts_authz-itest.cc
2 files changed, 251 insertions(+), 90 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/15714/2
--
To view, visit http://gerrit.cloudera.org:8080/15714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2232cfe0295cce83154cd01b5104c9d1b6ed955d
Gerrit-Change-Number: 15714
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3078: parameterize ts sentry-itest to use Ranger
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15714
to look at the new patch set (#4).
Change subject: KUDU-3078: parameterize ts_sentry-itest to use Ranger
......................................................................
KUDU-3078: parameterize ts_sentry-itest to use Ranger
Following the example set in dacb8203f05ca2d873d524501214bfe5144ac9bb,
this updates the test harness in ts_sentry-itest (now ts_authz-itest) to
be parameterized by authz provider.
Change-Id: I2232cfe0295cce83154cd01b5104c9d1b6ed955d
---
M src/kudu/integration-tests/CMakeLists.txt
R src/kudu/integration-tests/ts_authz-itest.cc
2 files changed, 241 insertions(+), 92 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/15714/4
--
To view, visit http://gerrit.cloudera.org:8080/15714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2232cfe0295cce83154cd01b5104c9d1b6ed955d
Gerrit-Change-Number: 15714
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)