You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/08/04 03:15:29 UTC
[GitHub] [dubbo-go] zhaoyunxing92 commented on a diff in pull request #2003: Fix(#1974):fix shotdown InternalSignal default value
zhaoyunxing92 commented on code in PR #2003:
URL: https://github.com/apache/dubbo-go/pull/2003#discussion_r937309916
##########
config/graceful_shutdown_config.go:
##########
@@ -157,7 +157,7 @@ func (scb *ShutdownConfigBuilder) SetRejectRequest(rejectRequest bool) *Shutdown
}
func (scb *ShutdownConfigBuilder) SetInternalSignal(internalSignal bool) *ShutdownConfigBuilder {
- scb.shutdownConfig.InternalSignal = internalSignal
+ scb.shutdownConfig.InternalSignal = &internalSignal
Review Comment:
应该不需要，没有并发的场景
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org