You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "yesamer (via GitHub)" <gi...@apache.org> on 2024/02/19 15:11:37 UTC
[PR] kie-issues#717: mvn package throws an exception in Kogito project in Microsoft Windows machines with `quarkus.package.type=uber-jar` [incubator-kie-drools]
yesamer opened a new pull request, #5694:
URL: https://github.com/apache/incubator-kie-drools/pull/5694
Closes: https://github.com/apache/incubator-kie-issues/issues/717
Description in progress
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#717] mvn package throws an exception in Kogito project in Microsoft Windows machines with `quarkus.package.type=uber-jar` [incubator-kie-drools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer merged PR #5694:
URL: https://github.com/apache/incubator-kie-drools/pull/5694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#717] mvn package throws an exception in Kogito project in Microsoft Windows machines with `quarkus.package.type=uber-jar` [incubator-kie-drools]
Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on PR #5694:
URL: https://github.com/apache/incubator-kie-drools/pull/5694#issuecomment-1953684459
Thanks @yesamer
I'm slightly doubtful here:
First, this fix has an impact only on windows, IINW.
Then there is
`public static final String META_INF_RESOURCES = "META-INF/resources/";`
If `path` parameter starts with the above, then `pathAsString` is used as it is (and transformed by your code).
```
if (path.startsWith(META_INF_RESOURCES)) {
LOGGER.warn("STATIC_HTTP_RESOURCE is automatically placed under " + META_INF_RESOURCES + ". You don't need to specify the directory : {}", path);
```
But if `path` fullfill the above, then it already is "posix" formatted, (I think).
In the other case, the `pathAsString` parameter is completely overwrote
```
else {
path = META_INF_RESOURCES_PATH.resolve(path);
pathAsString = path.toString();
}
```
So, I have the following doubts:
1. if `Path path` parameter is given with "windows" format, the code does not enter the `if` but it goes on the `else` (which seems wrong)
2. that fix may be needed because the `Path path` parameter is in posix format, but the `String pathAsString` is not
Does this make sense ? Am I wrong ?
@baldimir ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org