[GitHub] [pulsar] codelipenghui commented on a change in pull request #13969: [Transaction] Adopt Single_thread to handle TcClient connecting

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #13969:
URL: https://github.com/apache/pulsar/pull/13969#discussion_r801775937



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/TransactionMetadataStoreService.java
##########
@@ -98,6 +100,7 @@ public TransactionMetadataStoreService(TransactionMetadataStoreProvider transact
         this.transactionOpRetryTimer = timer;
         this.tcLoadSemaphores = new ConcurrentLongHashMap<>();
         this.pendingConnectRequests = new ConcurrentLongHashMap<>();
+        this.internalPinnedExecutor = pulsarService.getTransactionExecutorProvider().getExecutor(this);

Review comment:
       The TransactionExecutorProvider also be used by Transaction Buffer Recovery, this will create risks for TC which is not able to get CPU cycles to process transactions of other topics, I think we should consider using a separate executor provider for TC, and for TB, make sure one topic using the same thread.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org