You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Norman Maurer (JIRA)" <se...@james.apache.org> on 2006/05/30 10:47:31 UTC
[jira] Created: (JAMES-513) Rename AddHeader and AddHeaderHandler
Rename AddHeader and AddHeaderHandler
-------------------------------------
Key: JAMES-513
URL: http://issues.apache.org/jira/browse/JAMES-513
Project: James
Type: Task
Reporter: Norman Maurer
We should rename AddHeader and AddHeaderHandler to represent the function.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-513) Rename AddHeader and AddHeaderHandler
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-513?page=comments#action_12413785 ]
Norman Maurer commented on JAMES-513:
-------------------------------------
To clarify my position:
+1 to deprecate the AddHeader and add a new Set*Header
+0.6 to name it SetMimeHeader
+0.4 to name it SetRfc822Header (most correct, but less intelligible
to non techies)
+0.2 to name it SetHeader
Furthermore
+1 to do that in the 2.3 branch and remove AddHeader from the trunk
Stefano
> Rename AddHeader and AddHeaderHandler
> -------------------------------------
>
> Key: JAMES-513
> URL: http://issues.apache.org/jira/browse/JAMES-513
> Project: James
> Type: Task
> Reporter: Norman Maurer
>
> We should rename AddHeader and AddHeaderHandler to represent the function.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-513) Rename AddHeader and AddHeaderHandler
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-513?page=comments#action_12413783 ]
Norman Maurer commented on JAMES-513:
-------------------------------------
when working on junit test for AddHeaderHandler i notice that the
AddHeaderHandler use setHeader(String name, String value); . So it not
add a header, it set a header. This is not what i espected when i read
the Handlername.
So for me are 2 solutions:
1. Rename the AddHeaderHandler to SetHeaderHandler
2. use addHeader(String name, String value) instand of setHeader(String
name, String value)
i prefer the first. What the you think ?
> Rename AddHeader and AddHeaderHandler
> -------------------------------------
>
> Key: JAMES-513
> URL: http://issues.apache.org/jira/browse/JAMES-513
> Project: James
> Type: Task
> Reporter: Norman Maurer
>
> We should rename AddHeader and AddHeaderHandler to represent the function.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (JAMES-513) Rename AddHeader and AddHeaderHandler
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-513?page=all ]
Norman Maurer updated JAMES-513:
--------------------------------
Fix Version: 2.3.0a4
> Rename AddHeader and AddHeaderHandler
> -------------------------------------
>
> Key: JAMES-513
> URL: http://issues.apache.org/jira/browse/JAMES-513
> Project: James
> Type: Task
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 2.4.0, 2.3.0a4
>
> We should rename AddHeader and AddHeaderHandler to represent the function.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Assigned: (JAMES-513) Rename AddHeader and AddHeaderHandler
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-513?page=all ]
Norman Maurer reassigned JAMES-513:
-----------------------------------
Assign To: Norman Maurer
> Rename AddHeader and AddHeaderHandler
> -------------------------------------
>
> Key: JAMES-513
> URL: http://issues.apache.org/jira/browse/JAMES-513
> Project: James
> Type: Task
> Reporter: Norman Maurer
> Assignee: Norman Maurer
>
> We should rename AddHeader and AddHeaderHandler to represent the function.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-513) Rename AddHeader and AddHeaderHandler
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-513?page=comments#action_12413784 ]
Norman Maurer commented on JAMES-513:
-------------------------------------
Maybe we should rename the AddHeader to SetHeader and add new Method
which extend on this named AddHeader. This method should be marked as
deprected. Then we can later remove it.
Same to the handler.
What you guys think ?
> Rename AddHeader and AddHeaderHandler
> -------------------------------------
>
> Key: JAMES-513
> URL: http://issues.apache.org/jira/browse/JAMES-513
> Project: James
> Type: Task
> Reporter: Norman Maurer
>
> We should rename AddHeader and AddHeaderHandler to represent the function.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (JAMES-513) Rename AddHeader and AddHeaderHandler
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-513?page=all ]
Stefano Bagnara updated JAMES-513:
----------------------------------
Fix Version/s: (was: 3.0)
Affects Version/s: 2.3.0a3
> Rename AddHeader and AddHeaderHandler
> -------------------------------------
>
> Key: JAMES-513
> URL: http://issues.apache.org/jira/browse/JAMES-513
> Project: James
> Issue Type: Task
> Affects Versions: 2.3.0a3
> Reporter: Norman Maurer
> Assigned To: Norman Maurer
> Fix For: 2.3.0b1
>
>
> We should rename AddHeader and AddHeaderHandler to represent the function.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Resolved: (JAMES-513) Rename AddHeader and AddHeaderHandler
Posted by Stefano Bagnara <ap...@bago.org>.
Norman Maurer (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/JAMES-513?page=all ]
>
> Norman Maurer resolved JAMES-513:
> ---------------------------------
>
> Fix Version: 2.4.0
> Resolution: Fixed
>
> Should we merge it in the branch so we can remove the old classes in 2.4/3.0 ?
+1 to merge this to 2.3 and remove AddHeader* from trunk
Stefano
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Resolved: (JAMES-513) Rename AddHeader and AddHeaderHandler
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-513?page=all ]
Norman Maurer resolved JAMES-513:
---------------------------------
Fix Version: 2.4.0
Resolution: Fixed
Should we merge it in the branch so we can remove the old classes in 2.4/3.0 ?
> Rename AddHeader and AddHeaderHandler
> -------------------------------------
>
> Key: JAMES-513
> URL: http://issues.apache.org/jira/browse/JAMES-513
> Project: James
> Type: Task
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 2.4.0
>
> We should rename AddHeader and AddHeaderHandler to represent the function.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org