[GitHub] [spark] Hisoka-X commented on pull request #41808: [SPARK-44162][CORE] Support G1GC in spark metrics

["Hisoka-X (via GitHub)" <gi...@apache.org>]

Hisoka-X commented on PR #41808:
URL: https://github.com/apache/spark/pull/41808#issuecomment-1615566541

   @dongjoon-hyun Hi, I follow the guide to regenerated the test file in https://github.com/apache/spark/tree/master/core/src/test/resources/HistoryServerExpectations by `HistoryServerSuite::main`, many json style changed. Seem like other developer like change test file manually, not regenerate it. Should I revert these change or keep it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org