You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2022/04/13 08:46:30 UTC

[Impala-ASF-CR] IMPALA-11241: Mark test statement expression limit as serialized

Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18411


Change subject: IMPALA-11241: Mark test_statement_expression_limit as serialized
......................................................................

IMPALA-11241: Mark test_statement_expression_limit as serialized

This test takes ~2GB of JVM heap and is a likely cause of some
OOM during EE tests.

Change-Id: I4868eab51bf16e1ca6e0b4e98d7929195cd73803
---
M tests/query_test/test_exprs.py
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/18411/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4868eab51bf16e1ca6e0b4e98d7929195cd73803
Gerrit-Change-Number: 18411
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>

[Impala-ASF-CR] IMPALA-11241: Mark test statement expression limit as serialized

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18411 )

Change subject: IMPALA-11241: Mark test_statement_expression_limit as serialized
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10437/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4868eab51bf16e1ca6e0b4e98d7929195cd73803
Gerrit-Change-Number: 18411
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Apr 2022 09:06:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11241: Mark test statement expression limit as serialized

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18411 )

Change subject: IMPALA-11241: Mark test_statement_expression_limit as serialized
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4868eab51bf16e1ca6e0b4e98d7929195cd73803
Gerrit-Change-Number: 18411
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 13 Apr 2022 09:10:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11241: Mark test statement expression limit as serialized

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18411 )

Change subject: IMPALA-11241: Mark test_statement_expression_limit as serialized
......................................................................

IMPALA-11241: Mark test_statement_expression_limit as serialized

This test takes ~2GB of JVM heap and is a likely cause of some
OOM during EE tests.

Change-Id: I4868eab51bf16e1ca6e0b4e98d7929195cd73803
Reviewed-on: http://gerrit.cloudera.org:8080/18411
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Csaba Ringhofer <cs...@cloudera.com>
---
M tests/query_test/test_exprs.py
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Quanlong Huang: Looks good to me, approved
  Csaba Ringhofer: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4868eab51bf16e1ca6e0b4e98d7929195cd73803
Gerrit-Change-Number: 18411
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11241: Mark test statement expression limit as serialized

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18411 )

Change subject: IMPALA-11241: Mark test_statement_expression_limit as serialized
......................................................................


Patch Set 1: Verified+1

Submitting this simple change manually.


-- 
To view, visit http://gerrit.cloudera.org:8080/18411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4868eab51bf16e1ca6e0b4e98d7929195cd73803
Gerrit-Change-Number: 18411
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 13 Apr 2022 09:20:21 +0000
Gerrit-HasComments: No