You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "TylerBrinks (via GitHub)" <gi...@apache.org> on 2025/02/07 15:40:38 UTC
[I] Unable to parse 'max' for optional precision column with MS Sql dialect [datafusion-sqlparser-rs]
TylerBrinks opened a new issue, #1714:
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1714
The following is a valid MS Sql query, but cannot ne parsed due to the `varbinary` implementation.
Variable character-based columns, `nvarchar` and `varchar`, use a union type `CharacterLength` type that allows for either `IntegerLength` or `Max` values. The `varbinary` implementation needs a similar union, such as `BinaryLength` (reusing `CharacterLength` seems to have a naming mismatch).
#[test]
fn parse_ms_sql_varbinary_max(){
let sql = "CREATE TABLE example(VarBinaryMaxCol varbinary(max) not null);";
let parsed = ms().parse_sql_statements(sql);
assert!(parsed.is_ok());
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Unable to parse 'max' for optional precision column with MS Sql dialect [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 commented on issue #1714:
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1714#issuecomment-5779524707
Closing as completed by https://github.com/apache/datafusion-sqlparser-rs/pull/1715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Unable to parse 'max' for optional precision column with MS Sql dialect [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 closed issue #1714: Unable to parse 'max' for optional precision column with MS Sql dialect
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org