You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "alex-plekhanov (via GitHub)" <gi...@apache.org> on 2026/03/13 14:19:34 UTC
[PR] IGNITE-28219 Control utility: Add events control commands [ignite]
alex-plekhanov opened a new pull request, #12887:
URL: https://github.com/apache/ignite/pull/12887
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see tab `PR Check` at [TC.Bot - Instance 1](https://tcbot2.sbt-ignite-dev.ru/prs.html) or [TC.Bot - Instance 2](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28219 Control utility: Add events control commands [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12887:
URL: https://github.com/apache/ignite/pull/12887#issuecomment-4091426421
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/management/event/EventCommandArg.java`
- `modules/core/src/main/java/org/apache/ignite/internal/management/event/EventListCommandArg.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28219 Control utility: Add events control commands [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12887:
URL: https://github.com/apache/ignite/pull/12887#issuecomment-4119524377
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/management/event/EventCommandArg.java`
- `modules/core/src/main/java/org/apache/ignite/internal/management/event/EventListCommandArg.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28219 Control utility: Add events control commands [ignite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #12887:
URL: https://github.com/apache/ignite/pull/12887#issuecomment-4096473221
## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12887) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=12887&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=12887&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=12887&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=12887&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=12887&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12887)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28219 Control utility: Add events control commands [ignite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #12887:
URL: https://github.com/apache/ignite/pull/12887#issuecomment-4132950145
## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12887) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=12887&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=12887&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=12887&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=12887&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=12887&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12887)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28219 Control utility: Add events control commands [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12887:
URL: https://github.com/apache/ignite/pull/12887#issuecomment-4096415302
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/management/event/EventCommandArg.java`
- `modules/core/src/main/java/org/apache/ignite/internal/management/event/EventListCommandArg.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28219 Control utility: Add events control commands [ignite]
Posted by "asf-gitbox-commits (via GitHub)" <gi...@apache.org>.
asf-gitbox-commits closed pull request #12887: IGNITE-28219 Control utility: Add events control commands
URL: https://github.com/apache/ignite/pull/12887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28219 Control utility: Add events control commands [ignite]
Posted by "alex-plekhanov (via GitHub)" <gi...@apache.org>.
alex-plekhanov commented on code in PR #12887:
URL: https://github.com/apache/ignite/pull/12887#discussion_r2986714898
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/eventstorage/GridEventStorageManager.java:
##########
@@ -1163,6 +1160,52 @@ private int[] copy(int[] arr) {
return Arrays.copyOf(arr, arr.length);
}
+ /** {@inheritDoc} */
+ @Override public DiscoveryDataExchangeType discoveryDataType() {
+ return DiscoveryDataExchangeType.EVENT_MGR;
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onGridDataReceived(DiscoveryDataBag.GridDiscoveryData data) {
+ if (data.commonData() == null)
+ return;
+
+ if (ctx.clientNode())
+ return;
+
+ GridIntList clusterData = new GridIntList((int[])data.commonData());
+ GridIntList nodeData = new GridIntList(enabledEvents());
+
+ GridIntList toEnable = new GridIntList(clusterData.size());
+ GridIntList toDisable = new GridIntList(nodeData.size());
+
+ for (int i = 0; i < clusterData.size(); i++) {
+ if (!nodeData.contains(clusterData.get(i)))
+ toEnable.add(clusterData.get(i));
+ }
+
+ for (int i = 0; i < nodeData.size(); i++) {
+ if (!clusterData.contains(nodeData.get(i)))
+ toDisable.add(nodeData.get(i));
+ }
+
+ if (!toEnable.isEmpty())
+ enableEvents(toEnable.arrayCopy());
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28219 Control utility: Add events control commands [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12887:
URL: https://github.com/apache/ignite/pull/12887#issuecomment-4132901322
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/management/event/EventCommandArg.java`
- `modules/core/src/main/java/org/apache/ignite/internal/management/event/EventListCommandArg.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28219 Control utility: Add events control commands [ignite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #12887:
URL: https://github.com/apache/ignite/pull/12887#issuecomment-4091476370
## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12887) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=12887&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=12887&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=12887&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=12887&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=12887&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12887)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28219 Control utility: Add events control commands [ignite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #12887:
URL: https://github.com/apache/ignite/pull/12887#issuecomment-4124118906
## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12887) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=12887&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=12887&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=12887&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=12887&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=12887&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12887)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28219 Control utility: Add events control commands [ignite]
Posted by "petrov-mg (via GitHub)" <gi...@apache.org>.
petrov-mg commented on code in PR #12887:
URL: https://github.com/apache/ignite/pull/12887#discussion_r2964188545
##########
modules/core/src/main/java/org/apache/ignite/internal/management/event/EventListCommandArg.java:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.management.event;
+
+import org.apache.ignite.internal.Order;
+import org.apache.ignite.internal.dto.IgniteDataTransferObject;
+import org.apache.ignite.internal.management.api.Argument;
+
+/** */
+public class EventListCommandArg extends IgniteDataTransferObject {
+ /** */
+ private static final long serialVersionUID = 0;
+
+ /** */
+ @Order(0)
+ @Argument(
+ optional = true,
+ description = "Only enabled events")
Review Comment:
Only enabled events -> Filter only enabled events
##########
docs/_docs/tools/control-script.adoc:
##########
@@ -1628,3 +1628,55 @@ Parameters:
|--node-id | A list of nodes to rebuild indexes on. If not specified, schedules rebuild on all nodes.
|--cache-names | Comma-separated list of cache names, optionally with indexes. If indexes are not specified, all indexes of the cache will be scheduled for the rebuild operation. Can be used simultaneously with cache group names.
|--group-names | Comma-separated list of cache group names. Can be used simultaneously with cache names.
+
+
+== Events management
+
+The control utility provides commands to enable events, disable events, check the status of events on all server nodes.
Review Comment:
The control utility provides commands to enable events, disable events, check the status of events on all server nodes. -> The control utility provides commands to enable, disable and check the status of events on all server nodes.
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/eventstorage/GridEventStorageManager.java:
##########
@@ -1163,6 +1160,52 @@ private int[] copy(int[] arr) {
return Arrays.copyOf(arr, arr.length);
}
+ /** {@inheritDoc} */
+ @Override public DiscoveryDataExchangeType discoveryDataType() {
+ return DiscoveryDataExchangeType.EVENT_MGR;
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onGridDataReceived(DiscoveryDataBag.GridDiscoveryData data) {
+ if (data.commonData() == null)
+ return;
+
+ if (ctx.clientNode())
+ return;
+
+ GridIntList clusterData = new GridIntList((int[])data.commonData());
+ GridIntList nodeData = new GridIntList(enabledEvents());
+
+ GridIntList toEnable = new GridIntList(clusterData.size());
+ GridIntList toDisable = new GridIntList(nodeData.size());
+
+ for (int i = 0; i < clusterData.size(); i++) {
+ if (!nodeData.contains(clusterData.get(i)))
+ toEnable.add(clusterData.get(i));
+ }
+
+ for (int i = 0; i < nodeData.size(); i++) {
+ if (!clusterData.contains(nodeData.get(i)))
+ toDisable.add(nodeData.get(i));
+ }
+
+ if (!toEnable.isEmpty())
+ enableEvents(toEnable.arrayCopy());
Review Comment:
It does not look like a good idea to use enableEvents/disableEvents here. Doing so would trigger EVENTS_ENABLE/EVENTS_DISABLE authorization checks during the node joining process, which is unrelated to user-initiated operations.
##########
docs/_docs/tools/control-script.adoc:
##########
@@ -1628,3 +1628,55 @@ Parameters:
|--node-id | A list of nodes to rebuild indexes on. If not specified, schedules rebuild on all nodes.
|--cache-names | Comma-separated list of cache names, optionally with indexes. If indexes are not specified, all indexes of the cache will be scheduled for the rebuild operation. Can be used simultaneously with cache group names.
|--group-names | Comma-separated list of cache group names. Can be used simultaneously with cache names.
+
+
+== Events management
Review Comment:
Events management -> Event management
##########
docs/_docs/tools/control-script.adoc:
##########
@@ -1628,3 +1628,55 @@ Parameters:
|--node-id | A list of nodes to rebuild indexes on. If not specified, schedules rebuild on all nodes.
|--cache-names | Comma-separated list of cache names, optionally with indexes. If indexes are not specified, all indexes of the cache will be scheduled for the rebuild operation. Can be used simultaneously with cache group names.
|--group-names | Comma-separated list of cache group names. Can be used simultaneously with cache names.
+
+
+== Events management
+
+The control utility provides commands to enable events, disable events, check the status of events on all server nodes.
+
+=== Enable/disable events
+
+To eneble or disable events on all server nodes, use the `--event enable/disable` command.
Review Comment:
eneble -> enable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28219 Control utility: Add events control commands [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12887:
URL: https://github.com/apache/ignite/pull/12887#issuecomment-4124091933
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/management/event/EventCommandArg.java`
- `modules/core/src/main/java/org/apache/ignite/internal/management/event/EventListCommandArg.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28219 Control utility: Add events control commands [ignite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #12887:
URL: https://github.com/apache/ignite/pull/12887#issuecomment-4091418228
## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12887) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=12887&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=12887&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=12887&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=12887&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=12887&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12887)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28219 Control utility: Add events control commands [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12887:
URL: https://github.com/apache/ignite/pull/12887#issuecomment-4091369758
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/management/event/EventCommandArg.java`
- `modules/core/src/main/java/org/apache/ignite/internal/management/event/EventListCommandArg.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28219 Control utility: Add events control commands [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12887:
URL: https://github.com/apache/ignite/pull/12887#issuecomment-4055487448
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/management/event/EventCommandArg.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28219 Control utility: Add events control commands [ignite]
Posted by "alex-plekhanov (via GitHub)" <gi...@apache.org>.
alex-plekhanov commented on code in PR #12887:
URL: https://github.com/apache/ignite/pull/12887#discussion_r2964462194
##########
modules/core/src/main/java/org/apache/ignite/internal/management/event/EventListCommandArg.java:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.management.event;
+
+import org.apache.ignite.internal.Order;
+import org.apache.ignite.internal.dto.IgniteDataTransferObject;
+import org.apache.ignite.internal.management.api.Argument;
+
+/** */
+public class EventListCommandArg extends IgniteDataTransferObject {
+ /** */
+ private static final long serialVersionUID = 0;
+
+ /** */
+ @Order(0)
+ @Argument(
+ optional = true,
+ description = "Only enabled events")
Review Comment:
Fixed
##########
docs/_docs/tools/control-script.adoc:
##########
@@ -1628,3 +1628,55 @@ Parameters:
|--node-id | A list of nodes to rebuild indexes on. If not specified, schedules rebuild on all nodes.
|--cache-names | Comma-separated list of cache names, optionally with indexes. If indexes are not specified, all indexes of the cache will be scheduled for the rebuild operation. Can be used simultaneously with cache group names.
|--group-names | Comma-separated list of cache group names. Can be used simultaneously with cache names.
+
+
+== Events management
+
+The control utility provides commands to enable events, disable events, check the status of events on all server nodes.
+
+=== Enable/disable events
+
+To eneble or disable events on all server nodes, use the `--event enable/disable` command.
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28219 Control utility: Add events control commands [ignite]
Posted by "alex-plekhanov (via GitHub)" <gi...@apache.org>.
alex-plekhanov commented on code in PR #12887:
URL: https://github.com/apache/ignite/pull/12887#discussion_r2964461134
##########
docs/_docs/tools/control-script.adoc:
##########
@@ -1628,3 +1628,55 @@ Parameters:
|--node-id | A list of nodes to rebuild indexes on. If not specified, schedules rebuild on all nodes.
|--cache-names | Comma-separated list of cache names, optionally with indexes. If indexes are not specified, all indexes of the cache will be scheduled for the rebuild operation. Can be used simultaneously with cache group names.
|--group-names | Comma-separated list of cache group names. Can be used simultaneously with cache names.
+
+
+== Events management
Review Comment:
Fixed
##########
docs/_docs/tools/control-script.adoc:
##########
@@ -1628,3 +1628,55 @@ Parameters:
|--node-id | A list of nodes to rebuild indexes on. If not specified, schedules rebuild on all nodes.
|--cache-names | Comma-separated list of cache names, optionally with indexes. If indexes are not specified, all indexes of the cache will be scheduled for the rebuild operation. Can be used simultaneously with cache group names.
|--group-names | Comma-separated list of cache group names. Can be used simultaneously with cache names.
+
+
+== Events management
+
+The control utility provides commands to enable events, disable events, check the status of events on all server nodes.
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org