You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/12/17 07:24:00 UTC

[kudu-CR] KUDU-2612: two more scenarios for txn keepalive in client

Hello Kudu Jenkins, Andrew Wong, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16886

to look at the new patch set (#2).

Change subject: KUDU-2612: two more scenarios for txn keepalive in client
......................................................................

KUDU-2612: two more scenarios for txn keepalive in client

This patch adds two more test scenarios related to txn keepalive
messages automatically sent by Kudu C++ client.  These are to verify
the corresponding functionality of the client when TxnManager instances
are not available for short and long time intervals, where 'short' and
'long' are relative to the txn keepalive heartbeat timeout interval.

In addition, I sneaked in one small fix to avoid TSAN warnings
when running the newly introduced tests: the removed CHECK() in
Master::WaitForTxnManagerInit() isn't crucial.

Change-Id: I42988996f1ddb1cd456d289ea7e15586bd7e3dc7
---
M src/kudu/client/client-test.cc
M src/kudu/master/master.cc
2 files changed, 95 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/16886/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I42988996f1ddb1cd456d289ea7e15586bd7e3dc7
Gerrit-Change-Number: 16886
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)