You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/01 07:25:45 UTC
[GitHub] [incubator-superset] villebro opened a new pull request #10752: feat(viz): add ECharts Timeseries chart
villebro opened a new pull request #10752:
URL: https://github.com/apache/incubator-superset/pull/10752
### SUMMARY
This introduces the first officially supported ECharts-based viz plugin. The timeseries plugin supports the following features:
- Line Chart
- Bar Chart
- Area Chart
- Scatterplot Chart
In addition, the ECharts 4.x and 5.x version color schemes are added to the predefined palettes:
Last but not least, if Superset is installed alongside the `fbprophet` package, it's possible to add forecasts to the plotted timeseries. In the example below, we're sporting the recently added ECharts color scheme with weekly avocado prices in three US regions with 52 weeks of forecasts with a 80 % confidence interval:
A short recording of how changing confidence interval and stacking affects the chart (please note, these results are pre-cached; calculating the forecasts can take some time, especially if there are multiple series):
Related PRs:
- ECharts colors: https://github.com/apache-superset/superset-ui/pull/751
- ECharts chart: https://github.com/apache-superset/superset-ui/pull/737
- Prophet post transformation: https://github.com/apache/incubator-superset/pull/10324
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
FYI: @ovilia
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #10752: feat(viz): add ECharts Timeseries chart
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #10752:
URL: https://github.com/apache/incubator-superset/pull/10752#discussion_r481746498
##########
File path: superset-frontend/package.json
##########
@@ -61,47 +61,46 @@
"@babel/runtime-corejs3": "^7.8.4",
"@data-ui/sparkline": "^0.0.54",
"@emotion/core": "^10.0.28",
- "@superset-ui/chart": "^0.14.9",
- "@superset-ui/chart-composition": "^0.14.9",
- "@superset-ui/chart-controls": "^0.14.22",
- "@superset-ui/color": "^0.14.9",
- "@superset-ui/connection": "^0.14.19",
- "@superset-ui/core": "^0.14.20",
- "@superset-ui/dimension": "^0.14.9",
- "@superset-ui/legacy-plugin-chart-calendar": "^0.14.9",
- "@superset-ui/legacy-plugin-chart-chord": "^0.14.9",
- "@superset-ui/legacy-plugin-chart-country-map": "^0.14.9",
- "@superset-ui/legacy-plugin-chart-event-flow": "^0.14.9",
- "@superset-ui/legacy-plugin-chart-force-directed": "^0.14.9",
- "@superset-ui/legacy-plugin-chart-heatmap": "^0.14.9",
- "@superset-ui/legacy-plugin-chart-histogram": "^0.14.9",
- "@superset-ui/legacy-plugin-chart-horizon": "^0.14.9",
- "@superset-ui/legacy-plugin-chart-iframe": "^0.14.9",
- "@superset-ui/legacy-plugin-chart-map-box": "^0.14.9",
- "@superset-ui/legacy-plugin-chart-markup": "^0.14.9",
Review comment:
Bycatch: `legacy-plugin-chart-iframe` and `legacy-plugin-chart-markup` are removed here as per #10590
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #10752: feat(viz): add ECharts Timeseries chart
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #10752:
URL: https://github.com/apache/incubator-superset/pull/10752
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10752: feat(viz): add ECharts Timeseries chart
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10752:
URL: https://github.com/apache/incubator-superset/pull/10752#issuecomment-684523867
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10752?src=pr&el=h1) Report
> Merging [#10752](https://codecov.io/gh/apache/incubator-superset/pull/10752?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/807bd656c6c727d1cd4d75f65e11922b9df2c475?el=desc) will **decrease** coverage by `5.56%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10752?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10752 +/- ##
==========================================
- Coverage 64.98% 59.42% -5.57%
==========================================
Files 789 360 -429
Lines 37179 23212 -13967
Branches 3555 0 -3555
==========================================
- Hits 24161 13793 -10368
+ Misses 12911 9419 -3492
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `59.42% <ø> (-0.87%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10752?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10752/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10752/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10752/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10752/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10752/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-10.77%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/10752/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/10752/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `94.18% <0.00%> (-4.07%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10752/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10752/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.55% <0.00%> (-2.78%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10752/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `85.18% <0.00%> (-2.78%)` | :arrow_down: |
| ... and [439 more](https://codecov.io/gh/apache/incubator-superset/pull/10752/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10752?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10752?src=pr&el=footer). Last update [807bd65...f2b4ffd](https://codecov.io/gh/apache/incubator-superset/pull/10752?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org