You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2018/04/04 23:58:57 UTC
Review Request 66462: Added new operation states to be used for status
reconciliation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66462/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Repository: mesos
Description
-------
Added new operation states to be used for status reconciliation.
Diffs
-----
include/mesos/mesos.proto 676f0b090cad7ebf59eb32556f17ff8b5f247907
include/mesos/v1/mesos.proto 10d506517c9f098374ab0c8f4dcfda42e1896c95
src/common/protobuf_utils.cpp 141a444534b776a2c90e2a0daf9727cd21e39080
src/master/master.cpp 18382fa93fd0c59e641e00f2028ac1ae2e67c01c
src/slave/slave.cpp b17854788ceb63f3748380c546a13531e86f0dda
Diff: https://reviews.apache.org/r/66462/diff/1/
Testing
-------
`sudo bin/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 66462: Added new operation states to be used for
status reconciliation.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66462/#review200834
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/mesos.proto
Lines 2314 (patched)
<https://reviews.apache.org/r/66462/#comment281738>
s/being applied/pending/
include/mesos/mesos.proto
Lines 2322 (patched)
<https://reviews.apache.org/r/66462/#comment281740>
s/when/if/
- Greg Mann
On April 4, 2018, 11:58 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66462/
> -----------------------------------------------------------
>
> (Updated April 4, 2018, 11:58 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added new operation states to be used for status reconciliation.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 676f0b090cad7ebf59eb32556f17ff8b5f247907
> include/mesos/v1/mesos.proto 10d506517c9f098374ab0c8f4dcfda42e1896c95
> src/common/protobuf_utils.cpp 141a444534b776a2c90e2a0daf9727cd21e39080
> src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8
> src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5
>
>
> Diff: https://reviews.apache.org/r/66462/diff/2/
>
>
> Testing
> -------
>
> `sudo bin/mesos-tests` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 66462: Added new operation states to be used for
status reconciliation.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
> On April 11, 2018, 7:06 p.m., Chun-Hung Hsiao wrote:
> > Are all of these necessary for now?
Yeah, they are all generated/sent by the {{ReconcileOperations}} handler.
> On April 11, 2018, 7:06 p.m., Chun-Hung Hsiao wrote:
> > src/slave/slave.cpp
> > Lines 8034-8038 (patched)
> > <https://reviews.apache.org/r/66462/diff/3/?file=1996019#file1996019line8035>
> >
> > Move these outside the block.
lol, good catch, thanks!!!
- Gaston
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66462/#review200957
-----------------------------------------------------------
On April 11, 2018, 10:58 a.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66462/
> -----------------------------------------------------------
>
> (Updated April 11, 2018, 10:58 a.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added new operation states to be used for status reconciliation.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 676f0b090cad7ebf59eb32556f17ff8b5f247907
> include/mesos/v1/mesos.proto 10d506517c9f098374ab0c8f4dcfda42e1896c95
> src/common/protobuf_utils.cpp 141a444534b776a2c90e2a0daf9727cd21e39080
> src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8
> src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5
>
>
> Diff: https://reviews.apache.org/r/66462/diff/3/
>
>
> Testing
> -------
>
> `sudo bin/mesos-tests` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 66462: Added new operation states to be used for
status reconciliation.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66462/#review200957
-----------------------------------------------------------
Are all of these necessary for now?
src/slave/slave.cpp
Lines 8034-8038 (patched)
<https://reviews.apache.org/r/66462/#comment281872>
Move these outside the block.
- Chun-Hung Hsiao
On April 11, 2018, 5:58 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66462/
> -----------------------------------------------------------
>
> (Updated April 11, 2018, 5:58 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added new operation states to be used for status reconciliation.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 676f0b090cad7ebf59eb32556f17ff8b5f247907
> include/mesos/v1/mesos.proto 10d506517c9f098374ab0c8f4dcfda42e1896c95
> src/common/protobuf_utils.cpp 141a444534b776a2c90e2a0daf9727cd21e39080
> src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8
> src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5
>
>
> Diff: https://reviews.apache.org/r/66462/diff/3/
>
>
> Testing
> -------
>
> `sudo bin/mesos-tests` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 66462: Added new operation states to be used for
status reconciliation.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66462/
-----------------------------------------------------------
(Updated April 20, 2018, 3:53 p.m.)
Review request for mesos and Greg Mann.
Changes
-------
Rebased.
Bugs: MESOS-8191
https://issues.apache.org/jira/browse/MESOS-8191
Repository: mesos
Description
-------
Added new operation states to be used for status reconciliation.
Diffs (updated)
-----
include/mesos/mesos.proto 9e24d3ea46edc21572e9226e2e76c7d55618db24
include/mesos/v1/mesos.proto 0f3fd8a2608b5edabc21f5fe5df9b70fc0fa8dc2
src/common/protobuf_utils.cpp 141a444534b776a2c90e2a0daf9727cd21e39080
src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a
src/slave/slave.cpp 9d2d1928b231044988f1855eb518448db38ff04f
Diff: https://reviews.apache.org/r/66462/diff/5/
Changes: https://reviews.apache.org/r/66462/diff/4-5/
Testing
-------
`sudo bin/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 66462: Added new operation states to be used for
status reconciliation.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66462/
-----------------------------------------------------------
(Updated April 12, 2018, 9:59 a.m.)
Review request for mesos and Greg Mann.
Changes
-------
Addressed feedback from Chun.
Repository: mesos
Description
-------
Added new operation states to be used for status reconciliation.
Diffs (updated)
-----
include/mesos/mesos.proto 676f0b090cad7ebf59eb32556f17ff8b5f247907
include/mesos/v1/mesos.proto 10d506517c9f098374ab0c8f4dcfda42e1896c95
src/common/protobuf_utils.cpp 141a444534b776a2c90e2a0daf9727cd21e39080
src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8
src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5
Diff: https://reviews.apache.org/r/66462/diff/4/
Changes: https://reviews.apache.org/r/66462/diff/3-4/
Testing
-------
`sudo bin/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 66462: Added new operation states to be used for
status reconciliation.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66462/
-----------------------------------------------------------
(Updated April 11, 2018, 10:58 a.m.)
Review request for mesos and Greg Mann.
Changes
-------
Improved comments.
Repository: mesos
Description
-------
Added new operation states to be used for status reconciliation.
Diffs (updated)
-----
include/mesos/mesos.proto 676f0b090cad7ebf59eb32556f17ff8b5f247907
include/mesos/v1/mesos.proto 10d506517c9f098374ab0c8f4dcfda42e1896c95
src/common/protobuf_utils.cpp 141a444534b776a2c90e2a0daf9727cd21e39080
src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8
src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5
Diff: https://reviews.apache.org/r/66462/diff/3/
Changes: https://reviews.apache.org/r/66462/diff/2-3/
Testing
-------
`sudo bin/mesos-tests` on GNU/Linux
Thanks,
Gaston Kleiman