You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2023/09/26 08:30:06 UTC
[GitHub] [arrow] raulcd opened a new pull request, #37870: GH-37858: [Docs][JS] Fix check of remote URL to generate JS docs
raulcd opened a new pull request, #37870:
URL: https://github.com/apache/arrow/pull/37870
### Rationale for this change
JS Docs are currently not being generated.
### What changes are included in this PR?
Use a regex check instead of an equality to cover both remote set with `.git` and without.
### Are these changes tested?
Via archery
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #37870: GH-37858: [Docs][JS] Fix check of remote URL to generate JS docs
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #37870:
URL: https://github.com/apache/arrow/pull/37870#issuecomment-1735074373
@github-actions crossbow submit preview-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #37870: GH-37858: [Docs][JS] Fix check of remote URL to generate JS docs
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #37870:
URL: https://github.com/apache/arrow/pull/37870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #37870: GH-37858: [Docs][JS] Fix check of remote URL to generate JS docs
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #37870:
URL: https://github.com/apache/arrow/pull/37870#issuecomment-1735204823
@github-actions crossbow submit preview-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #37870: GH-37858: [Docs][JS] Fix check of remote URL to generate JS docs
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #37870:
URL: https://github.com/apache/arrow/pull/37870#issuecomment-1735435756
It seems this never worked for PRs / preview docs, I did fix that and the fix should allow to fix the doc generation now. For the preview-docs it can be seen here: http://crossbow.voltrondata.com/pr_docs/37870/js/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37870: GH-37858: [Docs][JS] Fix check of remote URL to generate JS docs
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37870:
URL: https://github.com/apache/arrow/pull/37870#issuecomment-1735073840
:warning: GitHub issue #37858 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37870: GH-37858: [Docs][JS] Fix check of remote URL to generate JS docs
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37870:
URL: https://github.com/apache/arrow/pull/37870#issuecomment-1735210450
Revision: e8ea90f67857f95abfb68845b5ea129375f9ae9b
Submitted crossbow builds: [ursacomputing/crossbow @ actions-6104c7ee44](https://github.com/ursacomputing/crossbow/branches/all?query=actions-6104c7ee44)
|Task|Status|
|----|------|
|preview-docs|[](https://github.com/ursacomputing/crossbow/actions/runs/6311004327/job/17134116197)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #37870: GH-37858: [Docs][JS] Fix check of remote URL to generate JS docs
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #37870:
URL: https://github.com/apache/arrow/pull/37870#issuecomment-1737651812
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 517d849b5813788ea23cf938629f668cba8b4fb8.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/17186049305) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #37870: GH-37858: [Docs][JS] Fix check of remote URL to generate JS docs
Posted by "domoritz (via GitHub)" <gi...@apache.org>.
domoritz commented on PR #37870:
URL: https://github.com/apache/arrow/pull/37870#issuecomment-1735560201
Awesome. Thanks for making the preview docs work as well!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #37870: GH-37858: [Docs][JS] Fix check of remote URL to generate JS docs
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #37870:
URL: https://github.com/apache/arrow/pull/37870#issuecomment-1736953034
> Sweet. Thanks for the quick fix @raulcd. I guess you need to push the generated docs to the docs repo to update https://arrow.apache.org/docs/js/, right?
Yes, I have to generate the docs from the 13.0.0 branch and create a PR to the arrow-site repo. I'm currently working on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #37870: GH-37858: [Docs][JS] Fix check of remote URL to generate JS docs
Posted by "domoritz (via GitHub)" <gi...@apache.org>.
domoritz commented on PR #37870:
URL: https://github.com/apache/arrow/pull/37870#issuecomment-1736344472
Sweet. Thanks for the quick fix @raulcd. I guess you need to push the generated docs to the docs repo to update https://arrow.apache.org/docs/js/, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37870: GH-37858: [Docs][JS] Fix check of remote URL to generate JS docs
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37870:
URL: https://github.com/apache/arrow/pull/37870#issuecomment-1735078095
Revision: 1b7b52ab2916fcb860938ef576b624797662d4f4
Submitted crossbow builds: [ursacomputing/crossbow @ actions-52a26733d4](https://github.com/ursacomputing/crossbow/branches/all?query=actions-52a26733d4)
|Task|Status|
|----|------|
|preview-docs|[](https://github.com/ursacomputing/crossbow/actions/runs/6310123189/job/17131428630)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on a diff in pull request #37870: GH-37858: [Docs][JS] Fix check of remote URL to generate JS docs
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #37870:
URL: https://github.com/apache/arrow/pull/37870#discussion_r1337123596
##########
ci/scripts/js_build.sh:
##########
@@ -32,12 +32,14 @@ yarn lint:ci
yarn build
if [ "${BUILD_DOCS_JS}" == "ON" ]; then
- if [ "$(git config --get remote.origin.url)" == "https://github.com/apache/arrow.git" ]; then
- yarn doc
- elif [ "$(git config --get remote.upstream.url)" == "https://github.com/apache/arrow.git" ]; then
- yarn doc --gitRemote upstream
- elif [ "$(git config --get remote.apache.url)" == "git@github.com:apache/arrow.git" ]; then
+ # If apache or upstream are defined use those as remote.
+ # Otherwise use origin which could be a fork on PRs.
+ if [ "$(git config --get remote.apache.url)" == "git@github.com:apache/arrow.git" ]; then
yarn doc --gitRemote apache
+ elif [[ "$(git config --get remote.upstream.url)" =~ "https://github.com/apache/arrow" ]]; then
Review Comment:
this will work with both `https://github.com/apache/arrow` and `https://github.com/apache/arrow.git`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #37870: GH-37858: [Docs][JS] Fix check of remote URL to generate JS docs
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #37870:
URL: https://github.com/apache/arrow/pull/37870#issuecomment-1737150811
The docs PR has been created there: https://github.com/apache/arrow-site/pull/412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org