You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/02/21 06:30:20 UTC

[GitHub] [incubator-doris] imay commented on a change in pull request #2961: [ut] fix the test case of SegmentReaderWriterTest::TestBitmapPredicate

imay commented on a change in pull request #2961: [ut] fix the  test case of SegmentReaderWriterTest::TestBitmapPredicate
URL: https://github.com/apache/incubator-doris/pull/2961#discussion_r382416704
 
 

 ##########
 File path: be/test/olap/tablet_schema_helper.h
 ##########
 @@ -31,6 +31,7 @@ TabletColumn create_int_key(int32_t id, bool is_nullable = true,
     column._col_name = std::to_string(id);
     column._type = OLAP_FIELD_TYPE_INT;
     column._is_key = true;
+    column._aggregation = OLAP_FIELD_AGGREGATION_NONE;
 
 Review comment:
   Better to give a default value to TabletColumn constructor.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org