You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Dan Dumont <dd...@us.ibm.com> on 2012/02/08 20:35:27 UTC
Re: Review Request: new core-gadget feature "proxied-form-post"
gadgets.proxiedMultipartFormPost
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3768/
-----------------------------------------------------------
(Updated 2012-02-08 19:35:27.423243)
Review request for shindig, Ryan Baxter and Stanton Sievers.
Changes
-------
Adding shindig to review.
Will add a test gadget soon (still adding things to it)
Summary
-------
With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.
It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.
This addresses bug SHINDIG-1695.
https://issues.apache.org/jira/browse/SHINDIG-1695
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308
http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308
Diff: https://reviews.apache.org/r/3768/diff
Testing
-------
Thanks,
Dan
Re: Review Request: new core-gadget feature "proxied-form-post"
gadgets.proxiedMultipartFormPost
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3768/#review4981
-----------------------------------------------------------
I plan on delivering this EOD tomrrow (Friday, Feb 10th) unless any interested parties request more time to review or post reviews requiring a change. Please let me know.
- Dan
On 2012-02-08 20:29:31, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3768/
> -----------------------------------------------------------
>
> (Updated 2012-02-08 20:29:31)
>
>
> Review request for shindig, Ryan Baxter and Stanton Sievers.
>
>
> Summary
> -------
>
> With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.
>
> It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.
>
>
> This addresses bug SHINDIG-1695.
> https://issues.apache.org/jira/browse/SHINDIG-1695
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/ImageUploadGadget.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308
>
> Diff: https://reviews.apache.org/r/3768/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: new core-gadget feature "proxied-form-post"
gadgets.proxiedMultipartFormPost
Posted by Jesse Ciancetta <jc...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3768/#review5011
-----------------------------------------------------------
Ship it!
LGTM
- Jesse
On 2012-02-08 20:29:31, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3768/
> -----------------------------------------------------------
>
> (Updated 2012-02-08 20:29:31)
>
>
> Review request for shindig, Ryan Baxter and Stanton Sievers.
>
>
> Summary
> -------
>
> With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.
>
> It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.
>
>
> This addresses bug SHINDIG-1695.
> https://issues.apache.org/jira/browse/SHINDIG-1695
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/ImageUploadGadget.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308
>
> Diff: https://reviews.apache.org/r/3768/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: new core-gadget feature "proxied-form-post"
gadgets.proxiedMultipartFormPost
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3768/#review5013
-----------------------------------------------------------
Ship it!
Committed r1242959
- Dan
On 2012-02-08 20:29:31, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3768/
> -----------------------------------------------------------
>
> (Updated 2012-02-08 20:29:31)
>
>
> Review request for shindig, Ryan Baxter and Stanton Sievers.
>
>
> Summary
> -------
>
> With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.
>
> It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.
>
>
> This addresses bug SHINDIG-1695.
> https://issues.apache.org/jira/browse/SHINDIG-1695
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/ImageUploadGadget.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308
>
> Diff: https://reviews.apache.org/r/3768/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: new core-gadget feature "proxied-form-post"
gadgets.proxiedMultipartFormPost
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3768/
-----------------------------------------------------------
(Updated 2012-02-08 20:29:31.024305)
Review request for shindig, Ryan Baxter and Stanton Sievers.
Changes
-------
Adding an example gadget.
Summary
-------
With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.
It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.
This addresses bug SHINDIG-1695.
https://issues.apache.org/jira/browse/SHINDIG-1695
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/ImageUploadGadget.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308
Diff: https://reviews.apache.org/r/3768/diff
Testing
-------
Thanks,
Dan