You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/07/07 19:38:05 UTC

[GitHub] [trafficcontrol] rob05c opened a new pull request, #6944: Change t3c h2 disable to enable

rob05c opened a new pull request, #6944:
URL: https://github.com/apache/trafficcontrol/pull/6944

       Change t3c sni.yaml disable_h2 to http2 directive                                                                                                                                                           
                                                                                                                                                                                                                   
       ATS 9 is documented as allowing the disable_h2 directive in sni.yaml                                                                                                                                        
       (albiet deprecated). But it doesn't seem to work.                                                                                                                                                           
                                                                                                                                                                                                                   
       This changes cache config gen to generate the newer http2 directive                                                                                                                                         
       instead.    
   
   
   I'm labelling `bug` because even though this isn't a bug per the ATS documentation, it appears to create a behavioral bug in-practice.
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Control Cache Config (`t3c`, formerly ORT)
   - 
   ## What is the best way to verify this PR?
   Generate cache config, verify sni.yaml has `http2:` directives instead of `disable_h2` directives. Run ATS 9 with generated config, verify ATS enables or disables H2 appropriately.
   
   ## If this is a bugfix, which Traffic Control versions contained the bug?
   - 6.0.0
   - 6.0.1
   - 6.0.2
   - 6.1.0
   
   ## PR submission checklist
   - [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
   - ~[x] This PR has documentation~ no docs, details of cache config generated files are not documented <!-- If not, please delete this text and explain why this PR does not need documentation. -->
   - [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] ocket8888 merged pull request #6944: Change t3c h2 disable to enable

Posted by GitBox <gi...@apache.org>.
ocket8888 merged PR #6944:
URL: https://github.com/apache/trafficcontrol/pull/6944


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] smalenfant commented on pull request #6944: Change t3c h2 disable to enable

Posted by GitBox <gi...@apache.org>.
smalenfant commented on PR #6944:
URL: https://github.com/apache/trafficcontrol/pull/6944#issuecomment-1202858715

   Closes #6816


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org