You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/01 05:53:29 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5915: sched/note: add support of trace section mark

xiaoxiang781216 commented on a change in pull request #5915:
URL: https://github.com/apache/incubator-nuttx/pull/5915#discussion_r840254423



##########
File path: include/nuttx/sched_note.h
##########
@@ -105,16 +105,38 @@
   memset((s), 0, sizeof(struct note_filter_irq_s))
 #endif
 
-/* Note dump module tag definitions */
-
 #ifdef CONFIG_SCHED_INSTRUMENTATION_DUMP
-#  define NOTE_MODULE(a, b, c, d)  \
-  ((uint32_t)((a) & 0xff)        | \
-  ((uint32_t)((b) & 0xff) << 8)  | \
-  ((uint32_t)((c) & 0xff) << 16) | \
-  ((uint32_t)((d) & 0xff) << 24))
+#  define SCHED_NOTE_PASTE_(x, y) x ## y
+#  define SCHED_NOTE_PASTE(x, y) SCHED_NOTE_PASTE_(x, y)

Review comment:
       let's merge SCHED_NOTE_PASTE and SCHED_NOTE_PASTE_ into one:
   ```
   #define SCHED_NOTE_LABEL_(x, y) x ## y
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org