[GitHub] [pinot] snleee commented on a change in pull request #7470: Fix missing rate limiter if brokerResourceEV becomes null due to ZK connection

[GitBox <gi...@apache.org>]

snleee commented on a change in pull request #7470:
URL: https://github.com/apache/pinot/pull/7470#discussion_r714487620



##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java
##########
@@ -164,7 +164,8 @@ private void createOrUpdateRateLimiter(String tableNameWithType, ExternalView br
 
     if (brokerResource == null) {
       LOGGER.warn("Failed to init qps quota for table {}. No broker resource connected!", tableNameWithType);
-      buildEmptyOrResetRateLimiterInQueryQuotaEntity(tableNameWithType);
+      // It could be possible that brokerResourceEV due to ZK connection issue.

Review comment:
       Can you update the comment about `brokerResourceEV`? You meant `brokerResource is null`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org